From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1727 invoked by alias); 23 Nov 2016 22:11:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 130238 invoked by uid 89); 23 Nov 2016 22:11:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*Ad:D*fi, sk:gdbarch, Stefan, bfd_endian X-HELO: mail-pg0-f67.google.com Received: from mail-pg0-f67.google.com (HELO mail-pg0-f67.google.com) (74.125.83.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 Nov 2016 22:11:18 +0000 Received: by mail-pg0-f67.google.com with SMTP id x23so1922289pgx.3 for ; Wed, 23 Nov 2016 14:11:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=E/ocHpSSyUqhQHAFYjeSeKoQzmjquo1wrWAZRyzJBBg=; b=EoPvLxbBxzO8DI7ZLZnLwi+i6BVisim9t/PPiB6bJRriUd2qb0jV19bUKCAFCigQ8f 9Y6pm+goUuX/gfJifbpRxoQNPyf/gWWOTW39g+5S3DMEJbLmN+UgM8YaiLqCG45RFddD 93/jzZizJtiUlFem361I1A7BHG78lcOohMAx4xxUwI8XI2WWHgH1uOeeLXSJB2uSLxIT nEjDEAmml+CEB3AAD0iZKMRKa44M/Bp1lakgRgCQQGxZu/zpt+SyZsAsxyd93ubDySFP cq90OB1g90Pe4PbjBV1S7gbGNxydXgctahOD0NcOPS5Jc0/f9M3R4GsrDhMkgs+CiMnQ 8dxQ== X-Gm-Message-State: AKaTC01mqQTrZTV6Rk9EobbLU9J1PpKVldTB5I/EARqKdllCmVytEZpKINiQMXwW8OmqMQ== X-Received: by 10.99.166.2 with SMTP id t2mr9093407pge.40.1479939077010; Wed, 23 Nov 2016 14:11:17 -0800 (PST) Received: from lianli.shorne-pla.net (z14.124-44-185.ppp.wakwak.ne.jp. [124.44.185.14]) by smtp.gmail.com with ESMTPSA id s2sm54971455pfi.10.2016.11.23.14.11.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Nov 2016 14:11:16 -0800 (PST) Received: from lianli.shorne-pla.net (localhost [127.0.0.1]) by lianli.shorne-pla.net (8.15.2/8.15.2) with ESMTPS id uANMBEr7001479 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 24 Nov 2016 07:11:14 +0900 Received: (from shorne@localhost) by lianli.shorne-pla.net (8.15.2/8.15.2/Submit) id uANMBEk4001478; Thu, 24 Nov 2016 07:11:14 +0900 From: Stafford Horne To: gdb-patches@sourceware.org Cc: openrisc@lists.librecores.org, Stefan Kristiansson Subject: [PATCH 10/18] gdb: or1k: Fixes for things that broke after upstream merge Date: Wed, 23 Nov 2016 22:13:00 -0000 Message-Id: <1479939044-1341-11-git-send-email-shorne@gmail.com> In-Reply-To: <1479939044-1341-1-git-send-email-shorne@gmail.com> References: <1479939044-1341-1-git-send-email-shorne@gmail.com> X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00703.txt.bz2 From: Stefan Kristiansson gdb/ChangeLog: * or1k-tdep.c (or1k_fetch_instruction): Change char to gdb_byte to prevent pointer signedness error. (or1k_push_dummy_code): Likewise. --- gdb/or1k-tdep.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/gdb/or1k-tdep.c b/gdb/or1k-tdep.c index f938077..ae57734 100644 --- a/gdb/or1k-tdep.c +++ b/gdb/or1k-tdep.c @@ -164,7 +164,7 @@ or1k_fetch_instruction (struct gdbarch *gdbarch, CORE_ADDR addr) { enum bfd_endian byte_order = gdbarch_byte_order (gdbarch); - char buf[OR1K_INSTLEN]; + gdb_byte buf[OR1K_INSTLEN]; int status; status = target_read_memory (addr, buf, OR1K_INSTLEN); @@ -1247,8 +1247,8 @@ or1k_push_dummy_call (struct gdbarch *gdbarch, /* Put as many args as possible in registers */ for (argnum = 0; argnum < nargs; argnum++) { - char *val; - char valbuf[sizeof (ULONGEST) ]; + const gdb_byte *val; + gdb_byte valbuf[sizeof (ULONGEST)]; struct value *arg = args[argnum]; struct type *arg_type = check_typedef (value_type (arg)); @@ -1266,7 +1266,7 @@ or1k_push_dummy_call (struct gdbarch *gdbarch, else { /* Everything else, we just get the value. */ - val = (char *) value_contents (arg); + val = value_contents (arg); } /* Stick the value in a register */ @@ -1346,8 +1346,8 @@ or1k_push_dummy_call (struct gdbarch *gdbarch, /* Push the remaining args on the stack */ for (argnum = first_stack_arg; argnum < nargs; argnum++) { - char *val; - char valbuf[sizeof (ULONGEST) ]; + const gdb_byte *val; + gdb_byte valbuf[sizeof (ULONGEST) ]; struct value *arg = args[argnum]; struct type *arg_type = check_typedef (value_type (arg)); @@ -1364,7 +1364,7 @@ or1k_push_dummy_call (struct gdbarch *gdbarch, } else { - val = (char *) value_contents (arg); + val = value_contents (arg); } gdb_assert (len <= (bpw * 2)); -- 2.7.4