From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114563 invoked by alias); 22 Nov 2016 15:49:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 114539 invoked by uid 89); 22 Nov 2016 15:49:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Restrict, Hx-languages-length:882 X-HELO: mail-pg0-f68.google.com Received: from mail-pg0-f68.google.com (HELO mail-pg0-f68.google.com) (74.125.83.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 22 Nov 2016 15:48:58 +0000 Received: by mail-pg0-f68.google.com with SMTP id p66so2421430pga.2 for ; Tue, 22 Nov 2016 07:48:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=p+J1BHDWameb7AW9gyXt/bpNQAjIm4fhzOelmj/N014=; b=Z4buRWspIDffr9ICgMtFQAKYlev+4Q08PJW18HgK2K1WUFTqR+8zce5FONeGDq20Zx wD/xKy4x2TY3CAf/SI9PfwJoUhQ9cFuC0ULyDJnkGq9FXC8HyGasTZP10tFfkLKNbnwg rwXASr7XPj8CYAN56+HhfnEsFF9pkeR/VnjUQn/s1grgvuwRZGor19qEYIXU2wmDZhNz HDj6u5sn2dsu+A3TaYun3MbayyExhAlEFLmVnUIN4FliuJUfMFeUQ6A8mNezzzcK7VaI 57otAZQ/qjLwKiFaSyaDvdZR7Q6G7H+nh24X/ICeSUuHJ/eJpuyrhY2Uf/oGVzTLJswV UVTA== X-Gm-Message-State: AKaTC030NXeVwT9Jo9sQDO3SzEDBDGeEEpCjsvL8bfDshX0qt+Xcqwjx4jJz63j7olQe/w== X-Received: by 10.98.214.20 with SMTP id r20mr26426354pfg.59.1479829736848; Tue, 22 Nov 2016 07:48:56 -0800 (PST) Received: from E107787-LIN.cambridge.arm.com (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id o68sm46198774pfb.42.2016.11.22.07.48.55 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 22 Nov 2016 07:48:56 -0800 (PST) From: Yao Qi X-Google-Original-From: Yao Qi To: gdb-patches@sourceware.org Subject: [PATCH 3/3] Restrict value_has_address Date: Tue, 22 Nov 2016 15:49:00 -0000 Message-Id: <1479829721-22162-4-git-send-email-yao.qi@linaro.org> In-Reply-To: <1479829721-22162-1-git-send-email-yao.qi@linaro.org> References: <1479829721-22162-1-git-send-email-yao.qi@linaro.org> X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00628.txt.bz2 gdb: 2016-11-21 Yao Qi * value.c (value_has_address): Return true if lval is either lval_memory or lval_register. --- gdb/value.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gdb/value.c b/gdb/value.c index a093a9a..5ac9123 100644 --- a/gdb/value.c +++ b/gdb/value.c @@ -1540,14 +1540,14 @@ value_lval_const (const struct value *value) return value->lval; } -/* Return true if VALUE has address, otherwise return false. */ +/* Return true if VALUE->location.address is valid, otherwise return + false. */ static int value_has_address (const struct value *value) { - return (value->lval != lval_internalvar - && value->lval != lval_internalvar_component - && value->lval != lval_xcallable); + return (value->lval == lval_memory + || value->lval == lval_register); } CORE_ADDR -- 1.9.1