RE: [PATCH v3 7/8] python: Add tests for record Python bindings

Metzger, Markus T
2016-11-29T15:48:44Z

> -----Original Message-----
> From: Wiederhake, Tim
> Sent: Monday, November 21, 2016 4:49 PM
> To: gdb-patches@sourceware.org
> Cc: palves@redhat.com; Metzger, Markus T <markus.t.metzger@intel.com>
> Subject: [PATCH v3 7/8] python: Add tests for record Python bindings
>
> 2016-11-21 Tim Wiederhake <tim.wiederhake@intel.com>
>
> gdb/testsuite/ChangeLog:
>
> * gdb.python/py-record-btrace.c: New file.
> * gdb.python/py-record-btrace.exp: New file.

The tests cover start/stop for record-full. Would it make sense to move
them to a separate test file?

> +with_test_prefix "preopened record full" {
> + gdb_test_no_output "record full"
> + gdb_test "python print(gdb.current_recording().method)" "full"
> + gdb_test "python print(gdb.current_recording().format)" "full"

The "info record" command does not list a format for method "full".

IIRC we don't return None so in this regard, "full" is certainly better
than "unknown".

The patch looks good to me but we need to find a maintainer to approve it.

thanks,
Markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928