RE: [PATCH v3 0/8] Python bindings for btrace recordings

Metzger, Markus T
2016-11-29T15:49:05Z

> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Tim Wiederhake
> Sent: Monday, November 21, 2016 4:49 PM
> To: gdb-patches@sourceware.org
> Cc: palves@redhat.com; Metzger, Markus T <markus.t.metzger@intel.com>
> Subject: [PATCH v3 0/8] Python bindings for btrace recordings
>
> This patch series adds Python bindings for btrace recordings.
>
> V1 of this series can be found here:
> https://sourceware.org/ml/gdb-patches/2016-10/msg00733.html
>
> V2 of this series can be found here:
> https://sourceware.org/ml/gdb-patches/2016-11/msg00084.html
>
> Changes in V3:
> - Rebased to current master.
> - Replaced some strncmp with strcmp in patch 4 ("Add record_start function").
> - Incorporated Eli's feedback regarding the documentation part.
>
> Tim Wiederhake (8):
> btrace: Count gaps as one instruction explicitly.
> btrace: Export btrace_decode_error function.
> btrace: Use binary search to find instruction.
> Add record_start function.
> python: Create Python bindings for record history.
> python: Implement btrace Python bindings for record history.
> python: Add tests for record Python bindings
> Add documentation for new instruction record Python bindings.

Thanks for this patch series. This adds a very nice feature IMHO.

I'm OK with the record-btrace bits. See feedback on individual patches for
a few nits.

You need to find a maintainer to approve the Python bits.

Thanks,
Markus.

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928