From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4786 invoked by alias); 20 Nov 2016 20:42:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3551 invoked by uid 89); 20 Nov 2016 20:42:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=python.c, UD:python.c, pythonc, py-unwind.c X-HELO: gproxy7-pub.mail.unifiedlayer.com Received: from gproxy7-pub.mail.unifiedlayer.com (HELO gproxy7-pub.mail.unifiedlayer.com) (70.40.196.235) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Sun, 20 Nov 2016 20:41:48 +0000 Received: (qmail 3025 invoked by uid 0); 20 Nov 2016 20:41:46 -0000 Received: from unknown (HELO cmgw3) (10.0.90.84) by gproxy7.mail.unifiedlayer.com with SMTP; 20 Nov 2016 20:41:46 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id ALhj1u00X2f2jeq01LhmAN; Sun, 20 Nov 2016 13:41:46 -0700 X-Authority-Analysis: v=2.1 cv=K/+xQUmI c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=L24OOQBejmoA:10 a=zstS-IiYAAAA:8 a=AQJ4OHOvz4lQCWLdgVQA:9 a=4G6NA9xxw8l3yy4pmD5M:22 Received: from 174-16-143-211.hlrn.qwest.net ([174.16.143.211]:40590 helo=bapiya.Home) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1c8Yvn-0005f5-Im; Sun, 20 Nov 2016 13:41:43 -0700 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [RFA 09/13] Use gdbpy_ref in pyuw_object_attribute_to_pointer Date: Sun, 20 Nov 2016 20:42:00 -0000 Message-Id: <1479674496-14000-10-git-send-email-tom@tromey.com> In-Reply-To: <1479674496-14000-1-git-send-email-tom@tromey.com> References: <1479674496-14000-1-git-send-email-tom@tromey.com> X-BWhitelist: no X-Exim-ID: 1c8Yvn-0005f5-Im X-Source-Sender: 174-16-143-211.hlrn.qwest.net (bapiya.Home) [174.16.143.211]:40590 X-Source-Auth: tom+tromey.com X-Email-Count: 11 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-11/txt/msg00588.txt.bz2 This changes pyuw_object_attribute_to_pointer to use gdbpy_ref. 2016-11-20 Tom Tromey * python/py-unwind.c (pyuw_object_attribute_to_pointer): Use gdbpy_ref. --- gdb/ChangeLog | 5 +++++ gdb/python/py-unwind.c | 5 ++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index ab0cefb..3016d3a 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,10 @@ 2016-11-20 Tom Tromey + * python/py-unwind.c (pyuw_object_attribute_to_pointer): Use + gdbpy_ref. + +2016-11-20 Tom Tromey + * python/python.c (eval_python_command, gdbpy_decode_line) (gdbpy_run_events, gdbpy_start_type_printers) (gdbpy_apply_type_printers): Use gdbpy_ref. diff --git a/gdb/python/py-unwind.c b/gdb/python/py-unwind.c index 416223c..2c75e1d 100644 --- a/gdb/python/py-unwind.c +++ b/gdb/python/py-unwind.c @@ -177,18 +177,17 @@ pyuw_object_attribute_to_pointer (PyObject *pyo, const char *attr_name, if (PyObject_HasAttrString (pyo, attr_name)) { - PyObject *pyo_value = PyObject_GetAttrString (pyo, attr_name); + gdbpy_ref pyo_value (PyObject_GetAttrString (pyo, attr_name)); if (pyo_value != NULL && pyo_value != Py_None) { - rc = pyuw_value_obj_to_pointer (pyo_value, addr); + rc = pyuw_value_obj_to_pointer (pyo_value.get (), addr); if (!rc) PyErr_Format ( PyExc_ValueError, _("The value of the '%s' attribute is not a pointer."), attr_name); } - Py_XDECREF (pyo_value); } return rc; } -- 2.7.4