From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 78823 invoked by alias); 7 Nov 2016 05:48:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 76152 invoked by uid 89); 7 Nov 2016 05:48:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*r:4.86_1, oi, H*Ad:U*tom, *block X-HELO: gproxy6-pub.mail.unifiedlayer.com Received: from gproxy6-pub.mail.unifiedlayer.com (HELO gproxy6-pub.mail.unifiedlayer.com) (67.222.39.168) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Mon, 07 Nov 2016 05:47:48 +0000 Received: (qmail 1709 invoked by uid 0); 7 Nov 2016 05:47:47 -0000 Received: from unknown (HELO cmgw2) (10.0.90.83) by gproxy6.mail.unifiedlayer.com with SMTP; 7 Nov 2016 05:47:47 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id 4tni1u00F2f2jeq01tnlw7; Sun, 06 Nov 2016 22:47:45 -0700 X-Authority-Analysis: v=2.1 cv=PIacp5aC c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=L24OOQBejmoA:10 a=zstS-IiYAAAA:8 a=2wDKstmCveUThciJc88A:9 a=4G6NA9xxw8l3yy4pmD5M:22 Received: from 174-16-143-211.hlrn.qwest.net ([174.16.143.211]:47918 helo=bapiya.Home) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1c3cmV-0008A3-T7; Sun, 06 Nov 2016 22:47:44 -0700 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [RFA 14/14] Use gdbpy_reference in gdbpy_lookup_symbol Date: Mon, 07 Nov 2016 05:48:00 -0000 Message-Id: <1478497656-11832-15-git-send-email-tom@tromey.com> In-Reply-To: <1478497656-11832-1-git-send-email-tom@tromey.com> References: <1478497656-11832-1-git-send-email-tom@tromey.com> X-BWhitelist: no X-Exim-ID: 1c3cmV-0008A3-T7 X-Source-Sender: 174-16-143-211.hlrn.qwest.net (bapiya.Home) [174.16.143.211]:47918 X-Source-Auth: tom+tromey.com X-Email-Count: 15 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-11/txt/msg00126.txt.bz2 This changes gdbpy_lookup_symbol to use gdbpy_reference. 2016-11-06 Tom Tromey * python/py-symbol.c (gdbpy_lookup_symbol): Use gdbpy_reference. --- gdb/ChangeLog | 4 ++++ gdb/python/py-symbol.c | 18 ++++++++---------- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 56fadac..6499a27 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,9 @@ 2016-11-06 Tom Tromey + * python/py-symbol.c (gdbpy_lookup_symbol): Use gdbpy_reference. + +2016-11-06 Tom Tromey + * python/py-value.c (value_has_field, get_field_flag) (get_field_type, valpy_getitem, convert_value_from_python): Use gdbpy_reference. diff --git a/gdb/python/py-symbol.c b/gdb/python/py-symbol.c index e0569d2..b0d92b2 100644 --- a/gdb/python/py-symbol.c +++ b/gdb/python/py-symbol.c @@ -23,6 +23,7 @@ #include "symtab.h" #include "python-internal.h" #include "objfiles.h" +#include "py-ref.h" typedef struct sympy_symbol_object { PyObject_HEAD @@ -374,7 +375,7 @@ gdbpy_lookup_symbol (PyObject *self, PyObject *args, PyObject *kw) const char *name; static char *keywords[] = { "name", "block", "domain", NULL }; struct symbol *symbol = NULL; - PyObject *block_obj = NULL, *ret_tuple, *sym_obj, *bool_obj; + PyObject *block_obj = NULL, *sym_obj, *bool_obj; const struct block *block = NULL; if (! PyArg_ParseTupleAndKeywords (args, kw, "s|O!i", keywords, &name, @@ -410,31 +411,28 @@ gdbpy_lookup_symbol (PyObject *self, PyObject *args, PyObject *kw) } END_CATCH - ret_tuple = PyTuple_New (2); - if (!ret_tuple) + gdbpy_reference ret_tuple (PyTuple_New (2)); + if (ret_tuple == NULL) return NULL; if (symbol) { sym_obj = symbol_to_symbol_object (symbol); if (!sym_obj) - { - Py_DECREF (ret_tuple); - return NULL; - } + return NULL; } else { sym_obj = Py_None; Py_INCREF (Py_None); } - PyTuple_SET_ITEM (ret_tuple, 0, sym_obj); + PyTuple_SET_ITEM (ret_tuple.get (), 0, sym_obj); bool_obj = (is_a_field_of_this.type != NULL) ? Py_True : Py_False; Py_INCREF (bool_obj); - PyTuple_SET_ITEM (ret_tuple, 1, bool_obj); + PyTuple_SET_ITEM (ret_tuple.get (), 1, bool_obj); - return ret_tuple; + return ret_tuple.release (); } /* Implementation of -- 2.7.4