From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qN4QJ2+//mBQWAAAWB0awg (envelope-from ) for ; Mon, 26 Jul 2021 09:58:07 -0400 Received: by simark.ca (Postfix, from userid 112) id 9D9191EDFB; Mon, 26 Jul 2021 09:58:07 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E86901E813 for ; Mon, 26 Jul 2021 09:58:06 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9BDAE3899015 for ; Mon, 26 Jul 2021 13:58:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9BDAE3899015 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1627307886; bh=da0mIQDUAyn4z3Gol18iomMU33gzdJMEvN7Wo0RFKHo=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=G0UInx/1fZjh2ntik33G/LbMRvG7aJNhgrZcTyQZyR6vbgA9WH80s8TPPtabdbbGf f8zGfmyc17xYQLUtIdZMzsEKBxYC7QusF5kFpW7VXGLpu1WvWggmfeqdIQEX8NWa20 va5JM2bXeoAaR4i51FMR3NGPMh3Afyhtsf7cfizI= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 8F2EF3899005 for ; Mon, 26 Jul 2021 13:57:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8F2EF3899005 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 16QDv3MI004543 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 26 Jul 2021 09:57:08 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 16QDv3MI004543 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 3A4E71E813; Mon, 26 Jul 2021 09:57:03 -0400 (EDT) Subject: Re: [PATCHv3 0/2] Fix for an assertion when unwinding with inline frames To: Andrew Burgess References: <0e7ab535-8c62-cd78-487e-f076d022388f@polymtl.ca> <20210726111149.GG1872618@embecosm.com> Message-ID: <1475fb4d-0bab-7fac-134b-7dad9acd6a6b@polymtl.ca> Date: Mon, 26 Jul 2021 09:57:02 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210726111149.GG1872618@embecosm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 26 Jul 2021 13:57:03 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: Joel Brobecker , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-07-26 7:11 a.m., Andrew Burgess wrote: > * Simon Marchi [2021-07-20 17:59:45 -0400]: > >> On 2021-07-20 5:10 a.m., Andrew Burgess wrote: >>> Thanks for the feedback on v2. >>> >>> In v3 I have: >>> >>> - Addressed all of Pedro's feedback on the test in patch #1. >>> >>> - Rewritten how the problem in patch #1 is fixed based on Simon's >>> exception based approach. >>> >>> Thanks, >>> Andrew >> >> When speaking to Pedro off-line, it did sound like he had concerns with >> what I proposed, so let's wait to hear what he has to say. > > That's fine. Hopefully Pedro will be able to offer some feedback > soon. > > Before then, I've spun off patch #2 and an additional fix related to > 'set debug frame on' into a separate patch (below). I think all of > this code is unrelated to the whole should we use an exception, or > change the API of get_prev_frame. > > What are your thoughts on this patch? > > Additionally, this one might be a possible candidate for merging into > gdb-11-branch. Here's a ChangeLog if we decide that's a good idea. > > gdb/ChangeLog: > * frame.c (get_prev_frame_always_1): Handle case where > this_frame->prev is nullptr. > (get_prev_frame_id_by_id): Delete. > * frame.h (get_prev_frame_id_by_id): Delete declaration. > * valops.c (value_assign): Remove use of VALUE_FRAME_ID. > * vaule.c (value_fetch_lazy_register): Likewise. > * value.h (VALUE_FRAME_ID): Delete. > > gdb/testsuite/ChangeLog: > * gdb.base/premature-dummy-frame-removal.exp: Repeat test with > 'set debug frame on' in effect. > > Thanks, > Andrew The patch below does LGTM, thanks. Simon