RE: [PATCH] arc: Remove annoying debug message

Pierre Muller
2016-09-30T21:09:36Z

Hi,

I was wondering if it would not be better to
restrict such debug for higher debugging levels.

According to _initialize_arc_tdep,
arc_debug is an integer value, and can thus be set to values above 1,
to get more verbose output.

Thus another modification could be:

if (arc_debug > 1)
debug_printf ("arc: frame_prev_register (regnum = %d)\n", regnum);

Similar code is already used for record_debug or
gdbarch_debug variables.

Pierre Muller

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Anton Kolesov
> Envoyé : vendredi 30 septembre 2016 20:00
> À : gdb-patches@sourceware.org
> Cc : Anton Kolesov; Francois Bedard
> Objet : [PATCH] arc: Remove annoying debug message
>
> This logging message is called too often - once for each register when
> it's
> value has to be evaluated. This floods the screen for commands like
> "info
> register all", but doesn't give really any help at debugging GDB
> issues.
> Between increasing the debug level of this message and removing it
> altogether I
> think that removing it is preferable.
>
> gdb/ChangeLog:
>
> arc-tdep.c (arc_frame_prev_register): Remove annoying log
> message.
> ---
> gdb/arc-tdep.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/gdb/arc-tdep.c b/gdb/arc-tdep.c
> index 7bb93ad..60a4e04 100644
> --- a/gdb/arc-tdep.c
> +++ b/gdb/arc-tdep.c
> @@ -876,9 +876,6 @@ static struct value *
> arc_frame_prev_register (struct frame_info *this_frame,
> void **this_cache, int regnum)
> {
> - if (arc_debug)
> - debug_printf ("arc: frame_prev_register (regnum = %d)\n", regnum);
> -
> if (*this_cache == NULL)
> *this_cache = arc_make_frame_cache (this_frame);
> struct arc_frame_cache *cache = (struct arc_frame_cache *)
> (*this_cache);
> --
> 2.8.1