From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76319 invoked by alias); 27 Sep 2016 18:16:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 76266 invoked by uid 89); 27 Sep 2016 18:16:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=887, D*be X-HELO: gproxy4-pub.mail.unifiedlayer.com Received: from gproxy4-pub.mail.unifiedlayer.com (HELO gproxy4-pub.mail.unifiedlayer.com) (69.89.23.142) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Tue, 27 Sep 2016 18:16:45 +0000 Received: (qmail 22504 invoked by uid 0); 27 Sep 2016 18:16:44 -0000 Received: from unknown (HELO cmgw2) (10.0.90.83) by gproxy4.mail.unifiedlayer.com with SMTP; 27 Sep 2016 18:16:44 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id oiGf1t01W2f2jeq01iGiLw; Tue, 27 Sep 2016 12:16:42 -0600 X-Authority-Analysis: v=2.1 cv=F4vEKMRN c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=GW1xBdLrtEIA:10 a=zstS-IiYAAAA:8 a=D6I76i5Cml1L_2liRakA:9 a=4G6NA9xxw8l3yy4pmD5M:22 Received: from 71-218-192-86.hlrn.qwest.net ([71.218.192.86]:60956 helo=bapiya.Home) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1bowvp-0000eX-9J; Tue, 27 Sep 2016 12:16:41 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [RFA 3/3] Fix "obvious" fall-through warnings Date: Tue, 27 Sep 2016 18:52:00 -0000 Message-Id: <1475000192-8789-4-git-send-email-tom@tromey.com> In-Reply-To: <1475000192-8789-1-git-send-email-tom@tromey.com> References: <1475000192-8789-1-git-send-email-tom@tromey.com> X-BWhitelist: no X-Exim-ID: 1bowvp-0000eX-9J X-Source-Sender: 71-218-192-86.hlrn.qwest.net (bapiya.Home) [71.218.192.86]:60956 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-09/txt/msg00377.txt.bz2 This patch fixes the subset of -Wimplicit-fallthrough warnings that I considered obvious. In most cases it was obvious from context that falling through was desired; here I added the appropriate comment. In a couple of cases it seemed clear that a "break" was missing. 2016-09-27 Tom Tromey * utils.c (can_dump_core) : Add fall-through comment. * mi/mi-main.c (mi_cmd_trace_frame_collected) : Add missing "break". * mi/mi-cmd-stack.c (mi_cmd_stack_list_locals) : Add missing "break". * eval.c (fetch_subexp_value) : Add fall-through comment. * d-valprint.c (d_val_print) : Add fall-through comment. * coffread.c (coff_symtab_read) : Add fall-through comment. --- gdb/ChangeLog | 14 ++++++++++++++ gdb/coffread.c | 1 + gdb/d-valprint.c | 1 + gdb/eval.c | 1 + gdb/mi/mi-cmd-stack.c | 1 + gdb/mi/mi-main.c | 1 + gdb/utils.c | 1 + 7 files changed, 20 insertions(+) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 83b051f..511dedc 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,19 @@ 2016-09-27 Tom Tromey + * utils.c (can_dump_core) : Add fall-through comment. + * mi/mi-main.c (mi_cmd_trace_frame_collected) : + Add missing "break". + * mi/mi-cmd-stack.c (mi_cmd_stack_list_locals) : + Add missing "break". + * eval.c (fetch_subexp_value) : Add fall-through + comment. + * d-valprint.c (d_val_print) : Add fall-through + comment. + * coffread.c (coff_symtab_read) : Add fall-through + comment. + +2016-09-27 Tom Tromey + * dwarf2loc.c (unimplemented): Add ATTRIBUTE_NORETURN. * completer.h (throw_max_completions_reached_error): Add ATTRIBUTE_NORETURN. diff --git a/gdb/coffread.c b/gdb/coffread.c index 49d6803..d3ebe97 100644 --- a/gdb/coffread.c +++ b/gdb/coffread.c @@ -932,6 +932,7 @@ coff_symtab_read (long symtab_offset, unsigned int nsyms, backtraces, so filter them out (from phdm@macqel.be). */ if (within_function) break; + /* Fall through. */ case C_STAT: case C_THUMBLABEL: case C_THUMBSTAT: diff --git a/gdb/d-valprint.c b/gdb/d-valprint.c index 620688b..4166a59 100644 --- a/gdb/d-valprint.c +++ b/gdb/d-valprint.c @@ -88,6 +88,7 @@ d_val_print (struct type *type, const gdb_byte *valaddr, int embedded_offset, stream, recurse, val, options); if (ret == 0) break; + /* Fall through. */ default: c_val_print (type, valaddr, embedded_offset, address, stream, recurse, val, options); diff --git a/gdb/eval.c b/gdb/eval.c index 00a107c..1f2fb00 100644 --- a/gdb/eval.c +++ b/gdb/eval.c @@ -237,6 +237,7 @@ fetch_subexp_value (struct expression *exp, int *pc, struct value **valp, case MEMORY_ERROR: if (!preserve_errors) break; + /* Fall through. */ default: throw_exception (ex); break; diff --git a/gdb/mi/mi-cmd-stack.c b/gdb/mi/mi-cmd-stack.c index 390fc7e..b51650d 100644 --- a/gdb/mi/mi-cmd-stack.c +++ b/gdb/mi/mi-cmd-stack.c @@ -246,6 +246,7 @@ mi_cmd_stack_list_locals (char *command, char **argv, int argc) { case NO_FRAME_FILTERS: raw_arg = oind; + break; case SKIP_UNAVAILABLE: skip_unavailable = 1; break; diff --git a/gdb/mi/mi-main.c b/gdb/mi/mi-main.c index 1913157..3b604e5 100644 --- a/gdb/mi/mi-main.c +++ b/gdb/mi/mi-main.c @@ -2815,6 +2815,7 @@ mi_cmd_trace_frame_collected (char *command, char **argv, int argc) break; case REGISTERS_FORMAT: registers_format = oarg[0]; + break; case MEMORY_CONTENTS: memory_contents = 1; break; diff --git a/gdb/utils.c b/gdb/utils.c index 9a83053..9d11780 100644 --- a/gdb/utils.c +++ b/gdb/utils.c @@ -562,6 +562,7 @@ can_dump_core (enum resource_limit_kind limit_kind) case LIMIT_CUR: if (rlim.rlim_cur == 0) return 0; + /* Fall through. */ case LIMIT_MAX: if (rlim.rlim_max == 0) -- 2.7.4