Re: [PATCH 0/6] S390: Watchpoint enhancements and hardware breakpoints

Andreas Arnez
2016-09-16T17:30:29Z

On Fri, Sep 16 2016, Pedro Alves wrote:

> I see. Thanks for the clarification.
>
> A comment to the effect in the code would be nice. Maybe it's
> there and I missed it.

OK, changed the relevant comment to this:

/* Don't install hardware breakpoints while single-stepping, since
our PER settings (e.g. the nullification bit) might then conflict
with the kernel's. But re-install them afterwards. */

Also changed the documentation of lwp_is_stepping as suggested by Yao:

/* Return nonzero if we are single-stepping this LWP at the ptrace
level. */

> I have no further comments on the series. LGTM.

Thanks. Pushed with the changes above.

--
Andreas