From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95379 invoked by alias); 31 Aug 2016 15:06:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 95221 invoked by uid 89); 31 Aug 2016 15:06:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=sk:ppc_lin, 45,8, Hx-languages-length:2476, HX-Received:10.98.34.151 X-HELO: mail-pf0-f194.google.com Received: from mail-pf0-f194.google.com (HELO mail-pf0-f194.google.com) (209.85.192.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 31 Aug 2016 15:06:15 +0000 Received: by mail-pf0-f194.google.com with SMTP id g202so2912566pfb.1 for ; Wed, 31 Aug 2016 08:06:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=mBo7PyzhPbzgAfmUXvyfWqvCx6U7Pv6+oMxbq6Wzx50=; b=d9G+IG6QfWONF93cAo7O2lHtW3wclrMmYgCL4LJIczYdqyDjYkeIGjVu4s3SDPSNWV joI2b4gZNLu4XHSsc9jND7OfRtXUMCozsmwgZoyyPAmQ6R0ANNNGVU8VKfPmF0uQWws8 QsoOa1Ef16Z40Lj5pf3rxfb5MWvxL6RIruD+pvfPLhc6mlF8ccO0Po1UhXrMFlRMF3XU tClcHntnsxwAKWdIY2llrCCTBROg91q9XggCHFg6kPEuolCU0WA8uzbYmJF8KcAMSMZr HnSGHkM2ZnUnu5kvp/JIKUdNgOX78nJh78V8tiHG2QQrzz3FdPzaMN95/JcJ+HqwJu1C Ntog== X-Gm-Message-State: AE9vXwMEM3nF7lBFH9/a6ULZq+f1q5BJ2DCQAYcWtOXRiZo3Bsz7xnBJFO3ANIeX/rCyWg== X-Received: by 10.98.34.151 with SMTP id p23mr17780304pfj.102.1472655973686; Wed, 31 Aug 2016 08:06:13 -0700 (PDT) Received: from E107787-LIN.cambridge.arm.com (gcc115.osuosl.org. [140.211.9.73]) by smtp.gmail.com with ESMTPSA id c125sm464809pfc.40.2016.08.31.08.06.12 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 31 Aug 2016 08:06:13 -0700 (PDT) From: Yao Qi X-Google-Original-From: Yao Qi To: gdb-patches@sourceware.org Subject: [PATCH 03/13] gdbarch_breakpoint_from_pc doesn't return NULL Date: Wed, 31 Aug 2016 15:06:00 -0000 Message-Id: <1472655965-12212-4-git-send-email-yao.qi@linaro.org> In-Reply-To: <1472655965-12212-1-git-send-email-yao.qi@linaro.org> References: <1472655965-12212-1-git-send-email-yao.qi@linaro.org> X-IsSubscribed: yes X-SW-Source: 2016-08/txt/msg00314.txt.bz2 gdbarch_breakpoint_from_pc doesn't return NULL except for ia64_breakpoint_from_pc, and we checked its return value in three places. In microblaze_linux_memory_remove_breakpoint and ppc_linux_memory_remove_breakpoint, gdbarch_breakpoint_from_pc never returns NULL, so we can remove the NULL checking. In default_memory_insert_breakpoint, gdbarch_breakpoint_from_pc can't returns NULL too because ia64 defines its own memory_insert_breakpoint. gdb: 2016-08-30 Yao Qi * mem-break.c (default_memory_insert_breakpoint): Don't check 'bp' against NULL. * microblaze-linux-tdep.c (microblaze_linux_memory_remove_breakpoint): Likewise. * ppc-linux-tdep.c (ppc_linux_memory_remove_breakpoint): Likewise. --- gdb/mem-break.c | 2 -- gdb/microblaze-linux-tdep.c | 2 -- gdb/ppc-linux-tdep.c | 2 -- 3 files changed, 6 deletions(-) diff --git a/gdb/mem-break.c b/gdb/mem-break.c index 803f62b..cc8145c 100644 --- a/gdb/mem-break.c +++ b/gdb/mem-break.c @@ -45,8 +45,6 @@ default_memory_insert_breakpoint (struct gdbarch *gdbarch, /* Determine appropriate breakpoint contents and size for this address. */ bp = gdbarch_breakpoint_from_pc (gdbarch, &addr, &bplen); - if (bp == NULL) - error (_("Software breakpoints not implemented for this target.")); bp_tgt->placed_address = addr; bp_tgt->placed_size = bplen; diff --git a/gdb/microblaze-linux-tdep.c b/gdb/microblaze-linux-tdep.c index 18ddfea..22e5959 100644 --- a/gdb/microblaze-linux-tdep.c +++ b/gdb/microblaze-linux-tdep.c @@ -49,8 +49,6 @@ microblaze_linux_memory_remove_breakpoint (struct gdbarch *gdbarch, /* Determine appropriate breakpoint contents and size for this address. */ bp = gdbarch_breakpoint_from_pc (gdbarch, &addr, &bplen); - if (bp == NULL) - error (_("Software breakpoints not implemented for this target.")); val = target_read_memory (addr, old_contents, bplen); diff --git a/gdb/ppc-linux-tdep.c b/gdb/ppc-linux-tdep.c index cde4f2e..5ce58d8 100644 --- a/gdb/ppc-linux-tdep.c +++ b/gdb/ppc-linux-tdep.c @@ -222,8 +222,6 @@ ppc_linux_memory_remove_breakpoint (struct gdbarch *gdbarch, /* Determine appropriate breakpoint contents and size for this address. */ bp = gdbarch_breakpoint_from_pc (gdbarch, &addr, &bplen); - if (bp == NULL) - error (_("Software breakpoints not implemented for this target.")); /* Make sure we see the memory breakpoints. */ cleanup = make_show_memory_breakpoints_cleanup (1); -- 1.9.1