From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12925 invoked by alias); 24 Aug 2016 15:15:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12839 invoked by uid 89); 24 Aug 2016 15:15:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:2058 X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 24 Aug 2016 15:15:33 +0000 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u7OFEWbl000841 for ; Wed, 24 Aug 2016 11:15:31 -0400 Received: from e35.co.us.ibm.com (e35.co.us.ibm.com [32.97.110.153]) by mx0b-001b2d01.pphosted.com with ESMTP id 250twygk24-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 24 Aug 2016 11:15:30 -0400 Received: from localhost by e35.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 24 Aug 2016 09:15:29 -0600 Received: from d03dlp03.boulder.ibm.com (9.17.202.179) by e35.co.us.ibm.com (192.168.1.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 24 Aug 2016 09:15:26 -0600 X-IBM-Helo: d03dlp03.boulder.ibm.com X-IBM-MailFrom: cel@us.ibm.com Received: from b03cxnp07028.gho.boulder.ibm.com (b03cxnp07028.gho.boulder.ibm.com [9.17.130.15]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id 0E9F919D8062; Wed, 24 Aug 2016 09:14:49 -0600 (MDT) Received: from b03ledav004.gho.boulder.ibm.com (b03ledav004.gho.boulder.ibm.com [9.17.130.235]) by b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u7OFFDOX62980290; Wed, 24 Aug 2016 08:15:17 -0700 Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D99A878057; Wed, 24 Aug 2016 09:15:16 -0600 (MDT) Received: from [9.70.82.29] (unknown [9.70.82.29]) by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP id 750DC78041; Wed, 24 Aug 2016 09:15:16 -0600 (MDT) Subject: Re: [PATCH] Fix for gdb.base/pc-fp.exp. From: "Carl E. Love" To: Ulrich Weigand Cc: Luis Machado , Pedro Alves , Edjunior Barbosa Machado , gdb-patches@sourceware.org Date: Wed, 24 Aug 2016 15:15:00 -0000 In-Reply-To: <20160823163023.AAA2B5BCB@oc7340732750.ibm.com> References: <20160823163023.AAA2B5BCB@oc7340732750.ibm.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16082415-0012-0000-0000-000010792960 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00005637; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000183; SDB=6.00749072; UDB=6.00353609; IPR=6.00521735; BA=6.00004673; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00012447; XFM=3.00000011; UTC=2016-08-24 15:15:28 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16082415-0013-0000-0000-000044D4DDEE Message-Id: <1472051715.4102.57.camel@us.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-24_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1608240141 X-SW-Source: 2016-08/txt/msg00244.txt.bz2 On Tue, 2016-08-23 at 18:30 +0200, Ulrich Weigand wrote: > Carl Love wrote: > > > That said, the code "set_gdbarch_deprecated_fp_regnum > > (gdbarch, PPC_R0_REGNUM + 1);" sets up register r1 as the frame pointer. > > Register r1 is no longer used to hold the frame pointer on Power. By > > removing the fp definition for Power in GDB, it causes GDB to fall back > > to the call get_frame_base_address (frame) which returns the correct value > > depending on the specific senario but most of the time is the DWARF > > canonical frame address. > > That's true. In fact, the one place that really cares about the value > returned via $fp is varobj.c:find_frame_addr_in_frame_chain, since you're > supposed to use the value of $fp to identify a frame for MI routines. > And there we explicitly assume that this value matches the value returned > by get_frame_base_address. > > > 2016-08-22 Carl Love > > > > * rs6000-tdep.c (rs6000_gdbarch_init): Remove deprecated call set_gdbarch_deprecated_fp_regnum() > > from Power architecture initialization function. > > Please watch the 80-char line length limit, which holds for the ChangeLog > as well. In fact, the text can be shortened anyway: "deprecated" is > redundant (included in the function name), and likewise is "from Power > architecture initialization function" (you already specified which > function --rs6000_gdbarch_init-- you're modifying). I'd suggest: > > * rs6000-tdep.c (rs6000_gdbarch_init): Remove call to > set_gdbarch_deprecated_fp_regnum. > > Patch is OK. > > Thanks, > Ulrich > Ulrich, Luis, Pedro: I haven't heard any additional discussion on this patch in the last 24 hours or so. I believe at this point everyone's questions/concerns have been addressed. I have pushed the patch. I did fix the line length issue on the ChangeLog entry and updated the dates. Thanks for the input and help with this patch. https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=bdd78711b4c1ae26dbc8c2a64f28abec3486ae6c Carl Love