Re: [PATCH 04/26] gdbserver: boolify and defaultize the 'fetch' parameter of get_thread_regcache

Simon Marchi
2023-12-21T20:25:06Z

On 2/28/23 06:28, Tankut Baris Aktemur via Gdb-patches wrote:
> Boolify the 'fetch' parameter of the get_thread_regcache function.
>
> All of the current uses pass true for this parameter. Therefore, define
> its default value as true and remove the argument from the uses.
>
> We still keep the parameter, though, to give downstream targets the
> option to obtain a regcache without having to fetch the whole
> contents. Our (Intel) downstream target is an example.

Just to understand better, can you explain what is the rationale of your
usage of fetch == false?

In any case, this LGTM, I think you can push it on its own, it's a good
cleanup.

Approved-By: Simon Marchi <simon.marchi@efficios.com>

Simon