Re: [PATCH v2 01/11] gdbserver: dump 'xx...x' in collect_register_as_string for unavailable register

Simon Marchi
2025-01-06T21:28:57Z

On 2024-12-30 05:49, Tankut Baris Aktemur wrote:
> Fix 'collect_register_as_string' so that unavailable registers are
> dumped as 'xx...x' instead of arbitrary values. This gives the
> opportunity that we can reuse 'collect_register_as_string' in
> 'registers_to_string' for additional code simplification.
>
> Note: This patch is also included in the "A new target to debug Intel GPUs"
> series at
> https://sourceware.org/pipermail/gdb-patches/2024-December/214029.html
>
> Reviewed-By: Luis Machado <luis.machado@arm.com>

Can you please clarify in the commit message where the impact of the
change is? I initially assumed (don't know why) this was fixing some
debug output. I dug a bit, and it seems like it specifically changes
the behavior when sending expedited regs.

Otherwise, the code changes LGTM:

Approved-By: Simon Marchi <simon.marchi@efficios.com>

Simon