From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 121721 invoked by alias); 3 May 2017 10:42:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 121696 invoked by uid 89); 3 May 2017 10:42:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hauthentication-results:gmail.com X-HELO: EUR02-VE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr20056.outbound.protection.outlook.com (HELO EUR02-VE1-obe.outbound.protection.outlook.com) (40.107.2.56) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 03 May 2017 10:42:02 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) by AM3PR08MB0103.eurprd08.prod.outlook.com (10.160.211.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1061.12; Wed, 3 May 2017 10:42:01 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::b823:64c1:afc5:3a08]) by AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::b823:64c1:afc5:3a08%17]) with mapi id 15.01.1061.021; Wed, 3 May 2017 10:42:01 +0000 From: Alan Hayward To: Yao Qi CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH] Remove MAX_REGISTER_SIZE from regcache.c Date: Wed, 03 May 2017 10:42:00 -0000 Message-ID: <1467DD03-A335-4CA3-9541-0A6DDB2FE7EA@arm.com> References: <562B2F6F-F3C6-4A76-9489-57539F396C94@arm.com> <868tnvukjh.fsf@gmail.com> <7359B5C0-BF61-42E2-9886-B322C1825865@arm.com> <0DADF920-69B9-4F96-A153-6965E56B5DA8@arm.com> <868tneq1xj.fsf@gmail.com> <86efx0ljsv.fsf@gmail.com> <86r30ep4ml.fsf@gmail.com> <3418367D-9E13-49C7-9C9B-91B0DC1AB0A4@arm.com> <86h912bbac.fsf@gmail.com> In-Reply-To: <86h912bbac.fsf@gmail.com> authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=arm.com; x-microsoft-exchange-diagnostics: 1;AM3PR08MB0103;7:czMF1XsQFZQ3itKtZUQrBVSWvmu/qAEJazK/wcIMv5QSV3OXBscOi9Z88wlgX0LuTg6muFSejf1BUTak29nGZMOQA0gH1TMJCM1jBA1o1BYvqYPTVq3nSCdrkOOUTifmUqLKG7Y8IB1W9xDO6VEDhHPyumkLLjKXncnMbis7wJ7qN1YtegQmnkLpLM2JAGWmvZg4oIO8LeifcXLzPJoF+CfIPS73NSSzCkXa0O/mu0TFxV+9Id0KHdHwajHEpPC/G2M30CqV9qkucl4hlcyblFdBOEnztHWxcb9y9b/0nuT86GGFaJvj74+LWB9jFGSU9j5dFMhn01YraRvWdrBzMg== x-ms-office365-filtering-correlation-id: 0df1b745-6b20-4c76-2bad-08d49211084d x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081);SRVR:AM3PR08MB0103; nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123564025)(20161123560025)(20161123555025)(6072148);SRVR:AM3PR08MB0103;BCL:0;PCL:0;RULEID:;SRVR:AM3PR08MB0103; x-forefront-prvs: 029651C7A1 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(979002)(6009001)(39850400002)(39410400002)(39400400002)(39860400002)(39450400003)(39840400002)(24454002)(377424004)(36756003)(53936002)(102836003)(305945005)(3846002)(6116002)(189998001)(6246003)(7736002)(53546009)(478600001)(25786009)(4326008)(2900100001)(82746002)(110136004)(6512007)(6916009)(83716003)(99286003)(2950100002)(54906002)(5660300001)(5250100002)(38730400002)(66066001)(50986999)(229853002)(6436002)(575784001)(86362001)(54356999)(33656002)(6486002)(76176999)(6506006)(1411001)(8676002)(81166006)(3280700002)(39060400002)(93886004)(8936002)(2906002)(3660700001)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR08MB0103;H:AM3PR08MB0101.eurprd08.prod.outlook.com;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2017 10:42:01.4332 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0103 X-SW-Source: 2017-05/txt/msg00044.txt.bz2 DQo+IE9uIDMgTWF5IDIwMTcsIGF0IDA5OjIxLCBZYW8gUWkgPHFpeWFvbHRj QGdtYWlsLmNvbT4gd3JvdGU6DQo+IA0KPiBBbGFuIEhheXdhcmQgPEFsYW4u SGF5d2FyZEBhcm0uY29tPiB3cml0ZXM6DQo+IA0KPj4gVGhhdOKAmXMgZmlu ZS4gTXkgcmViYXNlIHNob3VsZCBiZSBlYXN5IGVub3VnaC4NCj4+IElmIHlv dSByZW1lbWJlciwgY291bGQgeW91IGxldCBtZSBrbm93IHdoZW4geW91IGhh dmUgcHVzaGVkIHlvdXIgcGF0Y2guDQo+IA0KPiBIaSBBbGFuLA0KPiBNeSBw YXRjaCBzZXQgaXMgcHVzaGVkIGluLiAgWW91IGNhbiByZWJhc2UgeW91ciBw YXRjaC4NCj4gDQo+IC0tIA0KPiBZYW8gKOm9kOWwpykNCg0KUGF0Y2ggdXBk YXRlZCB0byBoZWFkLg0KDQpUZXN0ZWQgb24gYSAtLWVuYWJsZS10YXJnZXRz PWFsbCB1c2luZyBtYWtlIGNoZWNrIHdpdGggYm9hcmQgZmlsZXMNCnVuaXgg YW5kIG5hdGl2ZS1nZGJzZXJ2ZXIuDQoNCk9rIHRvIGNvbW1pdD8NCg0KQWxh bi4NCg0KMjAxNy0wNS0wMyAgQWxhbiBIYXl3YXJkICA8YWxhbi5oYXl3YXJk QGFybS5jb20+DQoNCgkqIHJlZ2NhY2hlLmMgKHJlZ2NhY2hlX3NhdmUpOiBB dm9pZCBidWZmZXIgdXNlLg0KCShyZWdjYWNoZV9kdW1wKTogTGlrZXdpc2Uu DQoNCg0KZGlmZiAtLWdpdCBhL2dkYi9yZWdjYWNoZS5jIGIvZ2RiL3JlZ2Nh Y2hlLmMNCmluZGV4IDI1NTI0NmIyNjA2MDM2ZjE3OGM3ZGIzMTI1ZWNkNDY1 ZGJjMWFmMDUuLjVkMzE5MTUzYWQxMTg0Yjc1NGRiYjBiYzc0MGMzYmJiNTlk ZmEyZTggMTAwNjQ0DQotLS0gYS9nZGIvcmVnY2FjaGUuYw0KKysrIGIvZ2Ri L3JlZ2NhY2hlLmMNCkBAIC0zMjcsNyArMzI3LDYgQEAgcmVnY2FjaGU6OnNh dmUgKHJlZ2NhY2hlX2Nvb2tlZF9yZWFkX2Z0eXBlICpjb29rZWRfcmVhZCwN CiAJCXZvaWQgKnNyYykNCiB7DQogICBzdHJ1Y3QgZ2RiYXJjaCAqZ2RiYXJj aCA9IG1fZGVzY3ItPmdkYmFyY2g7DQotICBnZGJfYnl0ZSBidWZbTUFYX1JF R0lTVEVSX1NJWkVdOw0KICAgaW50IHJlZ251bTsNCg0KICAgLyogVGhlIERT VCBzaG91bGQgYmUgYHJlYWQtb25seScsIGlmIGl0IHdhc24ndCB0aGVuIHRo ZSBzYXZlIHdvdWxkDQpAQCAtMzQ1LDE4ICszNDQsMTQgQEAgcmVnY2FjaGU6 OnNhdmUgKHJlZ2NhY2hlX2Nvb2tlZF9yZWFkX2Z0eXBlICpjb29rZWRfcmVh ZCwNCiAgICAgew0KICAgICAgIGlmIChnZGJhcmNoX3JlZ2lzdGVyX3JlZ2dy b3VwX3AgKGdkYmFyY2gsIHJlZ251bSwgc2F2ZV9yZWdncm91cCkpDQogCXsN Ci0JICBlbnVtIHJlZ2lzdGVyX3N0YXR1cyBzdGF0dXMgPSBjb29rZWRfcmVh ZCAoc3JjLCByZWdudW0sIGJ1Zik7DQorCSAgZ2RiX2J5dGUgKmRzdF9idWYg PSByZWdpc3Rlcl9idWZmZXIgKHJlZ251bSk7DQorCSAgZW51bSByZWdpc3Rl cl9zdGF0dXMgc3RhdHVzID0gY29va2VkX3JlYWQgKHNyYywgcmVnbnVtLCBk c3RfYnVmKTsNCg0KLQkgIGlmIChzdGF0dXMgPT0gUkVHX1ZBTElEKQ0KLQkg ICAgbWVtY3B5IChyZWdpc3Rlcl9idWZmZXIgKHJlZ251bSksIGJ1ZiwNCi0J CSAgICByZWdpc3Rlcl9zaXplIChnZGJhcmNoLCByZWdudW0pKTsNCi0JICBl bHNlDQotCSAgICB7DQotCSAgICAgIGdkYl9hc3NlcnQgKHN0YXR1cyAhPSBS RUdfVU5LTk9XTik7DQorCSAgZ2RiX2Fzc2VydCAoc3RhdHVzICE9IFJFR19V TktOT1dOKTsNCisNCisJICBpZiAoc3RhdHVzICE9IFJFR19WQUxJRCkNCisJ ICAgIG1lbXNldCAoZHN0X2J1ZiwgMCwgcmVnaXN0ZXJfc2l6ZSAoZ2RiYXJj aCwgcmVnbnVtKSk7DQoNCi0JICAgICAgbWVtc2V0IChyZWdpc3Rlcl9idWZm ZXIgKHJlZ251bSksIDAsDQotCQkgICAgICByZWdpc3Rlcl9zaXplIChnZGJh cmNoLCByZWdudW0pKTsNCi0JICAgIH0NCiAJICBtX3JlZ2lzdGVyX3N0YXR1 c1tyZWdudW1dID0gc3RhdHVzOw0KIAl9DQogICAgIH0NCkBAIC0xNDM5LDcg KzE0MzQsNiBAQCByZWdjYWNoZTo6ZHVtcCAodWlfZmlsZSAqZmlsZSwgZW51 bSByZWdjYWNoZV9kdW1wX3doYXQgd2hhdF90b19kdW1wKQ0KICAgaW50IGZv b3Rub3RlX3JlZ2lzdGVyX29mZnNldCA9IDA7DQogICBpbnQgZm9vdG5vdGVf cmVnaXN0ZXJfdHlwZV9uYW1lX251bGwgPSAwOw0KICAgbG9uZyByZWdpc3Rl cl9vZmZzZXQgPSAwOw0KLSAgZ2RiX2J5dGUgYnVmW01BWF9SRUdJU1RFUl9T SVpFXTsNCg0KICNpZiAwDQogICBmcHJpbnRmX3VuZmlsdGVyZWQgKGZpbGUs ICJucl9yYXdfcmVnaXN0ZXJzICVkXG4iLA0KQEAgLTE1NjUsOCArMTU1OSw4 IEBAIHJlZ2NhY2hlOjpkdW1wICh1aV9maWxlICpmaWxlLCBlbnVtIHJlZ2Nh Y2hlX2R1bXBfd2hhdCB3aGF0X3RvX2R1bXApDQogCSAgICBmcHJpbnRmX3Vu ZmlsdGVyZWQgKGZpbGUsICI8dW5hdmFpbGFibGU+Iik7DQogCSAgZWxzZQ0K IAkgICAgew0KLQkgICAgICByYXdfcmVhZCAocmVnbnVtLCBidWYpOw0KLQkg ICAgICBwcmludF9oZXhfY2hhcnMgKGZpbGUsIGJ1ZiwNCisJICAgICAgcmF3 X3VwZGF0ZSAocmVnbnVtKTsNCisJICAgICAgcHJpbnRfaGV4X2NoYXJzIChm aWxlLCByZWdpc3Rlcl9idWZmZXIgKHJlZ251bSksDQogCQkJICAgICAgIG1f ZGVzY3ItPnNpemVvZl9yZWdpc3RlcltyZWdudW1dLA0KIAkJCSAgICAgICBn ZGJhcmNoX2J5dGVfb3JkZXIgKGdkYmFyY2gpKTsNCiAJICAgIH0NCkBAIC0x NTc5LDkgKzE1NzMsMzAgQEAgcmVnY2FjaGU6OmR1bXAgKHVpX2ZpbGUgKmZp bGUsIGVudW0gcmVnY2FjaGVfZHVtcF93aGF0IHdoYXRfdG9fZHVtcCkNCiAJ ICAgIGZwcmludGZfdW5maWx0ZXJlZCAoZmlsZSwgIkNvb2tlZCB2YWx1ZSIp Ow0KIAkgIGVsc2UNCiAJICAgIHsNCisJICAgICAgY29uc3QgZ2RiX2J5dGUg KmJ1ZiA9IE5VTEw7DQogCSAgICAgIGVudW0gcmVnaXN0ZXJfc3RhdHVzIHN0 YXR1czsNCisJICAgICAgc3RydWN0IHZhbHVlICp2YWx1ZSA9IE5VTEw7DQor DQorCSAgICAgIGlmIChyZWdudW0gPCBtX2Rlc2NyLT5ucl9yYXdfcmVnaXN0 ZXJzKQ0KKwkJew0KKwkJICByYXdfdXBkYXRlIChyZWdudW0pOw0KKwkJICBz dGF0dXMgPSBnZXRfcmVnaXN0ZXJfc3RhdHVzIChyZWdudW0pOw0KKwkJICBi dWYgPSByZWdpc3Rlcl9idWZmZXIgKHJlZ251bSk7DQorCQl9DQorCSAgICAg IGVsc2UNCisJCXsNCisJCSAgdmFsdWUgPSBjb29rZWRfcmVhZF92YWx1ZSAo cmVnbnVtKTsNCisNCisJCSAgaWYgKCF2YWx1ZV9vcHRpbWl6ZWRfb3V0ICh2 YWx1ZSkNCisJCSAgICAgICYmIHZhbHVlX2VudGlyZWx5X2F2YWlsYWJsZSAo dmFsdWUpKQ0KKwkJICAgIHsNCisJCSAgICAgIHN0YXR1cyA9IFJFR19WQUxJ RDsNCisJCSAgICAgIGJ1ZiA9IHZhbHVlX2NvbnRlbnRzX2FsbCAodmFsdWUp Ow0KKwkJICAgIH0NCisJCSAgZWxzZQ0KKwkJICAgIHN0YXR1cyA9IFJFR19V TkFWQUlMQUJMRTsNCisJCX0NCg0KLQkgICAgICBzdGF0dXMgPSBjb29rZWRf cmVhZCAocmVnbnVtLCBidWYpOw0KIAkgICAgICBpZiAoc3RhdHVzID09IFJF R19VTktOT1dOKQ0KIAkJZnByaW50Zl91bmZpbHRlcmVkIChmaWxlLCAiPGlu dmFsaWQ+Iik7DQogCSAgICAgIGVsc2UgaWYgKHN0YXR1cyA9PSBSRUdfVU5B VkFJTEFCTEUpDQpAQCAtMTU5MCw2ICsxNjA1LDEyIEBAIHJlZ2NhY2hlOjpk dW1wICh1aV9maWxlICpmaWxlLCBlbnVtIHJlZ2NhY2hlX2R1bXBfd2hhdCB3 aGF0X3RvX2R1bXApDQogCQlwcmludF9oZXhfY2hhcnMgKGZpbGUsIGJ1ZiwN CiAJCQkJIG1fZGVzY3ItPnNpemVvZl9yZWdpc3RlcltyZWdudW1dLA0KIAkJ CQkgZ2RiYXJjaF9ieXRlX29yZGVyIChnZGJhcmNoKSk7DQorDQorCSAgICAg IGlmICh2YWx1ZSAhPSBOVUxMKQ0KKwkJew0KKwkJICByZWxlYXNlX3ZhbHVl ICh2YWx1ZSk7DQorCQkgIHZhbHVlX2ZyZWUgKHZhbHVlKTsNCisJCX0NCiAJ ICAgIH0NCiAJfQ0KDQoNCg== >From gdb-patches-return-138785-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed May 03 10:56:40 2017 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 64888 invoked by alias); 3 May 2017 10:56:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 64044 invoked by uid 89); 3 May 2017 10:56:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LOTSOFHASH,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=regi, defer X-HELO: EUR03-AM5-obe.outbound.protection.outlook.com Received: from mail-eopbgr30075.outbound.protection.outlook.com (HELO EUR03-AM5-obe.outbound.protection.outlook.com) (40.107.3.75) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 03 May 2017 10:56:36 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) by AM3PR08MB0103.eurprd08.prod.outlook.com (10.160.211.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1061.12; Wed, 3 May 2017 10:56:36 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::b823:64c1:afc5:3a08]) by AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::b823:64c1:afc5:3a08%17]) with mapi id 15.01.1061.021; Wed, 3 May 2017 10:56:35 +0000 From: Alan Hayward To: Pedro Alves CC: Yao Qi , "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH 8/11] Add FRV_MAX_REGISTER_SIZE Date: Wed, 03 May 2017 10:56:00 -0000 Message-ID: References: <3B3BD949-1C9D-44FF-AB6A-03091ECA49D0@arm.com> <867f2rw9br.fsf@gmail.com> <22BD364F-A9A9-4E21-BC47-96A320760640@arm.com> <86d1bqba87.fsf@gmail.com> In-Reply-To: authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=arm.com; x-microsoft-exchange-diagnostics: 1;AM3PR08MB0103;7:9tTxgNOVrbfaLWmPK0xJf6ZXbA2+NQ96rqFBjTo6ZCAgKndUavI0lLLo+wLZETYJj57a5YYpSnZBeUWL7mfzO9rITjossQN2plv4DZe2P7Bt7jiopwnqDu05YIe6yeR4pViCiWetG90yo0WKOY2qeRX9qknihAHFggmUz4/7qznk5GZ8eWJPVk5XIlNjJGRs7yikMuXK9s0NtR2QVeBd+spTgu0XePHHQAIByD2MDjnZAKv1Vfze7fkNWeI0oWpEtuIRXYJxrfXfu0HrjWlstWgZ1ltK3DOP6H+cGnOMtYgMJONBAzEI7Vbm7WavypEYYgXsiM1lLvm1q3PNon9zEQ== x-ms-office365-filtering-correlation-id: 83bae950-a8d6-4469-a9e6-08d492131160 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081)(201702281549075);SRVR:AM3PR08MB0103; nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041248)(20161123560025)(20161123555025)(20161123564025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(6072148);SRVR:AM3PR08MB0103;BCL:0;PCL:0;RULEID:;SRVR:AM3PR08MB0103; x-forefront-prvs: 029651C7A1 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39840400002)(39450400003)(39860400002)(39850400002)(39410400002)(39400400002)(377424004)(377454003)(24454002)(50986999)(229853002)(66066001)(6486002)(33656002)(76176999)(6506006)(6436002)(86362001)(54356999)(8936002)(2906002)(3660700001)(81166006)(8676002)(93886004)(3280700002)(39060400002)(6246003)(7736002)(189998001)(25786009)(53546009)(478600001)(36756003)(3846002)(6116002)(305945005)(53936002)(102836003)(83716003)(99286003)(54906002)(2950100002)(6512007)(6916009)(38730400002)(5660300001)(5250100002)(2900100001)(4326008)(110136004)(82746002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR08MB0103;H:AM3PR08MB0101.eurprd08.prod.outlook.com;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2017 10:56:35.6695 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0103 X-SW-Source: 2017-05/txt/msg00045.txt.bz2 Content-length: 3749 > On 3 May 2017, at 10:27, Pedro Alves wrote: >=20 > On 05/03/2017 09:44 AM, Yao Qi wrote: >> Alan Hayward writes: >>=20 >> Hi Alan, >> regcache.c is updated, so please update your patch. >>=20 >>> I considered making regcache_raw_supply_zero call regcache_raw_supply, = but >>> in the end it made more sense to make it completely separate. >>=20 >> You can call raw_supply (regnum, NULL) and then set the status to REG_VA= LID. >>=20 >=20 > I think I agree with Alan -- if we defer to raw_supply, then I'd still pr= efer > that the memset is still done in regcache_raw_supply_zero, because whether > unavailable registers actually have a contents buffer at all is > implementation detail. We currently zero REG_UNVAILABLE registers in raw= _supply, > but that could change. (And if we reuse raw_supply as is, then memset, w= e'll > memset twice.) >=20 > BTW, note that gdbserver has an equivalent function, called > "supply_register_zeroed". >=20 Agreed. I didn't want somebody in the future to change raw_supply and cause raw_supply_zero to break. Patch updated to head and raw_supply_zero moved into regcache class. Tested on a --enable-targets=3Dall using make check with board files unix and native-gdbserver. Ok to commit? Alan. 2017-05-03 Alan Hayward * frv-linux-tdep.c (frv_linux_supply_gregset): Use raw_supply_zero. * regcache.c (regcache::raw_supply_zero): New function. * regcache.h (regcache::raw_supply_zero: New declaration. diff --git a/gdb/frv-linux-tdep.c b/gdb/frv-linux-tdep.c index eb87f93058b0287e8f05c585d1b6aa1ff2bffb78..30e5bf00c199a0193ea6cac3a14= 070445492d3fe 100644 --- a/gdb/frv-linux-tdep.c +++ b/gdb/frv-linux-tdep.c @@ -413,17 +413,14 @@ frv_linux_supply_gregset (const struct regset *regset, int regnum, const void *gregs, size_t len) { int regi; - char zerobuf[MAX_REGISTER_SIZE]; - - memset (zerobuf, 0, MAX_REGISTER_SIZE); /* gr0 always contains 0. Also, the kernel passes the TBR value in this slot. */ - regcache_raw_supply (regcache, first_gpr_regnum, zerobuf); + regcache->raw_supply_zero (first_gpr_regnum); /* Fill gr32, ..., gr63 with zeros. */ for (regi =3D first_gpr_regnum + 32; regi <=3D last_gpr_regnum; regi++) - regcache_raw_supply (regcache, regi, zerobuf); + regcache->raw_supply_zero (regi); regcache_supply_regset (regset, regcache, regnum, gregs, len); } diff --git a/gdb/regcache.h b/gdb/regcache.h index 346d290b752d8809f78b72c104ccbc2f5574d83c..ee949597d5691b692b1162a92bc= 328266fdc160a 100644 --- a/gdb/regcache.h +++ b/gdb/regcache.h @@ -296,6 +296,8 @@ public: void raw_supply (int regnum, const void *buf); + void raw_supply_zero (int regnum); + void raw_copy (int regnum, struct regcache *src_regcache); enum register_status get_register_status (int regnum) const; diff --git a/gdb/regcache.c b/gdb/regcache.c index 748c30e2d4c5f572e9741f73a39c4bc555d1d663..89c2eb55e29af9a806a684382dc= 928c307ff934b 100644 --- a/gdb/regcache.c +++ b/gdb/regcache.c @@ -1208,6 +1208,26 @@ regcache::raw_supply (int regnum, const void *buf) } } +/* Supply register REGNUM with zeroed value to REGCACHE. This is not the = same + as calling raw_supply with NULL (which will set the state to + unavailable). */ + +void +regcache::raw_supply_zero (int regnum) +{ + void *regbuf; + size_t size; + + gdb_assert (regnum >=3D 0 && regnum < m_descr->nr_raw_registers); + gdb_assert (!m_readonly_p); + + regbuf =3D register_buffer (regnum); + size =3D m_descr->sizeof_register[regnum]; + + memset (regbuf, 0, size); + m_register_status[regnum] =3D REG_VALID; +} + /* Collect register REGNUM from REGCACHE and store its contents in BUF. */ void