Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <qiyaoltc@gmail.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 0/9 V3] Use reinsert breakpoint for vCont;s
Date: Thu, 30 Jun 2016 14:09:00 -0000	[thread overview]
Message-ID: <1467295765-3457-1-git-send-email-yao.qi@linaro.org> (raw)

Here is the V3 of this patch series, V2 can be found
https://sourceware.org/ml/gdb-patches/2016-06/msg00029.html
some preparatory patches in V2 are already pushed in.  Patches
1 - 5 and 9 are already approved in V2 review.

This patch series is to address the review comments
https://sourceware.org/ml/gdb-patches/2016-06/msg00305.html

> Hmm, seeing that we need to handle installing the breakpoints in
> both places, I wonder about making linux_resume just handle
> setting up the last resume kind and queue signals, and then
> end up calling proceed_all_lwps.  If that works, I suspect it
> would simplify things a good deal.

I do something slightly differently in V3.  In my
"V2 Use reinsert breakpoint for vCont;s", I install reinsert breakpoints
for needed lwps in two places, linux_resume and proceed_all_lwps, which
isn't ideal.

After the chat with Pedro, we don't need to stop all threads when inserting
reinsert breakpoint, so we can move the breakpoint installation further
down to linux_resume_one_thread and proceed_one_lwp.  If
linux_resume_one_thread can use proceed_one_lwp, we can only install
reinsert breakpoints in one place, proceed_one_lwp.  Patch 7 changes
linux_resume_one_thread enqueues signal and calls proceed_one_lwp.
Patch 6 is a refactor one to use existing api enqueue_pending_signal.
With the changes in patch 7, patch 8 is simplified compared with V2.

Regression tested on arm-linux and x86_64-linux.

*** BLURB HERE ***

Yao Qi (9):
  Pass breakpoint type in set_breakpoint_at
  Create sub classes of 'struct breakpoint'
  Refactor clone_all_breakpoints
  Make reinsert_breakpoint thread specific
  Switch current_thread to lwp's thread in
    install_software_single_step_breakpoints
  Use enqueue_pending_signal in linux_resume_one_thread
  Enqueue signal even when resuming threads
  Use reinsert_breakpoint for vCont;s
  Support vCont s and S actions with software single step

 gdb/gdbserver/ChangeLog   |  73 +++++++++++
 gdb/gdbserver/gdbthread.h |   3 +
 gdb/gdbserver/inferiors.c |  14 ++-
 gdb/gdbserver/inferiors.h |   2 +-
 gdb/gdbserver/linux-low.c | 124 +++++++++---------
 gdb/gdbserver/mem-break.c | 313 +++++++++++++++++++++++++++++++++-------------
 gdb/gdbserver/mem-break.h |  45 +++----
 gdb/gdbserver/server.c    |  17 +--
 8 files changed, 410 insertions(+), 181 deletions(-)

-- 
1.9.1


             reply	other threads:[~2016-06-30 14:09 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-30 14:09 Yao Qi [this message]
2016-06-30 14:09 ` [PATCH 5/9] Switch current_thread to lwp's thread in install_software_single_step_breakpoints Yao Qi
2016-06-30 14:09 ` [PATCH 7/9] Enqueue signal even when resuming threads Yao Qi
2016-07-01 15:06   ` Pedro Alves
2016-07-01 16:45     ` Yao Qi
2016-07-01 16:55       ` Pedro Alves
2016-07-01 17:01         ` Pedro Alves
2016-06-30 14:09 ` [PATCH 9/9] Support vCont s and S actions with software single step Yao Qi
2016-06-30 14:09 ` [PATCH 1/9] Pass breakpoint type in set_breakpoint_at Yao Qi
2016-06-30 14:09 ` [PATCH 3/9] Refactor clone_all_breakpoints Yao Qi
2016-06-30 14:09 ` [PATCH 2/9] Create sub classes of 'struct breakpoint' Yao Qi
2016-06-30 14:09 ` [PATCH 4/9] Make reinsert_breakpoint thread specific Yao Qi
2016-06-30 14:09 ` [PATCH 8/9] Use reinsert_breakpoint for vCont;s Yao Qi
2016-07-01 15:07   ` Pedro Alves
2016-07-05  8:15     ` Yao Qi
2016-07-21  8:38       ` Yao Qi
2016-07-21 10:02       ` Pedro Alves
2016-06-30 14:09 ` [PATCH 6/9] Use enqueue_pending_signal in linux_resume_one_thread Yao Qi
2016-07-21 11:18 ` [PATCH 0/9 V3] Use reinsert breakpoint for vCont;s Yao Qi
2016-11-14 19:14 ` Antoine Tremblay
2016-11-21 12:08   ` Yao Qi
     [not found]     ` <wwok37ikrgmq.fsf@ericsson.com>
2016-11-23 19:03       ` Antoine Tremblay
2016-11-24 21:55       ` Yao Qi
2016-11-25 12:22         ` Antoine Tremblay
2016-11-25 13:13           ` Antoine Tremblay
2016-11-25 13:35             ` Antoine Tremblay
2016-11-25 13:44             ` Pedro Alves
2016-11-25 13:57               ` Antoine Tremblay
2016-11-25 14:28                 ` Antoine Tremblay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467295765-3457-1-git-send-email-yao.qi@linaro.org \
    --to=qiyaoltc@gmail.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox