From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120076 invoked by alias); 6 Jun 2016 21:34:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 119941 invoked by uid 89); 6 Jun 2016 21:34:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00,FSL_HELO_HOME,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:722, H*MI:tom X-HELO: gproxy6-pub.mail.unifiedlayer.com Received: from gproxy6-pub.mail.unifiedlayer.com (HELO gproxy6-pub.mail.unifiedlayer.com) (67.222.39.168) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Mon, 06 Jun 2016 21:33:44 +0000 Received: (qmail 24445 invoked by uid 0); 6 Jun 2016 21:33:43 -0000 Received: from unknown (HELO CMOut01) (10.0.90.82) by gproxy6.mail.unifiedlayer.com with SMTP; 6 Jun 2016 21:33:43 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id 3ZZd1t0182f2jeq01ZZgl6; Mon, 06 Jun 2016 15:33:41 -0600 X-Authority-Analysis: v=2.1 cv=OPe0g0qB c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=PnD2wP_eR3oA:10 a=-N9Dh3nx2ZYA:10 a=pD_ry4oyNxEA:10 a=qZkqC4j99bQv6IbphjQA:9 Received: from [65.128.48.199] (port=46482 helo=bapiya.Home) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_2) (envelope-from ) id 1bA29S-0006Xd-QN for gdb-patches@sourceware.org; Mon, 06 Jun 2016 15:33:39 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Subject: [RFA 0/6] Add -Wunused-but-set-parameter and -Wunused-but-set-variable Date: Mon, 06 Jun 2016 21:34:00 -0000 Message-Id: <1465248812-23902-1-git-send-email-tom@tromey.com> X-Identified-User: {36111:box522.bluehost.com:elynrobi:tromey.com} {sentby:smtp auth 65.128.48.199 authed with tom+tromey.com} X-Exim-ID: 1bA29S-0006Xd-QN X-Source-Sender: (bapiya.Home) [65.128.48.199]:46482 X-Source-Auth: tom+tromey.com X-Email-Count: 0 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-06/txt/msg00121.txt.bz2 I happened to notice an unused variable in the newly minted Rust code, so I decided to take a look at adding some warnings to prevent this. This series adds -Wunused-but-set-parameter and -Wunused-but-set-variable to the build. First come the patches to remove all the warnings, and the final patch enables the compiler flags. I've split up the patches for easier review, and according to the type of patch. I think they're generally self-explanatory. I built and regression tested this using --enable-targets=all on x86-64 Fedora 23. However, I could not update the various nat-* files, so there are probably unfixed warnings lurking there. Tom