From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sonic303-21.consmr.mail.ir2.yahoo.com (sonic303-21.consmr.mail.ir2.yahoo.com [77.238.178.202]) by sourceware.org (Postfix) with ESMTPS id AA853385DC1B for ; Sun, 24 May 2020 00:26:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AA853385DC1B X-YMail-OSG: IDmkmOgVM1mML8AvzBLEmYlEHbLp01Y4SZ6DJ2P8L0oolWkNc4qnb1jma0312uz iIUjkwh__7m_aM4qtnuX7phFNmcgFLHt_jTRrEIKv604BjGIF2o1uqVgajBIeDixmVar7Xu5OzR0 Yhlk0ABKP.cXiXabf1mErrSP7HvgWPvABPOw_yH5iW6KKkMIjwY8jg3TcYSTLxeRw3MhFdB4wGWg g.7nUeTpUjwaSkNOhLMn8LhhDOuBlnzCNmL_19NIVmqTqUtqNAdepzj42K8vvB7b4sp1l_63d5H7 3w08UoqBmfj0v1hmm5lCCzEkY4Df48r4uXyzFukTIxbQMHros5hOVOKcDiw4fE.Q46VJGN5JVeJP Z_bdyYURjVHd3QRVfwKO6H4EQxNVVL6gt5H_KtUD9ctqecvHojEfzdLslStfA5t6BqosDJi5aRkm CmjS_NSuZDUGXqNJMIJ_5bmhEy1gHqTGCWzbLCWxtGUZC72gUBbhVTHf20gzEZsV7kIV5Egc5wTO ItNC7r_Er0hqRhTI6oQwVKQk7NlPuBma5t4Nf2OCSj_5G9_8EIdLlkNiHGVSePldqYKVnH_0uhob Me_WyttOQRl2xLtpvBv1w6OyRsdpJbDz60j4sGiBNPVMfcTBPfw_0HEsK5oSWez8How4xfu0OFJL xbO8ePKceai.JZNTZUwSnNxK_ZeZ63v.R_CxLbLRB7SoyMkuhKhddfsM4i1lZrhPf0mriFzLF08m CSYuurVBI5RCNWEAnn2d0pla6Sg3chv6Tk7CXS82sa1joVOdeKVovUq5ln1e7pcDct43KAidDdm_ krl_z7E1OCMCJlshxyPAhbh0JTdewwyhDr5i1lYk0QJRdsWHoOAYAxu81epcu3yy1ToyVb2tKLHs K44Gv9bfT2DcUPSGRwwpwPfGL3aAQ.Q6JFSDFRykyUC3bzgOdN7Tc4eLTIUnq5x2Y_F3TLgtgmUC _FRLP39ZmMMQoyngkwde7SoWMBpeCPHvRW2O_ed4n06PYqnDNm0Qd1B16TzIhRRKM1aSrduGkoQE sEWs872ry7XdNkHJmYWtFq9_RrTpXxTs9hIFYQlvUjXAudTEURZaPbHtLCuHH8dRGxds3VWJrJvJ wgHGzfeywkp3IKL9Tf9r3u6I.BDpZC_12JIo1P65uTUGCyTPlEVN8.dj4ysaNI.a5YyHpeQngDEL 0HElCJYhQBugXTAPbIZAcz8bLhA.rUKel6yDsiuregYAItwVC05Wz_w4R1_Rfgxhx8vvyrHW68Zq rLv9K6Zair8wbRftMjwDaCpmYt7bo7Q9uh_KhAJ7MuuiZlzqE0Gm9Pxp.gHDPJ0.nzTTbGxeHr5F ufpZzjw-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic303.consmr.mail.ir2.yahoo.com with HTTP; Sun, 24 May 2020 00:26:05 +0000 Date: Sun, 24 May 2020 00:26:05 +0000 (UTC) From: Hannes Domani To: Gdb-patches Message-ID: <1463910115.4239771.1590279965224@mail.yahoo.com> In-Reply-To: <87a71ytlue.fsf@tromey.com> References: <20200409024112.18065-1-tom@tromey.com> <83369dp3gy.fsf@gnu.org> <87eesc1x2d.fsf@tromey.com> <87y2pr663s.fsf@tromey.com> <87a71ytlue.fsf@tromey.com> Subject: Re: [PATCH] Add completion styling MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.15960 YMailNorrin Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:76.0) Gecko/20100101 Firefox/76.0 X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 May 2020 00:26:08 -0000 Am Samstag, 23. Mai 2020, 22:53:10 MESZ hat Tom Tromey Fo= lgendes geschrieben: > >>>>> "Tom" =3D=3D Tom Tromey writes: > > Tom> I think the Emacs idea is nice.=C2=A0 Maybe we want to let the user = control > Tom> the prefix text, the "difference character", and the final completio= n > Tom> text. > > > Here's a new version of the patch that implements this idea. > > I'm checking this in. I just tried it out on Windows. It works fine in TUI, but in the CLI it just prints the escape sequences: (gdb) b ?[2mb?[m?[35ma?[mcktrace=C2=A0=C2=A0=C2=A0 ?[2mb?[m?[35mo?[mokmark=C2=A0=C2= =A0=C2=A0=C2=A0 ?[2mb?[m?[35mr?[meak =C2=A0=C2=A0=C2=A0 ?[2mb?[m?[35mr?[meak-range=C2=A0 ?[2mb?[m?[35mt?[m Once I added the same gdb_console_fputs call for cli_mld_puts as stdio_file::puts has, the problem was gone: diff --git a/gdb/cli-out.c b/gdb/cli-out.c index e47272ad87..1ddc80811b 100644 --- a/gdb/cli-out.c +++ b/gdb/cli-out.c @@ -339,6 +339,8 @@ cli_mld_putch (const struct match_list_displayer *displ= ayer, int ch) =C2=A0static void =C2=A0cli_mld_puts (const struct match_list_displayer *displayer, const cha= r *s) =C2=A0{ +=C2=A0 if (gdb_console_fputs (s, rl_outstream)) +=C2=A0=C2=A0=C2=A0 return; =C2=A0=C2=A0 fputs (s, rl_outstream); =C2=A0} Hannes