From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79299 invoked by alias); 20 May 2016 20:45:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 79284 invoked by uid 89); 20 May 2016 20:45:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00,FSL_HELO_HOME,RCVD_IN_DNSWL_NONE,SPF_PASS,T_FILL_THIS_FORM_SHORT autolearn=no version=3.3.2 spammy=Break, H*m:tromey, Events, H*MI:tom X-HELO: gproxy10-pub.mail.unifiedlayer.com Received: from gproxy10-pub.mail.unifiedlayer.com (HELO gproxy10-pub.mail.unifiedlayer.com) (69.89.20.226) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Fri, 20 May 2016 20:45:44 +0000 Received: (qmail 28477 invoked by uid 0); 20 May 2016 20:45:42 -0000 Received: from unknown (HELO cmgw3) (10.0.90.84) by gproxy10.mail.unifiedlayer.com with SMTP; 20 May 2016 20:45:42 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id wklf1s00F2f2jeq01kli8T; Fri, 20 May 2016 14:45:42 -0600 X-Authority-Analysis: v=2.1 cv=cYhB8BzM c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=PnD2wP_eR3oA:10 a=_v2sUkyEFrwA:10 a=yrkiwgmsf1kA:10 a=zstS-IiYAAAA:8 a=0FD05c-RAAAA:8 a=cMbcF45mqyVXRbZSNcwA:9 a=EXYKtmhMKlc54h9c:21 a=4zaU6jpMAvGZAYaB:21 a=4G6NA9xxw8l3yy4pmD5M:22 a=l1rpMCqCXRGZwUSuRcM3:22 Received: from [71.215.116.141] (port=52558 helo=bapiya.Home) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_2) (envelope-from ) id 1b3rIg-0002eJ-VN; Fri, 20 May 2016 14:45:39 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [RFA] PR python/15620, PR python/18620 - breakpoint events in Python Date: Fri, 20 May 2016 20:45:00 -0000 Message-Id: <1463777131-7289-1-git-send-email-tom@tromey.com> X-Identified-User: {36111:box522.bluehost.com:elynrobi:tromey.com} {sentby:smtp auth 71.215.116.141 authed with tom+tromey.com} X-SW-Source: 2016-05/txt/msg00368.txt.bz2 This patch adds some breakpoint events to Python. In particular, there is a creation event that is emitted when a breakpoint is created; a modification event that is emitted when a breakpoint changes somehow; and a deletion event that is emitted when a breakpoint is deleted. In this patch, the event's payload is the breakpoint itself. I considered making a new event type to hold the breakpoint, but I didn't see a need. Still, I thought I would mention this as a spot where some other choice is possible. Built and regtested on x86-64 Fedora 23. 2016-05-19 Tom Tromey PR python/15620, PR python/18620: * python/py-evts.c (gdbpy_initialize_py_events): Call add_new_registry for new events. * python/py-events.h (events_object) : New fields. * python/py-breakpoint.c (gdbpy_breakpoint_created): Emit the breakpoint changed event. (gdbpy_breakpoint_deleted): Emit the breakpoint deleted event. (gdbpy_breakpoint_modified): New function. (gdbpy_initialize_breakpoints): Attach to the breakpoint modified observer. 2016-05-20 Tom Tromey PR python/15620, PR python/18620: * python.texi (Events In Python): Document new breakpoint events. 2016-05-20 Tom Tromey PR python/15620, PR python/18620: * gdb.python/py-breakpoint.exp (connect_event, check_last_event) (test_bkpt_events): New procs. --- gdb/ChangeLog | 14 +++++++++ gdb/doc/ChangeLog | 5 ++++ gdb/doc/python.texi | 15 ++++++++++ gdb/python/py-breakpoint.c | 48 ++++++++++++++++++++++++++++++ gdb/python/py-events.h | 3 ++ gdb/python/py-evts.c | 11 +++++++ gdb/testsuite/ChangeLog | 6 ++++ gdb/testsuite/gdb.python/py-breakpoint.exp | 41 +++++++++++++++++++++++++ 8 files changed, 143 insertions(+) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 0968b85..1e0afe6 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,17 @@ +2016-05-19 Tom Tromey + + PR python/15620, PR python/18620: + * python/py-evts.c (gdbpy_initialize_py_events): Call + add_new_registry for new events. + * python/py-events.h (events_object) : New fields. + * python/py-breakpoint.c (gdbpy_breakpoint_created): Emit the + breakpoint changed event. + (gdbpy_breakpoint_deleted): Emit the breakpoint deleted event. + (gdbpy_breakpoint_modified): New function. + (gdbpy_initialize_breakpoints): Attach to the breakpoint modified + observer. + 2016-05-19 Andreas Schwab * ia64-libunwind-tdep.c (libunwind_descr): Add cast from void *. diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog index fe2e3be..0d564bf 100644 --- a/gdb/doc/ChangeLog +++ b/gdb/doc/ChangeLog @@ -1,3 +1,8 @@ +2016-05-20 Tom Tromey + + PR python/15620, PR python/18620: + * python.texi (Events In Python): Document new breakpoint events. + 2016-05-17 Tom Tromey * gdb.texinfo (Supported Languages): Mention Rust. Update menu. diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi index ffbf89a..5e3a42c 100644 --- a/gdb/doc/python.texi +++ b/gdb/doc/python.texi @@ -2962,6 +2962,21 @@ A gdb.Frame object representing the frame in which the register was modified. Denotes which register was modified. @end defvar +@item events.breakpoint_created +This is emitted when a new breakpoint has been created. The argument +that is passed is the new @code{gdb.Breakpoint} object. + +@item events.breakpoint_modified +This is emitted when a breakpoint has been modified in some way. The +argument that is passed is the new @code{gdb.Breakpoint} object. + +@item events.breakpoint_deleted +This is emitted when a breakpoint is has been deleted. The argument +that is passed is the @code{gdb.Breakpoint} object. When this event +is emitted, the @code{gdb.Breakpoint} object will already be in its +invalid state; that is, the @code{is_valid} method will return +@code{False}. + @end table @node Threads In Python diff --git a/gdb/python/py-breakpoint.c b/gdb/python/py-breakpoint.c index 611a41e..0dce909 100644 --- a/gdb/python/py-breakpoint.c +++ b/gdb/python/py-breakpoint.c @@ -31,6 +31,7 @@ #include "arch-utils.h" #include "language.h" #include "location.h" +#include "py-event.h" /* Number of live breakpoints. */ static int bppy_live; @@ -897,6 +898,14 @@ gdbpy_breakpoint_created (struct breakpoint *bp) gdbpy_print_stack (); } + if (!evregpy_no_listeners_p (gdb_py_events.breakpoint_created)) + { + Py_INCREF (newbp); + if (evpy_emit_event ((PyObject *) newbp, + gdb_py_events.breakpoint_created) < 0) + gdbpy_print_stack (); + } + PyGILState_Release (state); } @@ -917,6 +926,15 @@ gdbpy_breakpoint_deleted (struct breakpoint *b) bp_obj = bp->py_bp_object; if (bp_obj) { + if (!evregpy_no_listeners_p (gdb_py_events.breakpoint_deleted)) + { + PyObject *bp_obj_alias = (PyObject *) bp_obj; + Py_INCREF (bp_obj_alias); + if (evpy_emit_event (bp_obj_alias, + gdb_py_events.breakpoint_deleted) < 0) + gdbpy_print_stack (); + } + bp_obj->bp = NULL; --bppy_live; Py_DECREF (bp_obj); @@ -925,6 +943,35 @@ gdbpy_breakpoint_deleted (struct breakpoint *b) PyGILState_Release (state); } +/* Callback that is used when a breakpoint is modified. */ + +static void +gdbpy_breakpoint_modified (struct breakpoint *b) +{ + int num = b->number; + PyGILState_STATE state; + struct breakpoint *bp = NULL; + gdbpy_breakpoint_object *bp_obj; + + state = PyGILState_Ensure (); + bp = get_breakpoint (num); + if (bp) + { + PyObject *bp_obj = (PyObject *) bp->py_bp_object; + if (bp_obj) + { + if (!evregpy_no_listeners_p (gdb_py_events.breakpoint_modified)) + { + Py_INCREF (bp_obj); + if (evpy_emit_event (bp_obj, + gdb_py_events.breakpoint_modified) < 0) + gdbpy_print_stack (); + } + } + } + PyGILState_Release (state); +} + /* Initialize the Python breakpoint code. */ @@ -943,6 +990,7 @@ gdbpy_initialize_breakpoints (void) observer_attach_breakpoint_created (gdbpy_breakpoint_created); observer_attach_breakpoint_deleted (gdbpy_breakpoint_deleted); + observer_attach_breakpoint_modified (gdbpy_breakpoint_modified); /* Add breakpoint types constants. */ for (i = 0; pybp_codes[i].name; ++i) diff --git a/gdb/python/py-events.h b/gdb/python/py-events.h index 9ecee4c..1d74558 100644 --- a/gdb/python/py-events.h +++ b/gdb/python/py-events.h @@ -50,6 +50,9 @@ typedef struct eventregistry_object *inferior_call; eventregistry_object *memory_changed; eventregistry_object *register_changed; + eventregistry_object *breakpoint_created; + eventregistry_object *breakpoint_deleted; + eventregistry_object *breakpoint_modified; PyObject *module; diff --git a/gdb/python/py-evts.c b/gdb/python/py-evts.c index 95827e4..961c247 100644 --- a/gdb/python/py-evts.c +++ b/gdb/python/py-evts.c @@ -89,6 +89,17 @@ gdbpy_initialize_py_events (void) if (add_new_registry (&gdb_py_events.clear_objfiles, "clear_objfiles") < 0) return -1; + if (add_new_registry (&gdb_py_events.breakpoint_created, + "breakpoint_created") < 0) + return -1; + + if (add_new_registry (&gdb_py_events.breakpoint_deleted, + "breakpoint_deleted") < 0) + return -1; + if (add_new_registry (&gdb_py_events.breakpoint_modified, + "breakpoint_modified") < 0) + return -1; + if (gdb_pymodule_addobject (gdb_module, "events", (PyObject *) gdb_py_events.module) < 0) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index a773c63..b518e64 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2016-05-20 Tom Tromey + + PR python/15620, PR python/18620: + * gdb.python/py-breakpoint.exp (connect_event, check_last_event) + (test_bkpt_events): New procs. + 2016-05-18 Simon Marchi * gdb.mi/mi-threads-interrupt.c: New file. diff --git a/gdb/testsuite/gdb.python/py-breakpoint.exp b/gdb/testsuite/gdb.python/py-breakpoint.exp index d1d1b22..e926c76 100644 --- a/gdb/testsuite/gdb.python/py-breakpoint.exp +++ b/gdb/testsuite/gdb.python/py-breakpoint.exp @@ -494,6 +494,46 @@ proc test_bkpt_address {} { ".*Breakpoint ($decimal)+ at .*$srcfile, line ($decimal)+\." } +# Helper proc to install an event listener for a given breakpoint +# event. NAME is the name of the event to listen for. +proc connect_event {name} { + set lambda "lambda x: note_event(\"$name\")" + gdb_test_no_output "python gdb.events.$name.connect($lambda)" \ + "install $name event listener" +} + +# Helper proc to check that the most recently emitted breakpoint event +# is EXPECTED. +proc check_last_event {expected} { + gdb_test "python print (last_bp_event)" $expected \ + "check for $expected event" +} + +proc test_bkpt_events {} { + global testfile + + clean_restart ${testfile} + + gdb_py_test_multiple "Create event handler" \ + "python" "" \ + "def note_event(arg):" "" \ + " global last_bp_event" "" \ + " last_bp_event = arg" "" \ + "end" "" + gdb_test_no_output "python last_bp_event = None" + + connect_event breakpoint_created + connect_event breakpoint_modified + connect_event breakpoint_deleted + + gdb_breakpoint [gdb_get_line_number "Break at add."] + check_last_event breakpoint_created + gdb_test_no_output "disable 1" + check_last_event breakpoint_modified + gdb_test_no_output "delete 1" + check_last_event breakpoint_deleted +} + test_bkpt_basic test_bkpt_deletion test_bkpt_cond_and_cmds @@ -503,3 +543,4 @@ test_bkpt_internal test_bkpt_eval_funcs test_bkpt_temporary test_bkpt_address +test_bkpt_events -- 2.5.5