Re: [PATCH 4/8] Create sub classes of 'struct breakpoint'

Pedro Alves
2016-05-24T16:23:30Z

On 05/20/2016 04:12 PM, Yao Qi wrote:
> Nowadays, there are three types of breakpoint in GDBserver,
>
> - gdb breakpoints,
> - reinsert breakpoints, used for software single step,
> - other breakpoints, used for tracepoint,

We should probably rename the latter two, so we didn't
have to explain what they are. (Doesn't have to be
in this patch, but it's true this patch exposes the naming
to even more places...)

Anyway, LGTM.

The clone_one_breakpoint changes are calling for src->vtable->clone(); :-)

Thanks,
Pedro Alves