Re: [PATCH 7/8] Use reinsert_breakpoint for vCont;s

Pedro Alves
2016-05-26T17:00:19Z

On 05/26/2016 05:52 PM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
>
>>> + /* Remove reinsert breakpoints for resume_step. */
>>> + if (can_software_single_step ()
>>> + && current_thread->last_resume_kind == resume_step
>>
>> What if a vCont;t came in after the step had started and
>> before it finished? Won't we have lost the resume_step
>> linux_set_resume_request then?
>
> Do you mean a case like this? GDB sends vCont;s, and then GDBserver
> started step-over, in the middle of step-over, GDB sends vCont;t, so
> thread->last_resume_kind is set from resume_step to resume_stop, and the
> check here fails, so reinsert breakpoints are not deleted.

Exactly.

Thanks,
Pedro Alves