Re: [PATCH 3/8] Pass breakpoint type in set_breakpoint_at

Pedro Alves
2016-05-24T16:10:27Z

On 05/20/2016 04:12 PM, Yao Qi wrote:

>
> -/* See mem-break.h */
> +/* Set breakpoint of TYPE on address WHERE with handler HANDLER. */
>
> -struct breakpoint *
> -set_breakpoint_at (CORE_ADDR where, int (*handler) (CORE_ADDR))
> +static struct breakpoint *
> +set_breakpoint_at_1 (enum bkpt_type type, CORE_ADDR where,
> + int (*handler) (CORE_ADDR))

Maybe avoid the bland "_1", like:

set_breakpoint_type_at (enum bkpt_type type, CORE_ADDR where,
int (*handler) (CORE_ADDR))

But LGTM.

Thanks,
Pedro Alves