Re: [RFA 2/3] use user_breakpoint_p in python code

Phil Muldoon
2016-05-20T14:30:47Z

On 19/05/16 23:06, Tom Tromey wrote:
> I noticed that bppy_get_visibility and gdbpy_breakpoint_created
> implemented their own visibility checks, but subtly different from
> user_breakpoint_p. I think the latter is more correct, and so changed
> the Python code to use it.
>
> I suspect there isn't a decent way to test this, so no new test.
>
> Built and regtested on x86-64 Fedora 23.
>
> 2016-05-19 Tom Tromey <tom@tromey.com>
>
> * python/py-breakpoint.c (bppy_get_visibility)
> (gdbpy_breakpoint_created): Use user_breakpoint_p.
> ---
> gdb/ChangeLog | 5 +++++
> gdb/python/py-breakpoint.c | 8 ++++----
> 2 files changed, 9 insertions(+), 4 deletions(-)

Looks good to me!

Cheers

Phil