From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59774 invoked by alias); 18 May 2016 23:37:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 59759 invoked by uid 89); 18 May 2016 23:37:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00,FSL_HELO_HOME,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy=H*m:tromey, Hx-languages-length:2492, H*MI:tom X-HELO: gproxy9-pub.mail.unifiedlayer.com Received: from gproxy9-pub.mail.unifiedlayer.com (HELO gproxy9-pub.mail.unifiedlayer.com) (69.89.20.122) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Wed, 18 May 2016 23:36:51 +0000 Received: (qmail 19824 invoked by uid 0); 18 May 2016 23:36:48 -0000 Received: from unknown (HELO cmgw3) (10.0.90.84) by gproxy9.mail.unifiedlayer.com with SMTP; 18 May 2016 23:36:48 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id vzca1s00Y2f2jeq01zcdQR; Wed, 18 May 2016 17:36:48 -0600 X-Authority-Analysis: v=2.1 cv=cYhB8BzM c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=PnD2wP_eR3oA:10 a=_v2sUkyEFrwA:10 a=yrkiwgmsf1kA:10 a=zstS-IiYAAAA:8 a=0FD05c-RAAAA:8 a=u0sIGkPUdDNw9CbqB6sA:9 a=hy_5uYMI8Jvd2YWB:21 a=7rEl-_ZAu69tdwAh:21 a=4G6NA9xxw8l3yy4pmD5M:22 a=l1rpMCqCXRGZwUSuRcM3:22 Received: from [71.215.116.141] (port=36178 helo=bapiya.Home) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_2) (envelope-from ) id 1b3B10-0003oL-GO; Wed, 18 May 2016 17:36:34 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [RFA] Fix PR python/18984 Date: Wed, 18 May 2016 23:37:00 -0000 Message-Id: <1463614581-18216-1-git-send-email-tom@tromey.com> X-Identified-User: {36111:box522.bluehost.com:elynrobi:tromey.com} {sentby:smtp auth 71.215.116.141 authed with tom+tromey.com} X-SW-Source: 2016-05/txt/msg00315.txt.bz2 This fixes PR python/18984. The bug is that gdbpy_solib_name uses GDB_PY_LL_ARG, whereas it should use GDB_PY_LLU_ARG to avoid overflow. Built and tested on x86-64 Fedora 23. 2016-05-18 Tom Tromey PR python/18984: * python/python.c (gdbpy_solib_name): Use GDB_PY_LLU_ARG. 2016-05-18 Tom Tromey PR python/18984: * gdb.python/py-shared.exp: Add solib_name test. --- gdb/ChangeLog | 5 +++++ gdb/python/python.c | 4 ++-- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.python/py-shared.exp | 4 ++++ 4 files changed, 16 insertions(+), 2 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 92024b6..57d9962 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,10 @@ 2016-05-18 Tom Tromey + PR python/18984: + * python/python.c (gdbpy_solib_name): Use GDB_PY_LLU_ARG. + +2016-05-18 Tom Tromey + * rust-lang.c (rust_subscript): Initialize "high". 2016-05-17 Simon Marchi diff --git a/gdb/python/python.c b/gdb/python/python.c index c706644..1f1fece 100644 --- a/gdb/python/python.c +++ b/gdb/python/python.c @@ -696,9 +696,9 @@ gdbpy_solib_name (PyObject *self, PyObject *args) { char *soname; PyObject *str_obj; - gdb_py_longest pc; + gdb_py_ulongest pc; - if (!PyArg_ParseTuple (args, GDB_PY_LL_ARG, &pc)) + if (!PyArg_ParseTuple (args, GDB_PY_LLU_ARG, &pc)) return NULL; soname = solib_name_from_address (current_program_space, pc); diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index a773c63..ac37598 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2016-05-18 Tom Tromey + + PR python/18984: + * gdb.python/py-shared.exp: Add solib_name test. + 2016-05-18 Simon Marchi * gdb.mi/mi-threads-interrupt.c: New file. diff --git a/gdb/testsuite/gdb.python/py-shared.exp b/gdb/testsuite/gdb.python/py-shared.exp index 8673e54..4192354 100644 --- a/gdb/testsuite/gdb.python/py-shared.exp +++ b/gdb/testsuite/gdb.python/py-shared.exp @@ -66,3 +66,7 @@ gdb_test "python print (gdb.solib_name(long(func1)))" "py-shared-sl.sl" "test fu gdb_test "p &main" "" "main address" gdb_py_test_silent_cmd "python main = gdb.history(0)" "Aquire main address" 1 gdb_test "python print (gdb.solib_name(long(main)))" "None" "test main solib location" + +if {[is_lp64_target]} { + gdb_test "python print len(\[gdb.solib_name(0xffffffffffffffff)\])" "1" +} -- 2.5.5