From: Jim Chen <nchen@mozilla.com>
To: gdb-patches@sourceware.org
Cc: Jim Chen <nchen@mozilla.com>
Subject: [PATCH] Specify python2 or python3 as Python program name
Date: Wed, 11 May 2016 21:54:00 -0000 [thread overview]
Message-ID: <1463003507-13094-1-git-send-email-nchen@mozilla.com> (raw)
Hi,
When initializing Python, GDB hard codes the Python program name to
$prefix/bin/python, where $prefix is /usr for example. On some
platforms, /usr/bin/python points to python3. So what happens is, even
if GDB is built with python2 support, GDB ends up setting the Python
program name to point to python3, causing a mismatch. I think it's
better to deliberately specify python2 or python3.
Patch tested on x86_64-linux.
gdb:
2016-05-05 Jim Chen <nchen@mozilla.com>
* python/python.c (_initialize_python): Specify python2 or python3
when initializing the Python program name.
---
gdb/python/python.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/gdb/python/python.c b/gdb/python/python.c
index c706644..4e80951 100644
--- a/gdb/python/python.c
+++ b/gdb/python/python.c
@@ -1701,17 +1701,23 @@ message == an error message without a stack will be printed."),
#ifdef WITH_PYTHON_PATH
/* Work around problem where python gets confused about where it is,
and then can't find its libraries, etc.
NOTE: Python assumes the following layout:
/foo/bin/python
/foo/lib/pythonX.Y/...
This must be done before calling Py_Initialize. */
progname = concat (ldirname (python_libdir), SLASH_STRING, "bin",
- SLASH_STRING, "python", (char *) NULL);
+ SLASH_STRING,
+#ifdef IS_PY3K
+ "python3",
+#else
+ "python2",
+#endif
+ (char *) NULL);
#ifdef IS_PY3K
oldloc = xstrdup (setlocale (LC_ALL, NULL));
setlocale (LC_ALL, "");
progsize = strlen (progname);
progname_copy = (wchar_t *) PyMem_Malloc ((progsize + 1) * sizeof (wchar_t));
if (!progname_copy)
{
xfree (oldloc);
--
2.7.3
next reply other threads:[~2016-05-11 21:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 21:54 Jim Chen [this message]
2016-05-11 21:54 ` [PATCH] [GDBServer] Send SIGINT using process group ID Jim Chen
2016-05-18 12:10 ` Pedro Alves
2016-05-19 16:01 ` Jim Chen
2016-05-12 5:54 ` [PATCH] Specify python2 or python3 as Python program name Eli Zaretskii
2016-05-12 12:50 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463003507-13094-1-git-send-email-nchen@mozilla.com \
--to=nchen@mozilla.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox