From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47602 invoked by alias); 10 May 2016 14:18:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 47535 invoked by uid 89); 10 May 2016 14:18:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=nullify X-HELO: mga02.intel.com Received: from mga02.intel.com (HELO mga02.intel.com) (134.134.136.20) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 May 2016 14:18:05 +0000 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 10 May 2016 07:17:50 -0700 X-ExtLoop1: 1 Received: from irvmail001.ir.intel.com ([163.33.26.43]) by orsmga001.jf.intel.com with ESMTP; 10 May 2016 07:16:21 -0700 Received: from ulvlx001.iul.intel.com (ulvlx001.iul.intel.com [172.28.207.17]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id u4AEGJdA001817; Tue, 10 May 2016 15:16:19 +0100 Received: from ulvlx001.iul.intel.com (localhost [127.0.0.1]) by ulvlx001.iul.intel.com with ESMTP id u4AEGIAe030663; Tue, 10 May 2016 16:16:18 +0200 Received: (from heckel@localhost) by ulvlx001.iul.intel.com with œ id u4AEGIr6030659; Tue, 10 May 2016 16:16:18 +0200 From: Bernhard Heckel To: qiyaoltc@gmail.com Cc: gdb-patches@sourceware.org, Bernhard Heckel Subject: [PATCH 4/4] Fortran, typeprint: Forward level of details to be printed for pointers. Date: Tue, 10 May 2016 14:18:00 -0000 Message-Id: <1462889739-30359-5-git-send-email-bernhard.heckel@intel.com> In-Reply-To: <1462889739-30359-1-git-send-email-bernhard.heckel@intel.com> References: <1462889739-30359-1-git-send-email-bernhard.heckel@intel.com> X-IsSubscribed: yes X-SW-Source: 2016-05/txt/msg00171.txt.bz2 Variable "show" was hardcoded to zero for pointer and reference types. This implementation didn't allow a correct "whatis" print for those types and results in same output for "ptype" and "whatis". Before: (gdb) whatis t3p type = PTR TO -> ( Type t3 integer(kind=4) :: t3_i Type t2 integer(kind=4) :: t2_i Type t1 :: t1_n End Type t2 :: t2_n End Type t3 ) After: (gdb) whatis t3p type = PTR TO -> ( Type t3 ) 2016-05-09 Bernhard Heckel gdb/Changelog: * f-typeprint.c (f_type_print_base): Replace 0 by show. gdb/testsuite/Changelog: * gdb.fortran/type.f90: Add pointer variable. * gdb.fortran/whatis_type.exp: Add whatis/ptype of pointers. --- gdb/f-typeprint.c | 4 ++-- gdb/testsuite/gdb.fortran/type.f90 | 9 +++++++-- gdb/testsuite/gdb.fortran/whatis_type.exp | 10 ++++++++++ 3 files changed, 19 insertions(+), 4 deletions(-) diff --git a/gdb/f-typeprint.c b/gdb/f-typeprint.c index 0389c14..f1f0063 100644 --- a/gdb/f-typeprint.c +++ b/gdb/f-typeprint.c @@ -308,12 +308,12 @@ f_type_print_base (struct type *type, struct ui_file *stream, int show, case TYPE_CODE_PTR: fprintf_filtered (stream, "PTR TO -> ( "); - f_type_print_base (TYPE_TARGET_TYPE (type), stream, 0, level); + f_type_print_base (TYPE_TARGET_TYPE (type), stream, show, level); break; case TYPE_CODE_REF: fprintf_filtered (stream, "REF TO -> ( "); - f_type_print_base (TYPE_TARGET_TYPE (type), stream, 0, level); + f_type_print_base (TYPE_TARGET_TYPE (type), stream, show, level); break; case TYPE_CODE_VOID: diff --git a/gdb/testsuite/gdb.fortran/type.f90 b/gdb/testsuite/gdb.fortran/type.f90 index 00dc650..0295a20 100644 --- a/gdb/testsuite/gdb.fortran/type.f90 +++ b/gdb/testsuite/gdb.fortran/type.f90 @@ -33,7 +33,10 @@ program type type (t1) :: t1v type (t2) :: t2v - type (t3) :: t3v + type (t3), target :: t3v + type(t3), pointer :: t3p + + nullify (t3p) t1v%t1_i = 42 t1v%t1_r = 42.24 @@ -42,6 +45,8 @@ program type t2v%t1_n%t1_i = 21 t3v%t3_i = 3 t3v%t2_n%t2_i = 32 - t3v%t2_n%t1_n%t1_i = 321 ! bp1 + t3v%t2_n%t1_n%t1_i = 321 + + t3p => t3v ! bp1 end program type diff --git a/gdb/testsuite/gdb.fortran/whatis_type.exp b/gdb/testsuite/gdb.fortran/whatis_type.exp index c1e2745..8ac9355 100644 --- a/gdb/testsuite/gdb.fortran/whatis_type.exp +++ b/gdb/testsuite/gdb.fortran/whatis_type.exp @@ -44,6 +44,7 @@ gdb_test "whatis t2" "type = Type t2" gdb_test "whatis t2v" "type = Type t2" gdb_test "whatis t3" "type = Type t3" gdb_test "whatis t3v" "type = Type t3" +gdb_test "whatis t3p" "type = PTR TO -> \\( Type t3 \\)" gdb_test "ptype t1" \ [multi_line "type = Type t1" \ @@ -74,3 +75,12 @@ gdb_test "ptype t3v" \ " Type t1 :: t1_n" \ " End Type t2 :: t2_n" \ "End Type t3"] + +gdb_test "ptype t3p" \ + [multi_line "type = PTR TO -> \\( Type t3" \ + " $int :: t3_i" \ + " Type t2" \ + " $int :: t2_i" \ + " Type t1 :: t1_n" \ + " End Type t2 :: t2_n" \ + "End Type t3 \\)"] -- 2.7.1.339.g0233b80