Re: [RFC 2/3] use reinsert breakpoint for vCont;s

Yao Qi
2016-05-12T16:38:50Z

Antoine Tremblay <antoine.tremblay@ericsson.com> writes:

> I though we would have to explicitly stop the threads, I'm curious has
> to where you moved it so that the threads are stopped ?

I moved the code deleting reinsert breakpoint to the place where
GDBserver is ready to report a stop back to GDB, because on this point,
all threads stop in all-stop mode, and the event thread stops in
no-stop mode. In non-stop mode, I delete the reinsert breakpoint of
event thread, while in all-stop mode, I delete the reinsert breakpoint
of all threads.

You are right that it is unsafe to remove reinsert breakpoint while some
threads are still running (in non-stop mode).

--
Yao (齐尧)