From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26591 invoked by alias); 9 Apr 2016 19:25:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26580 invoked by uid 89); 9 Apr 2016 19:25:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=rnl, rnh, H*r:sk:mailout X-HELO: mailout05.t-online.de Received: from mailout05.t-online.de (HELO mailout05.t-online.de) (194.25.134.82) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sat, 09 Apr 2016 19:25:07 +0000 Received: from fwd34.aul.t-online.de (fwd34.aul.t-online.de [172.20.26.145]) by mailout05.t-online.de (Postfix) with SMTP id DED25592532 for ; Sat, 9 Apr 2016 21:25:02 +0200 (CEST) Received: from [192.168.0.16] (ZB9eXvZYrhddx23LycLa-YOE+juD7GdPV3kDdMfbcCFf4epUOz6rKMxPg+6wBXygtW@[115.165.93.200]) by fwd34.t-online.de with (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384 encrypted) esmtp id 1aoyVB-2FyRW40; Sat, 9 Apr 2016 21:25:01 +0200 Message-ID: <1460229897.2115.24.camel@t-online.de> Subject: [SH] Fix simulator on 64 bit hosts From: Oleg Endo To: gdb-patches@sourceware.org Date: Sat, 09 Apr 2016 19:25:00 -0000 Content-Type: multipart/mixed; boundary="=-C2EYgbkywpYo5elH+IJY" Mime-Version: 1.0 X-SW-Source: 2016-04/txt/msg00198.txt.bz2 --=-C2EYgbkywpYo5elH+IJY Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Content-length: 563 Hi, The attached patch fixes the SH simulator when ran on 64 bit hosts. It seems there are quite a few adventurous or at least confusing integer type casts, but the main problem was the widening 32 x 32 -> 64 bit multiplication. Tested by running the GCC testsuite and checking that 32 bit sim and 64 bit sim produce the same test results. Cheers, Oleg sim/sh/ChangeLog: * interp.c (dmul): Split into dmul_s and dmul_u. Use explicit integer width types and simplify implementation. * gencode.c (dmuls.l, dmulu.l): Use new functions dmul_s and dmul_u. --=-C2EYgbkywpYo5elH+IJY Content-Disposition: attachment; filename="sh_sim_64bit_2.patch" Content-Type: text/x-patch; name="sh_sim_64bit_2.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 Content-length: 2928 ZGlmZiAtLWdpdCBhL3NpbS9zaC9nZW5jb2RlLmMgYi9zaW0vc2gvZ2VuY29k ZS5jCmluZGV4IGFhMjZlNmMuLmY4ZjcwNzQgMTAwNjQ0Ci0tLSBhL3NpbS9z aC9nZW5jb2RlLmMKKysrIGIvc2ltL3NoL2dlbmNvZGUuYwpAQCAtNDA1LDEx ICs0MDUsMTEgQEAgc3RhdGljIG9wIHRhYltdID0KICAgfSwKIAogICB7ICIi LCAibm0iLCAiZG11bHMubCA8UkVHX00+LDxSRUdfTj4iLCAiMDAxMW5ubm5t bW1tMTEwMSIsCi0gICAgImRtdWwgKDEvKnNpZ25lZCovLCBSW25dLCBSW21d KTsiLAorICAgICJkbXVsX3MgKFJbbl0sIFJbbV0pOyIsCiAgIH0sCiAKICAg eyAiIiwgIm5tIiwgImRtdWx1LmwgPFJFR19NPiw8UkVHX04+IiwgIjAwMTFu bm5ubW1tbTAxMDEiLAotICAgICJkbXVsICgwLyp1bnNpZ25lZCovLCBSW25d LCBSW21dKTsiLAorICAgICJkbXVsX3UgKFJbbl0sIFJbbV0pOyIsCiAgIH0s CiAKICAgeyAibiIsICJuIiwgImR0IDxSRUdfTj4iLCAiMDEwMG5ubm4wMDAx MDAwMCIsCmRpZmYgLS1naXQgYS9zaW0vc2gvaW50ZXJwLmMgYi9zaW0vc2gv aW50ZXJwLmMKaW5kZXggMDcyZjcxZC4uYjQ5MTRkMSAxMDA2NDQKLS0tIGEv c2ltL3NoL2ludGVycC5jCisrKyBiL3NpbS9zaC9pbnRlcnAuYwpAQCAtNTc3 LDcgKzU3Nyw3IEBAIHJ3YXRfZmFzdCAodW5zaWduZWQgY2hhciAqbWVtb3J5 LCBpbnQgeCwgaW50IG1hc2t3LCBpbnQgZW5kaWFudykKIHN0YXRpYyBJTkxJ TkUgaW50CiByaWF0X2Zhc3QgKHVuc2lnbmVkIGNoYXIgKmluc25fcHRyLCBp bnQgZW5kaWFudykKIHsKLSAgdW5zaWduZWQgc2hvcnQgKnAgPSAodW5zaWdu ZWQgc2hvcnQgKikgKChzaXplX3QpIGluc25fcHRyIF4gZW5kaWFudyk7Cisg IHVuc2lnbmVkIHNob3J0ICpwID0gKHVuc2lnbmVkIHNob3J0ICopICgodWlu dHB0cl90KSBpbnNuX3B0ciBeIGVuZGlhbncpOwogCiAgIHJldHVybiAqcDsK IH0KQEAgLTEyMDEsNDEgKzEyMDEsMTkgQEAgZGl2MSAoaW50ICpSLCBpbnQg aVJuMiwgaW50IGlSbjEvKiwgaW50IFQqLykKIH0KIAogc3RhdGljIHZvaWQK LWRtdWwgKGludCBzaWduLCB1bnNpZ25lZCBpbnQgcm0sIHVuc2lnbmVkIGlu dCBybikKLXsKLSAgdW5zaWduZWQgbG9uZyBSbkwsIFJuSDsKLSAgdW5zaWdu ZWQgbG9uZyBSbUwsIFJtSDsKLSAgdW5zaWduZWQgbG9uZyB0ZW1wMCwgdGVt cDEsIHRlbXAyLCB0ZW1wMzsKLSAgdW5zaWduZWQgbG9uZyBSZXMyLCBSZXMx LCBSZXMwOwotCi0gIFJuTCA9IHJuICYgMHhmZmZmOwotICBSbkggPSAocm4g Pj4gMTYpICYgMHhmZmZmOwotICBSbUwgPSBybSAmIDB4ZmZmZjsKLSAgUm1I ID0gKHJtID4+IDE2KSAmIDB4ZmZmZjsKLSAgdGVtcDAgPSBSbUwgKiBSbkw7 Ci0gIHRlbXAxID0gUm1IICogUm5MOwotICB0ZW1wMiA9IFJtTCAqIFJuSDsK LSAgdGVtcDMgPSBSbUggKiBSbkg7Ci0gIFJlczIgPSAwOwotICBSZXMxID0g dGVtcDEgKyB0ZW1wMjsKLSAgaWYgKFJlczEgPCB0ZW1wMSkKLSAgICBSZXMy ICs9IDB4MDAwMTAwMDA7Ci0gIHRlbXAxID0gKFJlczEgPDwgMTYpICYgMHhm ZmZmMDAwMDsKLSAgUmVzMCA9IHRlbXAwICsgdGVtcDE7Ci0gIGlmIChSZXMw IDwgdGVtcDApCi0gICAgUmVzMiArPSAxOwotICBSZXMyICs9ICgoUmVzMSA+ PiAxNikgJiAweGZmZmYpICsgdGVtcDM7Ci0gIAotICBpZiAoc2lnbikKLSAg ICB7Ci0gICAgICBpZiAocm4gJiAweDgwMDAwMDAwKQotCVJlczIgLT0gcm07 Ci0gICAgICBpZiAocm0gJiAweDgwMDAwMDAwKQotCVJlczIgLT0gcm47Ci0g ICAgfQorZG11bF9zICh1aW50MzJfdCBybSwgdWludDMyX3Qgcm4pCit7Cisg IGludDY0X3QgcmVzID0gKGludDY0X3QpKGludDMyX3Qpcm0gKiAoaW50NjRf dCkoaW50MzJfdClybjsKKyAgTUFDSCA9ICh1aW50MzJfdCkoKHVpbnQ2NF90 KXJlcyA+PiAzMik7CisgIE1BQ0wgPSAodWludDMyX3QpcmVzOworfQogCi0g IE1BQ0ggPSBSZXMyOwotICBNQUNMID0gUmVzMDsKK3N0YXRpYyB2b2lkCitk bXVsX3UgKHVpbnQzMl90IHJtLCB1aW50MzJfdCBybikKK3sKKyAgdWludDY0 X3QgcmVzID0gKHVpbnQ2NF90KSh1aW50MzJfdClybSAqICh1aW50NjRfdCko dWludDMyX3Qpcm47CisgIE1BQ0ggPSAodWludDMyX3QpKHJlcyA+PiAzMik7 CisgIE1BQ0wgPSAodWludDMyX3QpcmVzOwogfQogCiBzdGF0aWMgdm9pZAo= --=-C2EYgbkywpYo5elH+IJY--