From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97563 invoked by alias); 21 Jun 2017 09:31:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 97543 invoked by uid 89); 21 Jun 2017 09:31:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: =?ISO-8859-1?Q?No, score=-26.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=doesn=e2, doesn, Hauthentication-results:gmail.com?= X-HELO: EUR02-VE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr20047.outbound.protection.outlook.com (HELO EUR02-VE1-obe.outbound.protection.outlook.com) (40.107.2.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Jun 2017 09:31:43 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) by AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1178.14; Wed, 21 Jun 2017 09:31:40 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::9063:8caa:1bc4:156f]) by AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::9063:8caa:1bc4:156f%14]) with mapi id 15.01.1178.023; Wed, 21 Jun 2017 09:31:40 +0000 From: Alan Hayward To: Yao Qi CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH] Remove an instance of MAX_REGISTER_SIZE from record-full.c Date: Wed, 21 Jun 2017 09:31:00 -0000 Message-ID: <145F6402-29CD-4740-A17F-D01002C08DFA@arm.com> References: <69EEE46A-D88C-4B4F-86A2-E35F6DAFD90A@arm.com> <86d1a9a2k9.fsf@gmail.com> In-Reply-To: authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM3PR08MB0101;7:FYSG0U/87Ec+PMmZvK2jt8o9Jws3iGToU3FVi5X64eAwV21QHJhJX1WzjXk5HDaRg0K9a6loC/fMyXH2X7aKWDNJCd54D86Wauc+433H3nX3/l9NC9pAN99AQ5fKZCLhJe95Gp36YLzDzPTzMbLjzF4GIkvNuwoTNDoXIyTYOFjcQ/9jCjX68KoUiT9YSCfIRL1o6e6qelY3WOwClVUgfdiNklj3isNiPTNT6m1kc+WHB4+XfIHz4S/uyda/xnJVGlODWQ44LpmGCH1nZWct9ZqQJcNEbQKZ2pQ2Alujh1k9gtUlLoxODydFelH9WQHg3K1t43Xtymwxlj3wl6BUPjXx3kJlQtOAHHHp6VQD5skuB3PWkS8uqPHHyx/6ZenA5sWboxPsg//aJKqGwYAvH0KQG6FKxmvN/MnkWOfbyA8l33ub5ajjXR2tLl51mYbVxR7dPcovjqkJKPZ/Vk8dYTdtPV4EKv23DrgZOrpH9eCe99AK2IHR3zXMXx7PMY+8yjyQfvFy4aZsRB2CmiR4I3jfE+8R19owwAeqhZIBjs4h9Wq1NzMgQ9cMffvgYQ1zCS8HyNfgJftCOgU5LMLxUYxln3umT31tENtK7D4IC2XwpDqySANMAQlLfXMziS2f8w3Hb/e6M1UTZRMd4IXH8w+BgDORetlb97Fr61JrhEFxH1efyDRXcMbKAWDaVLvf5fsoE2jG0c7Tc4NXKYYYWaFd40dxucVhxcF86hGLTKXUvqiNzd9UP4uOrV0LR+CjyIRB6DhoggRPdMfvNvgBgRfL2/zCGbrVZokT3GeeFZQ= x-ms-office365-filtering-correlation-id: afd91145-c66e-4e27-8b44-08d4b88852c2 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081);SRVR:AM3PR08MB0101; x-ms-traffictypediagnostic: AM3PR08MB0101: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123558100)(20161123564025)(20161123562025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:AM3PR08MB0101;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:AM3PR08MB0101; x-forefront-prvs: 0345CFD558 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39840400002)(39860400002)(39450400003)(39850400002)(39400400002)(39410400002)(377424004)(24454002)(25786009)(39060400002)(102836003)(6116002)(5660300001)(8936002)(4326008)(3846002)(81166006)(8676002)(54906002)(6512007)(99286003)(189998001)(6506006)(5250100002)(110136004)(6436002)(38730400002)(33656002)(53936002)(54356999)(76176999)(53546010)(83716003)(50986999)(6246003)(2900100001)(305945005)(82746002)(36756003)(6486002)(7736002)(229853002)(66066001)(1411001)(86362001)(575784001)(14454004)(3280700002)(478600001)(3660700001)(6916009)(2950100002)(72206003)(2906002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR08MB0101;H:AM3PR08MB0101.eurprd08.prod.outlook.com;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <68419DB2094F8949939D970C0A468817@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jun 2017 09:31:40.7908 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0101 X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00582.txt.bz2 UElORw0KDQo+IE9uIDEyIEp1biAyMDE3LCBhdCAxNDo1OSwgQWxhbiBIYXl3 YXJkIDxBbGFuLkhheXdhcmRAYXJtLmNvbT4gd3JvdGU6DQo+IA0KPiANCj4+ IE9uIDEyIEp1biAyMDE3LCBhdCAxMjowNSwgWWFvIFFpIDxxaXlhb2x0Y0Bn bWFpbC5jb20+IHdyb3RlOg0KPj4gDQo+PiBBbGFuIEhheXdhcmQgPEFsYW4u SGF5d2FyZEBhcm0uY29tPiB3cml0ZXM6DQo+PiANCj4+PiAtICAgICAgICBy ZWdjYWNoZV9jb29rZWRfcmVhZCAocmVnY2FjaGUsIGVudHJ5LT51LnJlZy5u dW0sIHJlZyk7DQo+Pj4gLSAgICAgICAgcmVnY2FjaGVfY29va2VkX3dyaXRl IChyZWdjYWNoZSwgZW50cnktPnUucmVnLm51bSwNCj4+PiAtCQkJICAgICAg IHJlY29yZF9mdWxsX2dldF9sb2MgKGVudHJ5KSk7DQo+Pj4gLSAgICAgICAg bWVtY3B5IChyZWNvcmRfZnVsbF9nZXRfbG9jIChlbnRyeSksIHJlZywgZW50 cnktPnUucmVnLmxlbik7DQo+PiANCj4+IFRoZSBvcmlnaW5hbCBjb2RlIGlz IGFib3V0IHN3YXBwaW5nIGNvbnRlbnRzIG9mIHJlZ2lzdGVyIFJFRyBpbiBy ZWdjYWNoZQ0KPj4gYW5kIHJlY29yZF9mdWxsX2dldF9sb2MgKGVudHJ5KSwg YW5kIHRoZSBsZW5ndGggaXMga25vd24gZW50cnktPnUucmVnLmxlbi4NCj4+ IA0KPiANCj4gWWVzLg0KPiANCj4+PiArCXZhbHVlID0gcmVnY2FjaGUtPmNv b2tlZF9yZWFkX3ZhbHVlIChlbnRyeS0+dS5yZWcubnVtKTsNCj4+PiArCWdk Yl9hc3NlcnQgKHZhbHVlICE9IE5VTEwpOw0KPj4+ICsJcmVnY2FjaGUtPmNv b2tlZF93cml0ZSAoZW50cnktPnUucmVnLm51bSwgcmVjb3JkX2Z1bGxfZ2V0 X2xvYyAoZW50cnkpKTsNCj4+PiArCW1lbWNweSAocmVjb3JkX2Z1bGxfZ2V0 X2xvYyAoZW50cnkpLCB2YWx1ZV9jb250ZW50c19hbGwgKHZhbHVlKSwNCj4+ PiArCQllbnRyeS0+dS5yZWcubGVuKTsNCj4+PiArCXJlbGVhc2VfdmFsdWUg KHZhbHVlKTsNCj4+PiArCXZhbHVlX2ZyZWUgKHZhbHVlKTsNCj4+IA0KPj4g SXQgaXMgYSBvdmVya2lsbCB0byB1c2UgdmFsdWUgdG8gc3dhcCB0aGVzZSB0 d28gYnVmZmVycywgSU1PLiAgSG93IGFib3V0DQo+PiB4bWFsbG9jICJyZWci IGluc3RlYWQ/DQo+PiANCj4gDQo+IEdpdmVuIHRoYXQgdGhlIGNvZGUgZG9l c27igJl0IHVzZSBhbnkgb2YgdGhlIGVycm9yIGNoZWNraW5nLCB0aGVuIGFn cmVlZC4NCj4gDQo+IA0KPiBUZXN0ZWQgb24gYSAtLWVuYWJsZS10YXJnZXRz PWFsbCBidWlsZCB3aXRoIGJvYXJkIGZpbGVzIHVuaXggYW5kDQo+IG5hdGl2 ZS1nZGJzZXJ2ZXIuDQo+IA0KPiANCj4gT2sgdG8gY29tbWl0Pw0KPiBBbGFu Lg0KPiANCj4gMjAxNy0wNi0xMiAgQWxhbiBIYXl3YXJkICA8YWxhbi5oYXl3 YXJkQGFybS5jb20+DQo+IA0KPiAJKiBnZGIvcmVjb3JkLWZ1bGwuYyAocmVj b3JkX2Z1bGxfZXhlY19pbnNuKTogQWxsb2NhdGUgYnVmZmVyLg0KPiANCj4g DQo+IGRpZmYgLS1naXQgYS9nZGIvcmVjb3JkLWZ1bGwuYyBiL2dkYi9yZWNv cmQtZnVsbC5jDQo+IGluZGV4IDMxZmY1NThkMmE2MzNjZmY3MWQzZTYwODJl NDJmNWQ2ZmI4OGJjZjEuLjRmNzNlMmE1YWQwZDRhMjQwN2IzMWExZDM5MWU4 MTMxNDdlMTU3OTggMTAwNjQ0DQo+IC0tLSBhL2dkYi9yZWNvcmQtZnVsbC5j DQo+ICsrKyBiL2dkYi9yZWNvcmQtZnVsbC5jDQo+IEBAIC02OTgsNyArNjk4 LDcgQEAgcmVjb3JkX2Z1bGxfZXhlY19pbnNuIChzdHJ1Y3QgcmVnY2FjaGUg KnJlZ2NhY2hlLA0KPiAgICAgew0KPiAgICAgY2FzZSByZWNvcmRfZnVsbF9y ZWc6IC8qIHJlZyAqLw0KPiAgICAgICB7DQo+IC0gICAgICAgIGdkYl9ieXRl IHJlZ1tNQVhfUkVHSVNURVJfU0laRV07DQo+ICsgICAgICAgIGdkYl9ieXRl ICpyZWcgPSAoZ2RiX2J5dGUgKikgeG1hbGxvYyAoZW50cnktPnUucmVnLmxl bik7DQo+IA0KPiAgICAgICAgIGlmIChyZWNvcmRfZGVidWcgPiAxKQ0KPiAg ICAgICAgICAgZnByaW50Zl91bmZpbHRlcmVkIChnZGJfc3RkbG9nLA0KPiBA QCAtNzExLDYgKzcxMSw3IEBAIHJlY29yZF9mdWxsX2V4ZWNfaW5zbiAoc3Ry dWN0IHJlZ2NhY2hlICpyZWdjYWNoZSwNCj4gICAgICAgICByZWdjYWNoZV9j b29rZWRfd3JpdGUgKHJlZ2NhY2hlLCBlbnRyeS0+dS5yZWcubnVtLA0KPiAJ CQkgICAgICAgcmVjb3JkX2Z1bGxfZ2V0X2xvYyAoZW50cnkpKTsNCj4gICAg ICAgICBtZW1jcHkgKHJlY29yZF9mdWxsX2dldF9sb2MgKGVudHJ5KSwgcmVn LCBlbnRyeS0+dS5yZWcubGVuKTsNCj4gKyAgICAgICAgeGZyZWUgKHJlZyk7 DQo+ICAgICAgIH0NCj4gICAgICAgYnJlYWs7DQo+IA0KPiANCj4gDQoNCg== >From gdb-patches-return-139963-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Jun 21 09:36:00 2017 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 51461 invoked by alias); 21 Jun 2017 09:36:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 51451 invoked by uid 89); 21 Jun 2017 09:35:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=HTo:D*cadence.com, Maxim, maxim X-HELO: EUR02-AM5-obe.outbound.protection.outlook.com Received: from mail-eopbgr00050.outbound.protection.outlook.com (HELO EUR02-AM5-obe.outbound.protection.outlook.com) (40.107.0.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Jun 2017 09:35:57 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) by AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1178.14; Wed, 21 Jun 2017 09:35:54 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::9063:8caa:1bc4:156f]) by AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::9063:8caa:1bc4:156f%14]) with mapi id 15.01.1178.023; Wed, 21 Jun 2017 09:35:54 +0000 From: Alan Hayward To: Yao Qi , "jcmvbkbc@gmail.com" , "larue@cadence.com" CC: "maxim2405@gmail.com" , "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH 10/11] Add XTENSA_MAX_REGISTER_SIZE Date: Wed, 21 Jun 2017 09:36:00 -0000 Message-ID: <634078F3-1AE6-458C-8184-549175C95BB7@arm.com> References: <86y3vfp308.fsf@gmail.com> <868tmosdi0.fsf@gmail.com> <49176F63-F5C5-43C2-A21D-A7642F4ACB80@arm.com> <3966B257-0F47-49C3-A1C1-F901D8E731AC@arm.com> <86h8zla5ui.fsf@gmail.com> In-Reply-To: <86h8zla5ui.fsf@gmail.com> authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM3PR08MB0101;7:/DVgeYAT4aQnUfnxkrJ/yTcCDA4kGGt55dfMBiP139El2eaZw6JROgIrSYD/EQZlqVbegSVj1I2iYPA2qA6Ayq7nr8zM0ADbNfPCJmJTBmA9KZNcP+ph4+UL+VtXuHZO+yAOjpR2oahOv3sPb92d3mxU0JJxknH5b669/WWgbImBisaKakcIWtUZmIoKkmWrlgDkwbg6K8w7CuC/aplpjgsz1ftdtnZAPcGom7EtVhCKNC616747FwXQPw8cFyz623ex6k8TH8FlOkTs6ooTxnKosLg+vOB6ed1EF6yAE5oztAFtHpNXCcA5yvwrJpcQEvh0h09JfipkpUMpGR1fUOV2b0h6Ga3eAZWI/e/izTg6Lf9VUKuN6qRcD6+l0CZcgJ+Vv+mUJaQSRj/rBcbp2ctXXmI5qBBkAmAPRT39TV4dgNhH3joCOsbDLNg413f46TsuQOmpa7kxYEPJ+UudVAH3uj+XJ0SEet3PPRUomszuqfd3zxPGKlrM+tI/cK1VHxS25Fu0qPNZlYYThpkuZerUrP72AeIpWLWw2wl+eANIQZ9OJ5zhD1SMuwSjRugtSABOE0ik+R5x6OsO0zqJIOvkzGh9hipdYXyE2ohNCqS/sBEZpyp7sjLkPr8u4RtLy+9FS4jyP72VAOcGE3BVNKDQiXQjpjVv2jL9zHfiWbiwku7c0ZRqvZG0VOzyUL5bI6+seq8U9F8QhdCRXmCh0TVxurnKERK5UraebXiEzjBboS17x4rAT6P0byeh2I1Y4sNTqLdT7l4d0lEDon/C4GUl4TjUEm41T4371xMDULo= x-ms-office365-filtering-correlation-id: b28006b8-c47f-4c0c-810f-08d4b888e9ba x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081)(201702281549075);SRVR:AM3PR08MB0101; x-ms-traffictypediagnostic: AM3PR08MB0101: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123558100)(20161123564025)(20161123562025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:AM3PR08MB0101;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:AM3PR08MB0101; x-forefront-prvs: 0345CFD558 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39410400002)(39400400002)(39850400002)(39450400003)(39840400002)(39860400002)(76104003)(24454002)(377424004)(66066001)(7736002)(36756003)(6486002)(229853002)(478600001)(2950100002)(72206003)(2906002)(3660700001)(86362001)(3280700002)(14454004)(3846002)(81166006)(8936002)(4326008)(99286003)(189998001)(2501003)(6506006)(8666007)(8676002)(54906002)(6512007)(39060400002)(25786009)(5660300001)(102836003)(6116002)(305945005)(2900100001)(82746002)(6436002)(38730400002)(33656002)(5250100002)(6246003)(50986999)(83716003)(93886004)(2201001)(54356999)(76176999)(53936002)(53546010);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR08MB0101;H:AM3PR08MB0101.eurprd08.prod.outlook.com;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <259B1D1F64548B40909CE95691924576@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jun 2017 09:35:54.1365 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0101 X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00583.txt.bz2 Content-length: 2762 QWRkaW5nIFdvb2R5IGFuZCBNYXgsIHRoZSB4dGVuc2EgbWFpbnRhaW5lcnMu DQpQYXRjaCBpcyB0byByZW1vdmUgdXNlcyBvZiBNQVhfUkVHSVNURVJfU0la RSBpbiB4dGVuc2EtdGRlcC5jDQpSZS1wYXN0ZWQgcGF0Y2ggdG8gZW5kIG9m IGVtYWlsIGZvciBjb252ZW5pZW5jZS4NCg0KDQo+IE9uIDEyIEp1biAyMDE3 LCBhdCAxMDo1NCwgWWFvIFFpIDxxaXlhb2x0Y0BnbWFpbC5jb20+IHdyb3Rl Og0KPiANCj4gQWxhbiBIYXl3YXJkIDxBbGFuLkhheXdhcmRAYXJtLmNvbT4g d3JpdGVzOg0KPiANCj4+IEkgZG9uJ3QgaGF2ZSBhIFhURU5TQSBtYWNoaW5l IHRvIHRlc3Qgb24uDQo+PiBUZXN0ZWQgb24gYSAtLWVuYWJsZS10YXJnZXRz PWFsbCBhbmQgYXNhbiBidWlsZCB1c2luZw0KPj4gbWFrZSBjaGVjayB3aXRo IGJvYXJkIGZpbGVzIHVuaXgsIG5hdGl2ZS1nZGJzZXJ2ZXIgYW5kIHVuaXR0 ZXN0DQo+PiANCj4+IE9rIHRvIGNvbW1pdD8NCj4+IA0KPj4gQWxhbi4NCj4+ IA0KPj4gMjAxNy0wNi0wOCAgQWxhbiBIYXl3YXJkICA8YWxhbi5oYXl3YXJk QGFybS5jb20+DQo+PiANCj4+IAkqIHh0ZW5zYS10ZGVwLmMgKFhURU5TQV9N QVhfUkVHSVNURVJfU0laRSk6IEFkZC4NCj4+IAkoeHRlbnNhX3JlZ2lzdGVy X3dyaXRlX21hc2tlZCk6IFVzZSBYVEVOU0FfTUFYX1JFR0lTVEVSX1NJWkUu DQo+PiAJKHh0ZW5zYV9yZWdpc3Rlcl9yZWFkX21hc2tlZCk6IExpa2V3aXNl Lg0KPiANCj4gSGkgTWF4aW0sDQo+IFdoYXQgZG8geW91IHRoaW5rIGFib3V0 IHRoaXMgcGF0Y2g/DQo+IA0KPiAtLSANCj4gWWFvICjpvZDlsKcpDQoNCg0K ZGlmZiAtLWdpdCBhL2dkYi94dGVuc2EtdGRlcC5jIGIvZ2RiL3h0ZW5zYS10 ZGVwLmMNCmluZGV4IGY5ZTg1ODQ3M2E0MDlmZjA4MmQzMGY5ZmY0NzRkNDhk YTYzOTAzZTMuLmY4NzVmMjBkMzJiNjhhYmMzN2UzZGIzN2FiM2U2MDUzOTE4 NTM2ZTUgMTAwNjQ0DQotLS0gYS9nZGIveHRlbnNhLXRkZXAuYw0KKysrIGIv Z2RiL3h0ZW5zYS10ZGVwLmMNCkBAIC0xMjAsNiArMTIwLDkgQEAgc3RhdGlj IHVuc2lnbmVkIGludCB4dGVuc2FfZGVidWdfbGV2ZWwgPSAwOw0KICNkZWZp bmUgUFNfV09FCQkJKDE8PDE4KQ0KICNkZWZpbmUgUFNfRVhDCQkJKDE8PDQp DQoNCisvKiBCaWcgZW5vdWdoIHRvIGhvbGQgdGhlIHNpemUgb2YgdGhlIGxh cmdlc3QgcmVnaXN0ZXIgaW4gYnl0ZXMuICAqLw0KKyNkZWZpbmUgWFRFTlNB X01BWF9SRUdJU1RFUl9TSVpFCTY0DQorDQogc3RhdGljIGludA0KIHdpbmRv d2luZ19lbmFibGVkIChzdHJ1Y3QgZ2RiYXJjaCAqZ2RiYXJjaCwgdW5zaWdu ZWQgaW50IHBzKQ0KIHsNCkBAIC0zNzAsNyArMzczLDcgQEAgc3RhdGljIHZv aWQNCiB4dGVuc2FfcmVnaXN0ZXJfd3JpdGVfbWFza2VkIChzdHJ1Y3QgcmVn Y2FjaGUgKnJlZ2NhY2hlLA0KIAkJCSAgICAgIHh0ZW5zYV9yZWdpc3Rlcl90 ICpyZWcsIGNvbnN0IGdkYl9ieXRlICpidWZmZXIpDQogew0KLSAgdW5zaWdu ZWQgaW50IHZhbHVlWyhNQVhfUkVHSVNURVJfU0laRSArIDMpIC8gNF07DQor ICB1bnNpZ25lZCBpbnQgdmFsdWVbKFhURU5TQV9NQVhfUkVHSVNURVJfU0la RSArIDMpIC8gNF07DQogICBjb25zdCB4dGVuc2FfbWFza190ICptYXNrID0g cmVnLT5tYXNrOw0KDQogICBpbnQgc2hpZnQgPSAwOwkJLyogU2hpZnQgZm9y IG5leHQgbWFzayAobW9kIDMyKS4gICovDQpAQCAtNDU0LDcgKzQ1Nyw3IEBA IHN0YXRpYyBlbnVtIHJlZ2lzdGVyX3N0YXR1cw0KIHh0ZW5zYV9yZWdpc3Rl cl9yZWFkX21hc2tlZCAoc3RydWN0IHJlZ2NhY2hlICpyZWdjYWNoZSwNCiAJ CQkgICAgIHh0ZW5zYV9yZWdpc3Rlcl90ICpyZWcsIGdkYl9ieXRlICpidWZm ZXIpDQogew0KLSAgdW5zaWduZWQgaW50IHZhbHVlWyhNQVhfUkVHSVNURVJf U0laRSArIDMpIC8gNF07DQorICB1bnNpZ25lZCBpbnQgdmFsdWVbKFhURU5T QV9NQVhfUkVHSVNURVJfU0laRSArIDMpIC8gNF07DQogICBjb25zdCB4dGVu c2FfbWFza190ICptYXNrID0gcmVnLT5tYXNrOw0KDQogICBpbnQgc2hpZnQg PSAwOw0KDQoNCg== >From gdb-patches-return-139964-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Jun 21 09:37:36 2017 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 54498 invoked by alias); 21 Jun 2017 09:37:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 54463 invoked by uid 89); 21 Jun 2017 09:37:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LOTSOFHASH,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=forcing X-HELO: EUR02-AM5-obe.outbound.protection.outlook.com Received: from mail-eopbgr00048.outbound.protection.outlook.com (HELO EUR02-AM5-obe.outbound.protection.outlook.com) (40.107.0.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Jun 2017 09:37:31 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) by AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1178.14; Wed, 21 Jun 2017 09:37:28 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::9063:8caa:1bc4:156f]) by AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::9063:8caa:1bc4:156f%14]) with mapi id 15.01.1178.023; Wed, 21 Jun 2017 09:37:28 +0000 From: Alan Hayward To: "gdb-patches@sourceware.org" CC: nd Subject: Re: [PATCH] Replace regbuf with regcache in record-full.c Date: Wed, 21 Jun 2017 09:37:00 -0000 Message-ID: References: In-Reply-To: authentication-results: sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM3PR08MB0101;7:g2k6M8DHvl4XKF6vorypn98Gng3MPy1HuiCQvKctWXp9MqO+5tpXA/l2+bypbzbtk4Ay9e2T9mDOq4tovdlFDqo98VUzhyVv0i82PplugNjdb5pcgZH/IvE32U6DFaSK0qrikCIyRNlzbI7nFo1XbwIhs+oN6uNlcCrX3oo+B97gwkgorUh/8ULLg6MhFrrvGSxjurlk1BqdGyoG6pCftCEKYxAdLAaGeWk5mD682byT2uxAjlzyXUxSi/FqJ9tTUCwekPNOTHWSWbttO2EJ1T7dJoHi6rR0hQKu3U+ggot5dK1e5N0FzCUOtzOPuSpp8D2a6mNoKiB3KJBPi01gQNuzNb2vx7P7xytybg8IjAMSK/mea1lNu8zbCm4OLZH+r36mGNQQIMwvSwm31fW0Yo3bqlEuDyO4Utwg050Txc5oogkogA+8MYpLU3laecQ5LDfFEeSQbFFMgKVShbtZe+p2JnTXrEU3FKM5sDANTTB6judS9QSJ3jbWxtwUcw1e6uz5HVbOVKvD6/z5fnJxiov5jGcMmoo0uRwi18N0z19k7pqzSzs2XYz+b/WPILP/HIfxr94YBFv8Pf/kMrQc0bg24aDTWsJQ5kgEtdvOHNG9ex3mxHoG8ASg8+cK8OyZ8tvh+5cMQe6EoUVOnJlomaN1dQP87BjMgdOjw1qm9u2xbodSR5M+IDkBr9b+Aye8hZMerRKb0ebLbKMvFMeyTklPjupzJ0LYfYC3uTz+s35P+S6cjWqS17BhZn+IMyz+ozQW3N4rZr79c7ZIlxbm46aeLli2tnyliUsy75tDvO8= x-ms-office365-filtering-correlation-id: 6238a63c-f1e9-448e-cbca-08d4b88921ec x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081)(201702281549075);SRVR:AM3PR08MB0101; x-ms-traffictypediagnostic: AM3PR08MB0101: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(788757137089); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123558100)(20161123564025)(20161123562025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:AM3PR08MB0101;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:AM3PR08MB0101; x-forefront-prvs: 0345CFD558 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39410400002)(39400400002)(39850400002)(39450400003)(39840400002)(39860400002)(24454002)(377424004)(66066001)(7736002)(36756003)(6486002)(229853002)(478600001)(2950100002)(72206003)(3660700001)(6916009)(2351001)(575784001)(86362001)(3280700002)(14454004)(3846002)(81166006)(8936002)(4326008)(99286003)(189998001)(2501003)(6506006)(8676002)(6512007)(25786009)(5660300001)(102836003)(6116002)(305945005)(2900100001)(82746002)(6436002)(38730400002)(33656002)(5640700003)(110136004)(5250100002)(50986999)(83716003)(54356999)(76176999)(53936002)(53546010);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR08MB0101;H:AM3PR08MB0101.eurprd08.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jun 2017 09:37:28.3560 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0101 X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00584.txt.bz2 Content-length: 7281 PING > On 14 Jun 2017, at 15:02, Alan Hayward wrote: >=20 > In record-full.c, instead of backing up all the registers into a large > buffer, duplicate the regcache. > This enables the removal of an instance of MAX_REGISTER_SIZE. >=20 > Note that regcache_dup() create a read-only copy of a register cache, > which ensures the new regcache cannot write back to the target. >=20 > Once created, we need to be able to copy registers between the two caches, > which we want to do without creating a temporary buffer. >=20 > I've added regcache::raw_copy() to allow the copying of raw registers > between two regcaches - either of which might be set as read-only. >=20 > Alternatively, I could make the new regcache as writable (by enabling a > regcache copy constructor). But, I think this would be dangerous as it > it then has the potential to write back to the target if the wrong functi= on > is called. >=20 > Tested on a --enable-targets=3Dall build with board files unix and > native-gdbserver. >=20 >=20 > Alan. >=20 >=20 > 2017-06-14 Alan Hayward >=20 > * gdb/record-full.c (record_full_core_regbuf): Remove. > (record_full_core_regcache): New. > (record_full_core_open_1): Duplicate regcache > (record_full_close): Delete duplicated regcache. > (record_full_core_fetch_registers): Use duplicated regcache. > (record_full_core_store_registers): Likewise. > * gdb/regcache.c (regcache::raw_copy): New function. > * gdb/regcache.h (regcache::raw_copy): New declaration. >=20 >=20 > diff --git a/gdb/record-full.c b/gdb/record-full.c > index 4f73e2a5ad0d4a2407b31a1d391e813147e15798..00bbda213605110324a6529b9= d4d538cd292c62f 100644 > --- a/gdb/record-full.c > +++ b/gdb/record-full.c > @@ -167,7 +167,7 @@ struct record_full_core_buf_entry > }; >=20 > /* Record buf with core target. */ > -static gdb_byte *record_full_core_regbuf =3D NULL; > +static struct regcache *record_full_core_regcache =3D NULL; > static struct target_section *record_full_core_start; > static struct target_section *record_full_core_end; > static struct record_full_core_buf_entry *record_full_core_buf_list =3D N= ULL; > @@ -793,22 +793,17 @@ static void > record_full_core_open_1 (const char *name, int from_tty) > { > struct regcache *regcache =3D get_current_regcache (); > - int regnum =3D gdbarch_num_regs (get_regcache_arch (regcache)); > - int i; >=20 > - /* Get record_full_core_regbuf. */ > + /* Get record_full_core_regcache. */ > target_fetch_registers (regcache, -1); > - record_full_core_regbuf =3D (gdb_byte *) xmalloc (MAX_REGISTER_SIZE * = regnum); > - for (i =3D 0; i < regnum; i ++) > - regcache_raw_collect (regcache, i, > - record_full_core_regbuf + MAX_REGISTER_SIZE * i); > + record_full_core_regcache =3D regcache_dup (regcache); >=20 > /* Get record_full_core_start and record_full_core_end. */ > if (build_section_table (core_bfd, &record_full_core_start, > &record_full_core_end)) > { > - xfree (record_full_core_regbuf); > - record_full_core_regbuf =3D NULL; > + regcache_xfree (record_full_core_regcache); > + record_full_core_regcache =3D NULL; > error (_("\"%s\": Can't find sections: %s"), > bfd_get_filename (core_bfd), bfd_errmsg (bfd_get_error ())); > } > @@ -886,11 +881,11 @@ record_full_close (struct target_ops *self) >=20 > record_full_list_release (record_full_list); >=20 > - /* Release record_full_core_regbuf. */ > - if (record_full_core_regbuf) > + /* Release record_full_core_regcache. */ > + if (record_full_core_regcache) > { > - xfree (record_full_core_regbuf); > - record_full_core_regbuf =3D NULL; > + regcache_xfree (record_full_core_regcache); > + record_full_core_regcache =3D NULL; > } >=20 > /* Release record_full_core_buf_list. */ > @@ -2051,15 +2046,12 @@ record_full_core_fetch_registers (struct target_o= ps *ops, > if (regno < 0) > { > int num =3D gdbarch_num_regs (get_regcache_arch (regcache)); > - int i; >=20 > - for (i =3D 0; i < num; i ++) > - regcache_raw_supply (regcache, i, > - record_full_core_regbuf + MAX_REGISTER_SIZE= * i); > + for (int i =3D 0; i < num; i ++) > + regcache->raw_copy (i, record_full_core_regcache); > } > else > - regcache_raw_supply (regcache, regno, > - record_full_core_regbuf + MAX_REGISTER_SIZE * r= egno); > + regcache->raw_copy (regno, record_full_core_regcache); > } >=20 > /* "to_prepare_to_store" method for prec over corefile. */ > @@ -2078,8 +2070,7 @@ record_full_core_store_registers (struct target_ops= *ops, > int regno) > { > if (record_full_gdb_operation_disable) > - regcache_raw_collect (regcache, regno, > - record_full_core_regbuf + MAX_REGISTER_SIZE * = regno); > + record_full_core_regcache->raw_copy (regno, regcache); > else > error (_("You can't do that without a process to debug.")); > } > diff --git a/gdb/regcache.h b/gdb/regcache.h > index 00b729d9af1b9d9823fc84fb424047c2b918ec8d..24257d8eafd4f7168b622a48e= c1e646b9027153e 100644 > --- a/gdb/regcache.h > +++ b/gdb/regcache.h > @@ -324,6 +324,8 @@ public: >=20 > void raw_supply_zeroed (int regnum); >=20 > + void raw_copy (int regnum, const struct regcache *src_regcache); > + > enum register_status get_register_status (int regnum) const; >=20 > void raw_set_cached_value (int regnum, const gdb_byte *buf); > @@ -402,8 +404,8 @@ private: > /* Is this a read-only cache? A read-only cache is used for saving > the target's register state (e.g, across an inferior function > call or just before forcing a function return). A read-only > - cache can only be updated via the methods regcache_dup() and > - regcache_cpy(). The actual contents are determined by the > + cache can only be updated via the methods regcache_dup (), regcache= _cpy () > + and regcache::raw_copy (). The actual contents are determined by t= he > reggroup_save and reggroup_restore methods. */ > bool m_readonly_p; > /* If this is a read-write cache, which thread's registers is > diff --git a/gdb/regcache.c b/gdb/regcache.c > index 4e8c1ee0e648fd17ce2a120c61ecd495ff2e2467..54454e3f039ff5d6ab436cd9e= 0f1da607476ce32 100644 > --- a/gdb/regcache.c > +++ b/gdb/regcache.c > @@ -1256,6 +1256,20 @@ regcache::raw_collect (int regnum, void *buf) const > memcpy (buf, regbuf, size); > } >=20 > +/* Collect register REGNUM from SRC_REGCACHE and store its contents in > + REGCACHE. Regcaches must have matching gdbarches. */ > + > +void > +regcache::raw_copy (int regnum, const struct regcache *src_regcache) > +{ > + gdb_assert (src_regcache !=3D NULL); > + gdb_assert (regnum >=3D 0 && regnum < m_descr->nr_raw_registers); > + gdb_assert (m_descr->gdbarch =3D=3D src_regcache->m_descr->gdbarch); > + > + src_regcache->raw_collect (regnum, register_buffer (regnum)); > + m_register_status[regnum] =3D src_regcache->m_register_status[regnum]; > +} > + > /* Transfer a single or all registers belonging to a certain register > set to or from a buffer. This is the main worker function for > regcache_supply_regset and regcache_collect_regset. */ >=20