From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75113 invoked by alias); 21 Mar 2016 21:02:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 75095 invoked by uid 89); 21 Mar 2016 21:02:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=grammar, UD:y, propagating, switched X-HELO: mail-lb0-f193.google.com Received: from mail-lb0-f193.google.com (HELO mail-lb0-f193.google.com) (209.85.217.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 21 Mar 2016 21:02:14 +0000 Received: by mail-lb0-f193.google.com with SMTP id sx8so7292581lbb.3 for ; Mon, 21 Mar 2016 14:02:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=Euc+hxAWrrVeyEu34vgL7+u+PrTRv0ec3MvZT1fhP9Q=; b=kigbFKM6QTCimBIiiOIQe3vmK28Cq2TAuTs1TiDg5TLvFD/1LnhuamGM0lYqr6lxRn 7bo2/yk/gM32VNTuPuUSeEcl9nZH9S+Sk/4XLKWDi5ql10rwRmXJBQbalqucohyDDKSY u1z8Fi99K6rOrVGzPUa94O8vAkqhKeNKYRlQSk5jhNizdiywgjGFWZnbO91l/9SvuS6H PPAA54+/WolU5ewdFyjZGbUaKXgme1HNYSF8BMHNhDpEOqMD0gKqRcyib5WleuP0PxqW A9OzwuZU2qLdsgxFLWv5n5gQdRKx8o07p0xtOhTdRNt7HMsoVG1pOyKWNyEjg9ooqXFF wghQ== X-Gm-Message-State: AD7BkJLtewD76LrrsdsBEV40knJYNAJIIdY7GhNmJhZY/VBSHuxtWy2h0tZoilpGtVq7NQ== X-Received: by 10.112.125.9 with SMTP id mm9mr9463383lbb.113.1458594131343; Mon, 21 Mar 2016 14:02:11 -0700 (PDT) Received: from arch.smware.local (broadband-90-154-70-182.nationalcablenetworks.ru. [90.154.70.182]) by smtp.gmail.com with ESMTPSA id 40sm4730939lfp.41.2016.03.21.14.02.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 21 Mar 2016 14:02:10 -0700 (PDT) From: Artemiy Volkov To: gdb-patches@sourceware.org Cc: keiths@redhat.com, palves@redhat.com, Artemiy Volkov Subject: [PATCH v4 00/11] [PR gdb/14441] Support C++0x rvalue references in gdb Date: Mon, 21 Mar 2016 21:02:00 -0000 Message-Id: <1458593958-25656-1-git-send-email-artemiyv@acm.org> In-Reply-To: <1457147955-21871-1-git-send-email-artemiyv@acm.org> References: <1457147955-21871-1-git-send-email-artemiyv@acm.org> X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg00433.txt.bz2 Hi all, this is my fourth take on fixing gdb/14441 which deals with C++0x rvalue references. The approach is rather straightforward and the work for the most part consisted of mimicking the behavior for regular references. In gdbtypes.c, several helper functions were introduced and some parameterized by the reference kind to simplify the access to reference type objects API. The only interesting part is the addition of overloading resolution rules with regard to rvalue references. All of the cases introduced in 13.3.3.1.4 and 13.3.3.2 were accounted for at the beginning of rank_one_type(). With this patch it is now also possible to fix the evaluation of decltype, which should return a plain type object, an lvalue reference or an rvalue reference depending on a type category of the type of its operand. However, this would require introduction of the type category notion to gdb, which I think only needs adding a new constant to lval_type and propagating the type category through different parts of an expression in gdb/valops.c. I'm willing to do this if this patchset turns out to be OK. Changes from v1 consist of dropping the libiberty part of 05/11 and the consequent testsuite changes. I have learned that introducing rvalue reference support to the demangler in cplus-dem.c is completely unnecessary, since virtually all contemporary compilers generate symbol names handled in cp-demangle.c. Therefore I have removed some of the testcases in gdb.cp/demangle.exp and switched the others to use the gnu-v3 demangling style. Changes from v2 are numerous coding style fixes, improvements and simplifications of the changelog, reorganization and reordering of the patchset, removal of redundant code in gdb/python/*, addition of a couple of python tests, and a few bugfixes. Changes from v3 are a few more coding style / English grammar fixes and code simplifications left over from v2. Artemiy Volkov (11): gdb: gdbtypes: add definitions for rvalue reference type gdb: gdbtypes: change {lookup,make}_reference_type() API gdb: valops: add ability to return rvalue reference values from value_ref() gdb: parse: support rvalue reference type gdb: demangle: implement demangling for rvalue reference typenames gdb: print: implement correct printing of rvalue reference types and values gdb: dwarf2read: support DW_TAG_rvalue_reference type gdb: python: support rvalue references in the gdb module gdb: convert lvalue reference type check to general reference type check gdb: gdbtypes: add rvalue references to overloading resolution gdb: testsuite: add rvalue reference tests gdb/aarch64-tdep.c | 5 +- gdb/ada-lang.c | 2 +- gdb/amd64-tdep.c | 2 +- gdb/amd64-windows-tdep.c | 1 + gdb/arm-tdep.c | 5 +- gdb/ax-gdb.c | 2 + gdb/c-exp.y | 6 +- gdb/c-typeprint.c | 10 +-- gdb/c-valprint.c | 14 +++-- gdb/c-varobj.c | 10 +-- gdb/compile/compile-c-symbols.c | 2 +- gdb/completer.c | 3 +- gdb/cp-name-parser.y | 4 ++ gdb/cp-support.c | 3 +- gdb/darwin-nat-info.c | 2 +- gdb/dwarf2loc.c | 4 +- gdb/dwarf2read.c | 15 +++-- gdb/eval.c | 16 ++--- gdb/f-exp.y | 2 +- gdb/findvar.c | 6 +- gdb/gdbtypes.c | 105 ++++++++++++++++++++++++++----- gdb/gdbtypes.h | 20 +++++- gdb/guile/scm-type.c | 2 +- gdb/guile/scm-value.c | 2 +- gdb/hppa-tdep.c | 1 + gdb/infcall.c | 5 +- gdb/language.c | 3 +- gdb/m32c-tdep.c | 8 +-- gdb/m88k-tdep.c | 1 + gdb/mn10300-tdep.c | 1 + gdb/msp430-tdep.c | 2 +- gdb/parse.c | 39 +++++++----- gdb/parser-defs.h | 1 + gdb/ppc-sysv-tdep.c | 7 +-- gdb/printcmd.c | 2 +- gdb/python/lib/gdb/command/explore.py | 2 +- gdb/python/lib/gdb/types.py | 4 +- gdb/python/py-type.c | 14 +++-- gdb/python/py-value.c | 16 +++-- gdb/python/py-xmethods.c | 12 ++-- gdb/s390-linux-tdep.c | 2 +- gdb/sparc-tdep.c | 1 + gdb/sparc64-tdep.c | 1 + gdb/spu-tdep.c | 1 + gdb/stabsread.c | 3 +- gdb/symtab.c | 3 +- gdb/testsuite/gdb.cp/casts.cc | 8 ++- gdb/testsuite/gdb.cp/casts.exp | 35 +++++++++-- gdb/testsuite/gdb.cp/cpsizeof.cc | 4 ++ gdb/testsuite/gdb.cp/cpsizeof.exp | 3 +- gdb/testsuite/gdb.cp/demangle.exp | 36 +++++++++++ gdb/testsuite/gdb.cp/overload.cc | 18 +++++- gdb/testsuite/gdb.cp/overload.exp | 16 ++++- gdb/testsuite/gdb.cp/ref-params.cc | 27 ++++++++ gdb/testsuite/gdb.cp/ref-params.exp | 21 ++++++- gdb/testsuite/gdb.cp/ref-types.cc | 24 +++++++ gdb/testsuite/gdb.cp/ref-types.exp | 92 ++++++++++++++++++++++++++- gdb/testsuite/gdb.python/py-value-cc.cc | 4 ++ gdb/testsuite/gdb.python/py-value-cc.exp | 10 ++- gdb/typeprint.c | 4 +- gdb/valarith.c | 6 +- gdb/valops.c | 72 +++++++++++---------- gdb/valprint.c | 5 +- gdb/value.c | 12 ++-- gdb/value.h | 2 +- gdb/varobj.c | 2 +- 66 files changed, 593 insertions(+), 180 deletions(-) -- 2.7.3