From: Kieran Bingham <kieran.bingham@linaro.org>
To: gdb-patches@sourceware.org
Cc: arnez@linux.vnet.ibm.com, jeffm@suse.com,
peter.griffin@linaro.org, lee.jones@linaro.org,
yao.qi@linaro.org, russell.wayman@linaro.org, kernel@stlinux.com,
Kieran Bingham <kieran.bingham@linaro.org>
Subject: [PATCH] squash! gdb/lkd: Add Linux Kernel Awareness target
Date: Fri, 26 Feb 2016 11:02:00 -0000 [thread overview]
Message-ID: <1456484561-16109-1-git-send-email-kieran.bingham@linaro.org> (raw)
In-Reply-To: <1456427706-30077-4-git-send-email-kieran.bingham@linaro.org>
Apologies for the rookie-mistake here:
Remove unused mmu_info structure from lkd-process
I can't believe I let this slip. I was sure I tested this build before
sending this patchset, but here it is. It fails to build from clean.
I clearly missed these two lines from my aggressive code chopping
Tag updated to include this commit for anyone who actually looks to try
this functionality out.
---
gdb/lkd/lkd-process.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/gdb/lkd/lkd-process.c b/gdb/lkd/lkd-process.c
index 5f791da9e5e2..ac80141a1d97 100644
--- a/gdb/lkd/lkd-process.c
+++ b/gdb/lkd/lkd-process.c
@@ -109,8 +109,6 @@ CORE_ADDR rq_idle[MAX_CORES]; /*rq->idle */
static int process_counts[MAX_CORES];
static int last_pid;
-struct mmu_infos mmu_info[MAX_CORES];
-
static int
find_thread_lwp (struct thread_info *tp, void *arg)
@@ -715,7 +713,6 @@ lkd_proc_init (void)
struct cleanup *cleanup;
memset (per_cpu_offset, 0, MAX_CORES * sizeof (uint32_t));
- memset (mmu_info, 0, MAX_CORES * sizeof (struct mmu_infos));
/* ensure thread list from beneath target is up to date */
cleanup = make_cleanup_restore_integer (&print_thread_events);
--
2.5.0
next prev parent reply other threads:[~2016-02-26 11:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 19:15 [RFC PATCH 0/4] GDB Linux Kernel Thread Awareness Kieran Bingham
2016-02-25 19:15 ` [PATCH 1/4] gdb/observer: Provide target_thread_changed observer Kieran Bingham
2016-03-01 16:41 ` Yao Qi
2016-02-25 19:15 ` [PATCH 3/4] gdb/lkd: Add Linux Kernel Awareness target Kieran Bingham
2016-02-26 11:02 ` Kieran Bingham [this message]
2016-03-01 17:27 ` Yao Qi
2016-03-01 17:37 ` Kieran Bingham
2016-02-25 19:15 ` [PATCH 2/4] gdb/command: Add LKD Command class Kieran Bingham
2016-02-25 19:15 ` [PATCH 4/4] lkd: Add an Architecture Layer for ARMv7 targets Kieran Bingham
2016-02-25 20:04 ` [RFC PATCH 0/4] GDB Linux Kernel Thread Awareness Jeff Mahoney
2016-02-29 9:42 ` Kieran Bingham
2016-03-01 16:33 ` Yao Qi
2016-03-02 15:38 ` Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456484561-16109-1-git-send-email-kieran.bingham@linaro.org \
--to=kieran.bingham@linaro.org \
--cc=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=jeffm@suse.com \
--cc=kernel@stlinux.com \
--cc=lee.jones@linaro.org \
--cc=peter.griffin@linaro.org \
--cc=russell.wayman@linaro.org \
--cc=yao.qi@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox