From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41457 invoked by alias); 22 Feb 2016 16:53:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 41382 invoked by uid 89); 22 Feb 2016 16:53:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=HX-Received:10.66.101.2, Format X-HELO: mail-pa0-f47.google.com Received: from mail-pa0-f47.google.com (HELO mail-pa0-f47.google.com) (209.85.220.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 22 Feb 2016 16:53:31 +0000 Received: by mail-pa0-f47.google.com with SMTP id ho8so96341365pac.2 for ; Mon, 22 Feb 2016 08:53:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=53839vD67eP0UtCA/3ktaLE+DwYDnoiggUhCCSN4dag=; b=MtijlwdS8Ge0VVu3m6gqdHiz0vwFl0wSiRn5U3zSMl/m4ZUzIV25H6iaP7SQSJHbn/ XwyuON3aD8w4Pv848ItjTLQEuuWRbyTfkJMjtPDzby1NyxH3jKHjewHU9wTt4eyBea5B F+ArPpnwu/lOJGr51j0y3ms4Ak8giJUkM9+1+UhI510Mn+6ssgOgGkLv9iL7FGNFOaJg YHFNbSk2QNRU4q/RSIPQHiGb0rlRS6TTKd7FNTdv2WP79TD8EU026YLOWovpoT9YKkCq aPQJCeSiBkhn4ZsfpJ7w71+IGihVLvU5niUSAuqVrmxgqs7Q2klbpVufIpXerU3rirB3 k/Mw== X-Gm-Message-State: AG10YOQH4etXe0qevghP+rMAkwhoJugCjSmGwSNwG8ofwCjXCBbqEfGMo5Ys6UOsxzIOHA== X-Received: by 10.66.101.2 with SMTP id fc2mr39470978pab.96.1456160009865; Mon, 22 Feb 2016 08:53:29 -0800 (PST) Received: from E107787-LIN.cambridge.arm.com (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id f12sm38059764pfd.87.2016.02.22.08.53.28 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 22 Feb 2016 08:53:28 -0800 (PST) From: Yao Qi X-Google-Original-From: Yao Qi To: gdb-patches@sourceware.org Subject: [PATCH 2/3] Record right reg num of thumb special data instructions Date: Mon, 22 Feb 2016 16:53:00 -0000 Message-Id: <1456159999-5644-3-git-send-email-yao.qi@linaro.org> In-Reply-To: <1456159999-5644-1-git-send-email-yao.qi@linaro.org> References: <1456159999-5644-1-git-send-email-yao.qi@linaro.org> X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00663.txt.bz2 When GDB decodes these thumb special data instructions, such as 'mov sp, r7' the Rd is got incorrectly. According to the arch reference manual, the Rd is DN:Rdn, in which DN is bit 7 and Rdn is bits 0 to 2. This patch fixes it. gdb: 2016-02-22 Yao Qi * arm-tdep.c (thumb_record_ld_st_reg_offset): Fix the register number of Rd. --- gdb/arm-tdep.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c index 1a3a209..0c0e1a5 100644 --- a/gdb/arm-tdep.c +++ b/gdb/arm-tdep.c @@ -11512,10 +11512,10 @@ thumb_record_ld_st_reg_offset (insn_decode_record *thumb_insn_r) } else { - /* Format 8; special data processing insns. */ - reg_src1 = bits (thumb_insn_r->arm_insn, 0, 2); - record_buf[0] = ARM_PS_REGNUM; - record_buf[1] = reg_src1; + /* Format 8; special data processing insns. */ + record_buf[0] = ARM_PS_REGNUM; + record_buf[1] = (bit (thumb_insn_r->arm_insn, 7) << 3 + | bits (thumb_insn_r->arm_insn, 0, 2)); thumb_insn_r->reg_rec_count = 2; } } -- 1.9.1