From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29831 invoked by alias); 2 Aug 2012 12:53:27 -0000 Received: (qmail 29815 invoked by uid 22791); 2 Aug 2012 12:53:25 -0000 X-SWARE-Spam-Status: No, hits=-4.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 02 Aug 2012 12:53:09 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1Swutn-0004wq-Ri from Yao_Qi@mentor.com ; Thu, 02 Aug 2012 05:53:07 -0700 Received: from SVR-ORW-FEM-05.mgc.mentorg.com ([147.34.97.43]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 2 Aug 2012 05:53:07 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.1.289.1; Thu, 2 Aug 2012 05:53:06 -0700 From: Yao Qi To: CC: Doug Evans Subject: Re: [PATCH 1/3] var_zuinteger_unlimited and 'set listsize'. Date: Thu, 02 Aug 2012 12:53:00 -0000 Message-ID: <1454959.szXUfGOlOT@qiyao.dyndns.org> User-Agent: KMail/4.8.3 (Linux/3.3.7-1.fc16.i686; KDE/4.8.3; i686; ; ) In-Reply-To: References: <7A6A55B4-0293-4AD6-AB1F-B3169F8ADCC1@cs.umd.edu> <1343829334-3151-2-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00064.txt.bz2 On Thursday, August 02, 2012 01:33:58 AM Doug Evans wrote: > Nit: The changelog entry for source.c should mention "listsize". And > the entry for do_setshow_command should also mention that it fixes the > setting of var_integer and var_zinteger to allow negative values. >=20 Thanks, I'll fix changelog entries. > Things are quite a mess, aren't they. > Adding yet another var_foo doesn't appeal to me, but we can't break > anything and being able to set both "0" and "unlimited" (expressed > however) would be nice. >=20 Agreed. > Is there any real use-case that wants to be able to set negative > values and have "0" mean unlimited? It's never (until this patch) > been the case that one can set negative values to var_integer. Can we > remove (or at least deprecate) var_integer? [we'd switch all existing > uses to var_uinteger, the only remaining use would be the Python API] Yes, I was inclined to switch *all* var_integer to var_uinteger, and it is= =20 still ongoing. It is independent of this patch series, but my 'command opt= ion=20 changes notification' patches reply on this series, so I hope this series c= an=20 go in at first. >=20 > btw, you also might want to update python/py-param.c. > Though py-param.c also doesn't handle var_zuinteger, and I don't mind > not extending the Python API until we know we want to. I'll look at python stuff in next step. --=20 Yao (=E9=BD=90=E5=B0=A7)