From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27605 invoked by alias); 6 Feb 2016 15:47:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27593 invoked by uid 89); 6 Feb 2016 15:47:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1273, resulted, 2016-02-06, HContent-Transfer-Encoding:8bit X-HELO: xyzzy.0x04.net Received: from xyzzy.0x04.net (HELO xyzzy.0x04.net) (109.74.193.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 06 Feb 2016 15:47:21 +0000 Received: from hogfather.0x04.net (89-65-66-135.dynamic.chello.pl [89.65.66.135]) by xyzzy.0x04.net (Postfix) with ESMTPS id 9CF3940CA4 for ; Sat, 6 Feb 2016 16:40:09 +0100 (CET) Received: by hogfather.0x04.net (Postfix, from userid 1000) id F112F5800D4; Sat, 6 Feb 2016 16:39:20 +0100 (CET) From: =?UTF-8?q?Marcin=20Ko=C5=9Bcielnicki?= To: gdb-patches@sourceware.org Cc: =?UTF-8?q?Marcin=20Ko=C5=9Bcielnicki?= Subject: [PATCH 4/4] gdb.trace: Fix off-by-one in tfile_fetch_registers. Date: Sat, 06 Feb 2016 15:47:00 -0000 Message-Id: <1454773157-31569-5-git-send-email-koriakin@0x04.net> In-Reply-To: <1454773157-31569-1-git-send-email-koriakin@0x04.net> References: <1454773157-31569-1-git-send-email-koriakin@0x04.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00165.txt.bz2 This resulted in the last register being considered unavailable. On plain x86_64 (without AVX), this happened to be orig_rax. gdb/ChangeLog: * tracefile-tfile.c (tfile_fetch_registers): Fix off-by-one in bounds check. --- gdb/ChangeLog | 5 +++++ gdb/tracefile-tfile.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 5afdb60..339f2d0 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,10 @@ 2016-02-06 Marcin Kościelnicki + * tracefile-tfile.c (tfile_fetch_registers): Fix off-by-one in bounds + check. + +2016-02-06 Marcin Kościelnicki + * tracefile-tfile.c (tfile_fetch_registers): Use g packet order instead of gdb order. diff --git a/gdb/tracefile-tfile.c b/gdb/tracefile-tfile.c index 23d78c3..a6c3c9c 100644 --- a/gdb/tracefile-tfile.c +++ b/gdb/tracefile-tfile.c @@ -879,7 +879,7 @@ tfile_fetch_registers (struct target_ops *ops, regsize = register_size (gdbarch, regn); /* Make sure we stay within block bounds. */ - if (offset + regsize >= trace_regblock_size) + if (offset + regsize > trace_regblock_size) break; if (regcache_register_status (regcache, regn) == REG_UNKNOWN) { -- 2.7.0