From: "Marcin Kościelnicki" <koriakin@0x04.net>
To: gdb-patches@sourceware.org
Cc: "Marcin Kościelnicki" <koriakin@0x04.net>
Subject: [PATCH] gdb.trace/testsuite: Bump stack collection fudge factor.
Date: Sat, 23 Jan 2016 14:49:00 -0000 [thread overview]
Message-ID: <1453560587-30161-1-git-send-email-koriakin@0x04.net> (raw)
These two tests collect 64 words from $sp onwards, hoping that's enough
to capture a few whole stack frames. Unfortunately, that's not enough
for s390, which tends to have large frame sizes - minimum 24 words on
s390, 20 on s390x (which just barely passes). Bump it to 128 words,
let's hope no machine needs more.
Tested on x86_64, s390, s390x.
gdb/testsuite/ChangeLog:
* gdb.trace/backtrace.exp: Bump stack collection fudge factor.
* gdb.trace/entry-values.exp: Bump stack collection fudge factor.
---
gdb/testsuite/ChangeLog | 5 +++++
gdb/testsuite/gdb.trace/backtrace.exp | 2 +-
gdb/testsuite/gdb.trace/entry-values.exp | 2 +-
3 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 8ee2efa..a201b66 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,5 +1,10 @@
2016-01-23 Marcin KoÅcielnicki <koriakin@0x04.net>
+ * gdb.trace/backtrace.exp: Bump stack collection fudge factor.
+ * gdb.trace/entry-values.exp: Bump stack collection fudge factor.
+
+2016-01-23 Marcin KoÅcielnicki <koriakin@0x04.net>
+
* gdb.trace/unavailable-dwarf-piece.exp: Fix bitfield handling on big
endian targets.
diff --git a/gdb/testsuite/gdb.trace/backtrace.exp b/gdb/testsuite/gdb.trace/backtrace.exp
index ad18f15..881a798 100644
--- a/gdb/testsuite/gdb.trace/backtrace.exp
+++ b/gdb/testsuite/gdb.trace/backtrace.exp
@@ -142,7 +142,7 @@ gdb_trace_setactions "8.6: setup TP to collect regs, args, and locals" \
gdb_trace_setactions "8.6: setup TP to collect stack mem cast expr" \
"$tdp6" \
- "collect \$$fpreg, \(\*\(void \*\*\) \(\$$spreg\)\) @ 64" "^$"
+ "collect \$$fpreg, \(\*\(void \*\*\) \(\$$spreg\)\) @ 128" "^$"
gdb_test_no_output "tstart" ""
diff --git a/gdb/testsuite/gdb.trace/entry-values.exp b/gdb/testsuite/gdb.trace/entry-values.exp
index 7f60b8c..825928d 100644
--- a/gdb/testsuite/gdb.trace/entry-values.exp
+++ b/gdb/testsuite/gdb.trace/entry-values.exp
@@ -219,7 +219,7 @@ gdb_test "trace foo" "Tracepoint $decimal at .*"
# argument j.
gdb_trace_setactions "set action for tracepoint 1" "" \
- "collect i, j, global1, \(\*\(void \*\*\) \(\$$spreg\)\) @ 64" "^$"
+ "collect i, j, global1, \(\*\(void \*\*\) \(\$$spreg\)\) @ 128" "^$"
gdb_test_no_output "tstart"
--
2.7.0
next reply other threads:[~2016-01-23 14:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-23 14:49 Marcin Kościelnicki [this message]
2016-01-25 11:56 ` Pedro Alves
2016-01-25 12:20 ` Marcin Kościelnicki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453560587-30161-1-git-send-email-koriakin@0x04.net \
--to=koriakin@0x04.net \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox