From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125760 invoked by alias); 18 Jan 2016 22:52:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 125712 invoked by uid 89); 18 Jan 2016 22:52:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=Hx-languages-length:1567, 1937 X-HELO: usplmg21.ericsson.net Received: from usplmg21.ericsson.net (HELO usplmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 18 Jan 2016 22:52:46 +0000 Received: from EUSAAHC008.ericsson.se (Unknown_Domain [147.117.188.96]) by usplmg21.ericsson.net (Symantec Mail Security) with SMTP id 90.7F.32102.CAC6D965; Mon, 18 Jan 2016 23:52:28 +0100 (CET) Received: from elxcz23q12-y4.dyn.mo.ca.am.ericsson.se (147.117.188.8) by smtps-am.internal.ericsson.com (147.117.188.96) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 18 Jan 2016 17:52:43 -0500 From: Simon Marchi To: CC: Simon Marchi Subject: [PATCH] testsuite: Add --status to runtest invocation Date: Mon, 18 Jan 2016 22:52:00 -0000 Message-ID: <1453157560-7080-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg00406.txt.bz2 As discussed in this thread: https://sourceware.org/ml/gdb-patches/2016-01/msg00243.html By default, if a test driver (a test .exp) ends with an uncaught error/exception, the runtest command will still have a return code of 0 (success). I think that if a test (or the environment) is broken and the test ends up with an exception, it should be considered as failed so that we can notice it and fix it. Passing the --status flag to runtest will make it return an error if one of the test it runs ends up with an uncaught error. gdb/testsuite/ChangeLog: * Makefile.in (check-single): Pass --status to runtest. (check/%.exp): Likewise. --- gdb/testsuite/Makefile.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/Makefile.in b/gdb/testsuite/Makefile.in index fb0d8e5..ae7fa7b 100644 --- a/gdb/testsuite/Makefile.in +++ b/gdb/testsuite/Makefile.in @@ -193,7 +193,7 @@ DO_RUNTEST = \ @GMAKE_TRUE@ $(MAKE) check TESTS="gdb.$*/*.exp" check-single: - $(DO_RUNTEST) $(RUNTESTFLAGS) $(expanded_tests_or_none) + $(DO_RUNTEST) --status $(RUNTESTFLAGS) $(expanded_tests_or_none) check-parallel: -rm -rf cache outputs temp @@ -227,7 +227,7 @@ do-check-parallel: $(TEST_TARGETS) @GMAKE_TRUE@check/%.exp: @GMAKE_TRUE@ -mkdir -p outputs/$* -@GMAKE_TRUE@ @$(DO_RUNTEST) GDB_PARALLEL=yes --outdir=outputs/$* $*.exp $(RUNTESTFLAGS) +@GMAKE_TRUE@ @$(DO_RUNTEST) GDB_PARALLEL=yes --outdir=outputs/$* $*.exp --status $(RUNTESTFLAGS) check/no-matching-tests-found: @echo "" -- 2.5.1