Re: [PATCH v2 4/6] Use LWP IDs with ptrace register requests on FreeBSD.

John Baldwin
2016-01-15T20:23:12Z

On Thursday, January 14, 2016 03:07:28 PM Pedro Alves wrote:
> [Dropping binutils.]
>
> On 01/13/2016 09:45 PM, John Baldwin wrote:
> > This allows gdb to fetch per-thread registers for multi-threaded FreeBSD
> > processes. NetBSD and OpenBSD also accept LWP IDs for ptrace requests
> > to fetch per-thread state.
>
> I'd prefer to make inf-ptrace.c:get_ptrace_pid extern and use
> it, instead of duplicating it multiple times.

This sounds good to me. Do you want me to use it in other places as well?
sparc-nat.c at least duplicates the same logic inline. amd64linux-nat.c
does as well. If so, would you rather that be a seperate patch (expose
get_ptrace_pid() and use it in existing targets) from this patch?

--
John Baldwin