From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75311 invoked by alias); 12 Jan 2016 21:47:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 75302 invoked by uid 89); 12 Jan 2016 21:47:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=H*M:126 X-HELO: mailapp01.imgtec.com Received: from mailapp01.imgtec.com (HELO mailapp01.imgtec.com) (195.59.15.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Jan 2016 21:47:34 +0000 Received: from HHMAIL01.hh.imgtec.org (unknown [10.100.10.19]) by Websense Email Security Gateway with ESMTPS id 96459130EBB9E; Tue, 12 Jan 2016 21:47:28 +0000 (GMT) Received: from BAMAIL02.ba.imgtec.org (10.20.40.28) by HHMAIL01.hh.imgtec.org (10.100.10.19) with Microsoft SMTP Server (TLS) id 14.3.235.1; Tue, 12 Jan 2016 21:47:32 +0000 Received: from [10.20.3.214] (10.20.3.214) by bamail02.ba.imgtec.org (10.20.40.28) with Microsoft SMTP Server (TLS) id 14.3.174.1; Tue, 12 Jan 2016 13:47:30 -0800 Message-ID: <1452635249.29343.126.camel@ubuntu-sellcey> Subject: Re: [PATCH] sim: allow the inline configure option everywhere [committed] From: Steve Ellcey Reply-To: To: Mike Frysinger CC: Date: Tue, 12 Jan 2016 21:47:00 -0000 In-Reply-To: <1452415259-1212-1-git-send-email-vapier@gentoo.org> References: <1452415259-1212-1-git-send-email-vapier@gentoo.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-SW-Source: 2016-01/txt/msg00241.txt.bz2 On Sun, 2016-01-10 at 03:40 -0500, Mike Frysinger wrote: > Currently ports have to call SIM_AC_OPTION_INLINE explicitly in order > to make the configure flag available. There's no real reason to not > allow this flag for all ports, so move it to the common sim macro. > This way we get standard behavior across all ports too. > > diff --git a/sim/aarch64/ChangeLog b/sim/aarch64/ChangeLog > index ebae1cd..19d49fb 100644 > --- a/sim/aarch64/ChangeLog > +++ b/sim/aarch64/ChangeLog > @@ -1,5 +1,10 @@ > 2016-01-10 Mike Frysinger > > + * configure.ac (SIM_AC_OPTION_INLINE): Delete call. > + * configure: Regenerate. > + > +2016-01-10 Mike Frysinger > + Before this patch was checked in (commit 347fe5bb868b7383d4f6942894b31ecf1da6894e), when I built all-gdb for the target mips-mti-linux-gnu, sim was not built. After the change, it does get built (well, it tries to get built, it actually fails to build). I am not sure if this change in behavior, trying to build sim, is intended or not. I can fix it easily enough by using --disable-sim on my configure but I just wanted to check to see if this change was intentional. I have never built sim for this target before because I use qemu for testing it. I only use GNU sim for testing the mips*elf targets. Steve Ellcey sellcey@imgtec.com