Re: [PATCH v8 3/7] Refactor arm_software_single_step to use regcache

Antoine Tremblay
2016-01-18T14:02:38Z

On 01/18/2016 08:07 AM, Yao Qi wrote:
> Yao Qi <qiyaoltc@gmail.com> writes:
>
>> As a record, this patch causes regressions at least in
>> gdb.base/sigstep.exp,
>>
>> (gdb) PASS: gdb.base/sigstep.exp: continue to handler, si+advance in
>> handler, step from handler: advance in handler
>> step^M
>> 39 } /* handler */^M
>> 1: x/i $pc^M
>> => 0x8740 <handler+80>: sub sp, r11, #0^M
>> (gdb) step^M
>> ^M
>> Program received signal SIGSEGV, Segmentation fault.^M
>> setitimer () at ../sysdeps/unix/syscall-template.S:81^M
>> 81 ../sysdeps/unix/syscall-template.S: No such file or directory.^M
>> 1: x/i $pc^M
>> => 0xb6eff9c0 <setitimer>: push {r7}^M
>> (gdb) FAIL: gdb.base/sigstep.exp: continue to handler, si+advance in
>> handler, step from handler: leave handler
>>
>> Could you take a look at it?
>
> Here is my patch fixing the regression in sigstep.exp. The regression
> test is running now.
>

You've beat me to it, thanks for the fix !

Patch LGTM.

Regards,
Antoine