Re: [PATCH v8 0/7] Support software single step and conditional breakpoints on ARM in GDBServer.

Antoine Tremblay
2015-12-18T16:45:56Z

On 12/17/2015 09:14 AM, Antoine Tremblay wrote:
> In this v8:
>
> * Remove old patch 3.
> * Patch 3: Use #define ARM_SIGRETURN, ARM_RT_SIGRETURN
> * Other small style fixes highlighted in v7.
>
> Patch 1: is OK.
> Patch 2: is OK.
> Patch 3: Needs review ?
> Patch 4: is OK.
> Patch 5: is OK>
> Patch 6: is OK.
> Patch 7: is OK.
>
> ---
>
> This patch series adds support for software single step and conditional
> breakpoints on ARM in GDBServer.
>
> Patches 1,2,3,4 prepares for sharing of software single step code for ARM in
> GDB with GDBServer.
>
> Patch 5 Implements the support for ARM software single step.
>
> Patch 6 Adds support for while-stepping actions.
>
> Patch 7 Adds support for conditional breakpoints in GDBServer.
>
> This patch set has no observed regressions, tested on Ubuntu 14.04 ARMv7
> and x86. With gdbserver-{native,extended} / { -marm -mthumb }
>
> Note also that while I could not test thumbv1 instructions directly with
> gcc -marmv4t, manual testing of the software single step was done for
> thumv1 instructions.
>

This is now pushed in.

Thanks to Yao and Pedro for all the reviews!!

Happy holidays!

Regards,
Antoine