Re: [PATCH v7 3/8] Use xml-syscall to compare syscall numbers in arm_linux_sigreturn_return-addr.

Pedro Alves
2015-12-16T15:59:55Z

On 12/15/2015 12:46 PM, Antoine Tremblay wrote:
>
>
> On 12/11/2015 07:31 AM, Antoine Tremblay wrote:
>>
>>
>> On 12/11/2015 07:05 AM, Pedro Alves wrote:
>>> On 12/11/2015 12:02 PM, Yao Qi wrote:
>>>> On 11/12/15 11:59, Pedro Alves wrote:
>>>>> but then you might as well just do:
>>>>>
>>>>> #define ARM_SIGRETURN 119
>>>>
>>>> How about using __NR_sigreturn and __NR_rt_sigreturn directly? like
>>>> what patch #6 does.
>>>
>>> Those are host/native macros. Only make sense for the running host.
>>> Can't use that in a tdep file, like arm-linux-tdep.c. Otherwise, e.g.,
>>> a x86-hosted cross debugger would be using the x86 __NR_sigreturn, etc.
>>>
>>
>> Exactly that's why I use those only in GDBServer.
>>
>> Personally while I like the #define ARM_SIGRETURN 119 better, I think
>> the xml function is fine.
>
> Any news about this one ?
>
> Given that I use xml in GDB and __NR_sigreturn macros in GDBServer...
>
> Is the patch OK ?

I'd rather leave the final call to Yao.

Thanks,
Pedro Alves