Re: gdb/linux-record fixes

Pedro Alves
2015-10-29T11:38:26Z

On 10/29/2015 11:30 AM, Pedro Alves wrote:
> On 10/22/2015 02:34 PM, Marcin KoÅ›cielnicki wrote:
>> On 20/10/15 13:15, Marcin KoÅ›cielnicki wrote:
>>> On 20/10/15 13:07, Pedro Alves wrote:
>>>> On 10/19/2015 06:17 PM, Marcin KoÅ›cielnicki wrote:
>>>>
>>>>> Yeah, they're not covered by the testsuite. Actually, there seem to be
>>>>> only two tests in gdb.reverse suite that even touch syscalls:
>>>>> sigall-reverse (signal, sigprocmask, exit_group) and watch-reverse
>>>>> (read, write). No wonder that syscall handling is buggy...
>>>>>
>>>>> Stepping forward and backward over pipe/time/waitpid would indeed do the
>>>>> trick for patch #6.
>>>>
>>>> Can I convince you to add that to the patch (and likewise to others that
>>>> might not be overly hard)?
>>>
>>> I'll do that, if I'm not overcome by dejaGNU... I have no idea how that
>>> stuff works at the moment.
>>>
>>>> BTW, you'll also need to include ChangeLog entries. Please check here:
>>>>
>>>> https://sourceware.org/gdb/wiki/ContributionChecklist
>>>
>>> OK, will do.
>>>
>>
>> Here comes v2:
>
> Many thanks for this.

I sent comments to the test patch. Nothing major, they're almost ready.

And then read patches 2-13, and they all look good to me.

Thanks again for working on this.

Thanks,
Pedro Alves