Re: [PATCH v2 01/13] gdb/linux-record: Add testcases for a few syscalls.

Pedro Alves
2015-11-02T16:40:14Z

On 11/02/2015 01:34 AM, Marcin KoÅ›cielnicki wrote:

> Well, this is embarassing...
>
> Turns out gdb_continue_to_breakpoint doesn't care all that much about
> the name of the breakpoint passed in as the first parameter, it just
> happily continues to the next breakpoint, whatever it happens to be.
>
> So the testcases as commited never actually make it to marker2, and they
> all trivially pass (state when reaching marker1 is, after all, exactly
> identical to reaching marker2 and then correctly reversing to marker1).
>
> I should've known that stepping over fork suddenly starting to work was
> too good to be true.

Whoops, sorry for missing that too.

>
> So... can I get that push access now and fix my mess, or do I no longer
> qualify as having submitted a good patch due to the above? :)

:-)

See "I need an account" at https://sourceware.org/. Say I approved it.

Once you have that sorted, add yourself to the "Write After Approval"
section in gdb/MAINTAINERS, push that change to the repo (no need
for approval on that one), and post that commit on the list.

Thanks,
Pedro Alves