Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@polymtl.ca>
Subject: [PATCH c++ 6/6] Add a cast in jit_target_read_impl
Date: Thu, 29 Oct 2015 15:29:00 -0000	[thread overview]
Message-ID: <1446123767-25046-7-git-send-email-simon.marchi@polymtl.ca> (raw)
In-Reply-To: <1446123767-25046-1-git-send-email-simon.marchi@polymtl.ca>

We could change the signature of the function.  However, it would
require changing gdb_target_read in jit-reader.h, which is an exported
interface.  It's probably better to just add a cast in our code than to
break other people's code.

gdb/ChangeLog:

	* jit.c (jit_target_read_impl): Add cast.
---
 gdb/jit.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gdb/jit.c b/gdb/jit.c
index ddc223d..7c6aede 100644
--- a/gdb/jit.c
+++ b/gdb/jit.c
@@ -491,7 +491,8 @@ typedef CORE_ADDR jit_dbg_reader_data;
 static enum gdb_status
 jit_target_read_impl (GDB_CORE_ADDR target_mem, void *gdb_buf, int len)
 {
-  int result = target_read_memory ((CORE_ADDR) target_mem, gdb_buf, len);
+  int result = target_read_memory ((CORE_ADDR) target_mem,
+				   (gdb_byte *) gdb_buf, len);
   if (result == 0)
     return GDB_SUCCESS;
   else
-- 
2.6.1


  parent reply	other threads:[~2015-10-29 13:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-29 14:42 [PATCH c++ 0/6] A few C++ patches Simon Marchi
2015-10-29 14:58 ` [PATCH c++ 1/6] dwarf2read.c: Add cast Simon Marchi
2015-10-29 17:10   ` Simon Marchi
2015-10-29 17:49     ` Pedro Alves
2015-10-29 17:54       ` Simon Marchi
2015-10-29 15:01 ` [PATCH c++ 2/6] mdebugread.c: " Simon Marchi
2015-10-29 17:10   ` Pedro Alves
2015-10-29 15:01 ` [PATCH c++ 4/6] gdbserver/server.c: Cast return value of memmem Simon Marchi
2015-10-29 17:49   ` Pedro Alves
2015-10-29 15:01 ` [PATCH c++ 5/6] Cast gdb_dlsym return value Simon Marchi
2015-10-29 17:50   ` Pedro Alves
2015-10-29 15:28 ` [PATCH c++ 3/6] Change type of write_qxfer_response parameter Simon Marchi
2015-10-29 17:49   ` Pedro Alves
2015-10-29 15:29 ` Simon Marchi [this message]
2015-10-29 17:50   ` [PATCH c++ 6/6] Add a cast in jit_target_read_impl Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1446123767-25046-7-git-send-email-simon.marchi@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox