From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id irx9LjPQsWifZw8AWB0awg (envelope-from ) for ; Fri, 29 Aug 2025 12:07:15 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=hCdI1+DQ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A8F7F1E043; Fri, 29 Aug 2025 12:07:15 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3234E1E043 for ; Fri, 29 Aug 2025 12:07:15 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BA4AC3858C74 for ; Fri, 29 Aug 2025 16:07:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BA4AC3858C74 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=hCdI1+DQ Received: from YT3PR01CU008.outbound.protection.outlook.com (mail-canadacentralazlp170100001.outbound.protection.outlook.com [IPv6:2a01:111:f403:c103::1]) by sourceware.org (Postfix) with ESMTPS id CE4DF3857BBB for ; Fri, 29 Aug 2025 16:06:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CE4DF3857BBB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CE4DF3857BBB Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c103::1 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1756483571; cv=pass; b=oKPnAgKXT/JE9WIqGMEh2FtNZI2PUkndzNSO1Hwdqz3h2o4AKLIIeWC93O92OGUVN/hCJhvxkNqOe/OSGAbmnznqc1uBrVFX5rLdQiUG+pu790YA9AUaWgVvV4o2K1vJyHxglSprdbz6DuDCMWFTYMvfcT8L0mGIdKzm6jfAZjY= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1756483571; c=relaxed/simple; bh=IZdy6WrPl3+NFsiwA5EAD2O5LCjWpyDLrm3mlLhe/hY=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=Xw2+luS3w0WjSyssElWF04drmyFx0gov9u2tiuHio1nOW72dal1bsBd1mKoSpCSUEGCy4JEx1w7bEI1F1Q1bWb2BWlpjTzSTy1c3JqGHoCckWRKWl47yuZBYcosGBWK72nClTXvo05OFecROnw9J+DCh+9YXpomCwxtJQkUWlaI= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CE4DF3857BBB ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=P8SKOl37cnjVNSFdeTshWrNU2ylwk/CXfn8Ma493gW6GTk85ZsYxGhig8CCNpb7/MRcWekAiG5hYehsTv1Tf1spUJOBoSFO43M9uxn9GtgzHicjWKk7rHnuzZ0mlR+KH/T05/pHSCrWNXIpKJeqEE3sEcyaXEG8z1Y167VpOLtwIvg+Jb9Y6SHVuHkUfrAlj4qwn7QvKqX8VY8wM0PC8bobzbZfk34RYSzr2pvY7nr2sFPOUQevg01tcRcUD9Xe6lUvJtKvAp4qH4Wn+NQBB2bE7FaJSeQpBhtUmK2tGDtvrDe5hJDNhwS7mNWrdl9ujcGcvKLxm/IlrFJccdgo3YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GlAx/sehUmMaNQZUGu1bIWqhdG9z+9SsAgSI82nYTw4=; b=q3iiFb8hqmwg6SDJ/sYWxful+BSY4pbtnBv80cC5pN0wJ7d4Zek7sWtOxiWAfY5HIxKV4sL25m50BC+/OsRy4Mrcfq6xQvmVMWYcjxReat/+i8Md0cAxni0LW6wc3pqfioNegx9W13yEBqUSkAZiU9b0XscZ3iErlD15nc3FiCBsWhg4Zqi+5yUb5u++kfy4xwuEhA3vFF1FaulG7cN2Phsp7T3Jp5PyLtpxdePGKk7FDaSoopYbmfZLm+VACdUczk3dxN12gIdEQhUhWEsarGSA8cO8HM7XlVVqwmObydjavykoD4QJ9f09E2l4g3DVJNu9rZfF9zNN8L0S4FQQSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GlAx/sehUmMaNQZUGu1bIWqhdG9z+9SsAgSI82nYTw4=; b=hCdI1+DQQWiKNgIYq8tAzVubwrvOTfQQA2fzaIc9ciKoKlyShalYvv++f5AAN/vhw8czJNduIglLJBZoLtdVPtFrFVetW9k5IuHSSaiLs7KmTf9PdKCIs1YP9+8GFwGOWS8d9meHj9++Y2NKmHjj28DfyXW8GEUo9FhpjnBlCYmhlD/bkFq3ROh8nmH8OeyUGW7WbxMmFtKC9Kk/zUI9K4uyRWJz4W5L0T0gYBp74aohpUEoqyd/Kh1ta3Oep0GCbRW1L2WX9jVW8eo9TvmmSNbCg5V/zEJkv7RFo8eenW/6KA8PQf24nbyYBkdSm4bMvmITnRBhHcooGyHPJltK3A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) by YT1PR01MB8236.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:c3::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9073.21; Fri, 29 Aug 2025 16:06:03 +0000 Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::1e89:d520:630a:7d86]) by YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::1e89:d520:630a:7d86%2]) with mapi id 15.20.9073.021; Fri, 29 Aug 2025 16:06:03 +0000 Message-ID: <144605ab-8789-4eb9-9e6a-83b84b3dc2a0@efficios.com> Date: Fri, 29 Aug 2025 12:06:00 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] gdb/objfiles: use filtered_iterator as objfile::section_iterator To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20250828151100.84594-1-simon.marchi@efficios.com> <20250828151100.84594-3-simon.marchi@efficios.com> <871pouutve.fsf@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <871pouutve.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBP288CA0015.CANP288.PROD.OUTLOOK.COM (2603:10b6:c01:6a::12) To YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YQXPR01MB5418:EE_|YT1PR01MB8236:EE_ X-MS-Office365-Filtering-Correlation-Id: e34de1d7-1f15-46c0-b72c-08dde715f3e4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cmg5MVFYKy9yUnNvK0Y1OGRMbU82NGZGc1NtSjAxTzdXUm90NzVqakpsT3FV?= =?utf-8?B?NmxRa1JsY1FhMDdZV0w1Rmx1T1ZLSUxYWFpVenVySm9nWmUyN1NXdEpKbTNJ?= =?utf-8?B?N1oydmUzSDA5RXo4WThBMmd3dVc3RFNEWWhEb2xCRWdxN1pnZ1IxZ1hqUEE1?= =?utf-8?B?Z2FXZ1VJbXhQRkxhYUJjMXE4eUc2RFdtL0lzY3RtckMvOUNkRERzZXk0RVNC?= =?utf-8?B?K21RT0xNWGNTdUlqUHpUK3UvaHhONzZBNHdib05qTXZnb2dtTHBDN2tmcEtz?= =?utf-8?B?ZmFTTVl1ZEJsYmNMejNFMGlQZFh1Zjk4bXJRMGMrVGE3RXZ2T3BhWmZESG5F?= =?utf-8?B?MWlVWTU5Qmlkanc5RDJZMnZDZEc1bzR1MzdIc0hlMFliNS9ndmVHZlJGMVpC?= =?utf-8?B?ZEdTUlB2MkZ0clI3eW1nQ1VOVTBiQUxWUnkxeVlwYzIxejVQTDRjRmgyYmVU?= =?utf-8?B?aGFJVWsva1pERE9jLzBMQ3pnbGlZVytrQ1dxY05sZmFaeENJOTg1aW1jQzlw?= =?utf-8?B?cEJhS1BOS252TDBVZDl2WFpIbEVvNnpNb29OamFZYjRIY0ZPc05aa2tYNkFI?= =?utf-8?B?akpiMWJUeWV2aFRCazhINXJpbHZuOXN1VjJabWp2M1p0WGFjam1YV2NUd3A5?= =?utf-8?B?eEdJRm5WcnpxNlMweDROSTZQSUliWXpIRkhNd0x5QXRqaEZ4QVQ1aTg4VTVv?= =?utf-8?B?dm5aZUJqSlM4c3Y0VjQxTnJlRmF0M1prVUc2MG9LR2dVRnpBd3VMYWc1NGE5?= =?utf-8?B?UmpmbFBzRkNrOGwrYUx5ZENSOHZuekROdzV0dDIvSTd2dVp5UDY2NEZOVi95?= =?utf-8?B?K3g5Q0ljTWJHeWtIbktLY1ZGT0ZsRFRnT3I3WXVxa0pQMmpZdG1yUnUySk5S?= =?utf-8?B?blpxVUdDRm45QnNnTEYwV1pUTnc3a0pnVTZEOUNTWnpTNU1RWldaQUp3bkFa?= =?utf-8?B?d2IzUGJ4STJsendTMWF4SnpnTENoR2wvRlg4MEFQdU5VQlU0TWlDUXBvR2Z4?= =?utf-8?B?dHIvMlV1MWx0alBVSHY1SGtmTXhONDNteU1KMUFiRFp1QXp6L2hwNEFzNHY4?= =?utf-8?B?Q2FoR2RYTk41SFJFNHRxV05Va3haV0x0MWlucUFveU5MNDRxakx2NUM3Zjd3?= =?utf-8?B?aTRZU292cytDYjdzeUhnV0o0em1zRmpVdGhRVXVLdmJ4eXlCdEE4U2dQU2Yx?= =?utf-8?B?NXhVZEJwWFR3ZE9aVkFSeUE5MVlneXBHc3dqMFdocUZNbkV3RmZhTzBza1FW?= =?utf-8?B?c0hTYndBdjdaM2t0SnRNd2h4NUVhYnRWTG5zamM2V1I3eC8rV2xYUXY3THZw?= =?utf-8?B?VmUvUTBhVmpiKzRJOHJ2a0RSYUt5QlEwbVQzQld3ZFlWZU8zczRkMng5aVZV?= =?utf-8?B?cnlsVFFLeGRsK0YvU2dXVGlEaTk5LzlVYU1pdG92b091Zm5kU2hjL3lHMlFq?= =?utf-8?B?WmRxU2pQc2NSeFExTU9saHBWTVorMUZ3RWRFZlZlTnA4bmwrT21aUi9YaXNP?= =?utf-8?B?aER4QVV0Q3M5UTR4Q2tzYXVoVHZLc2VoSkQva0R4OHJTa3FwOVRRZnNtaklm?= =?utf-8?B?aGowaHg3blJJUGp2S1NJOWg0dnhhZ1VnME9MaWM5eXJUbmlPUmZjU3B0QXhW?= =?utf-8?B?dUI4ajY0dTdDVDlqUlp6RWtUdGI5ZTV1MDBLQTR1SHhuOWJxaEJhODQwVTh5?= =?utf-8?B?aitUZnFqMzFCTkExSlhCaGdWRVY5cEUzUDBodXBLc0cyWUxLalRORWtqaFFx?= =?utf-8?B?Q3FNOE5XSkpIWWNJU016REFrTTJvRDl6VEtqRVYydXkyWGFwN1JiYU9IcDE2?= =?utf-8?B?eUJJVi8xMU1vN0c2Y1IyMkF3UHF4R0lWMzJNQ0pWajlTQ1RRVG9yU1VzeHh5?= =?utf-8?B?ZXhIcVlRMmMzcmxJUXNOS0lpTnFHbjVZWnNjWEsydWFCZVJocnZWeXB5UVBu?= =?utf-8?Q?ptpFsMC0gfc=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NG1VNHVwK3dOOHdiMGFwOXpqZ0FBek95ZnhMS1BHUVJZNk96Q0cxZlJSckxK?= =?utf-8?B?dmx2cG5OWUZHN2pWR0FkWmdrcDBLaVl2eXlocEtMenpNRVRySzRERGNpZ29x?= =?utf-8?B?U2RxdDhZZ2RSUGlabDhVcGhZWG0wZmN6ckFlajlhTVQzdXFKc3phajhRNGQy?= =?utf-8?B?RFJ2dDJSMmdZdy91Q29GUkdCYkNEUUFYTHdDaVd6RldCY201cWlQa1dMVHBl?= =?utf-8?B?cGVOc3NnVmx4ZEdobWQxUml4RmROSjU4L3pQSXNqeWJxY0NqUzNjZlpsUXhz?= =?utf-8?B?alBtbzJ5L1FlR0I4VmN1R2JhK2FGaUVhaXpZVVhwcCtZQ1piQWJrVDZvc2FX?= =?utf-8?B?ZUVMMlNnZmtpSVJaWmViUnNJMGJOd01WNHQyRys0cmRHMi9EbHdxeWJFaXRk?= =?utf-8?B?Vm55eWdZSGFuWm9UcFZxeHBGQTQveXpvWitFUEpqQ1dnSHRkVDVENC9vODUz?= =?utf-8?B?TXNMMmtFWkI2VDJWVWNhVFFrOG1XeGFsb09QbS9xNEVlU3JBU29HblJSb2Ny?= =?utf-8?B?eTRhVVI4Qy9BWXJUZUJGWnVic3NuVWs2Tkl6K2J5VWQ4OXpleGplMEk5bTUy?= =?utf-8?B?TlpzT0V1N0dZc1FuUjdvQk9lTTlPMk52OHVFS2d1NFZaSTIyUzcxMVFuQWJV?= =?utf-8?B?YUFFSkI1SWlMaERUSm9NRFVqTFhxR284WHRRUmY1OVQ5cXphYUsrMU5QQjhw?= =?utf-8?B?TEtPSTBLNTU3SjlzUFcza1Zac2MwOUxBd0JEQzFOMEdRU05tUUNCTDFWT1pz?= =?utf-8?B?b0NwalNkc1FFSzlaVERONktBY3VYQ1E3b3FOdjBlNGl4eGF5WUUxK29hMHdy?= =?utf-8?B?TUJKU2ZpOTBLUFVjaDRTQzlCeW90dFlXUG03Y1ZLdXBMeWtkaW16ZnNMSnRP?= =?utf-8?B?cC9qSW1pbkdSNFlNN1lndTl1d25DbTRzSjViK09HMTQ1eVZLQmJtS0VCbW42?= =?utf-8?B?YkI4V1lyYTV4ZmU3TFliVUY0UTczc1BLN3BXaDVFc3VtTllYemFwMkxHc3R3?= =?utf-8?B?MmlYUkhJRWVQSlg2aWI0K2YwYkZpZVNNQVR5NDBtYzQvOEVVbVB2TlNDVTVF?= =?utf-8?B?U1Y0Ujk4cHpiZS84UmlVY2g3MzBic05Dd294V05meG0xRkQ1VXcyU1ZtRXRJ?= =?utf-8?B?RTVUZ0ZVMUNhNFhJb2F1aTN4aytXR1M3UG5SWXFzUkxnbkxzT2VGNGNET1By?= =?utf-8?B?ZWsyTGRjOFIwVUhKMFU1Y2lTMU95RFppL0VHT0lpbmpoZ0U0dG0zY3d4MmNM?= =?utf-8?B?YmtQdlZrOFNnbVZTbWNHaE9JOThuOGxBenV6Ump0YmxSUEhCN2UweVRKcGVD?= =?utf-8?B?bGpFcWlTSHB4NGhLeDRtSzN2WlJQaWtTMzdWS0hISGltU2Fqcm55anVwQkgy?= =?utf-8?B?QVFLd0szM2ZzSFk3VlR5RzVURkFlZmg3M21JQlNsNzk2WGZZK2FhRWpGUysv?= =?utf-8?B?T3ZCNE11VU1ib25WRjUySGZkUE9sUGNFMldOYi9QVWxNVVJrTlAzcGwweFpr?= =?utf-8?B?MHVPeXNJc3k5S21vUUJ5YXZHMzhyL09KaVFCNHRaWnhRUzQ0SzNvSy9VWmUx?= =?utf-8?B?WDNkWDJUeGZ4ekhGODdTWmFDNmZvdWRCcFpwTEpJUkJUbUY3V2tRekd6bzVt?= =?utf-8?B?c21QQ0ttSXRnM2RZOU1WVEpjRkdYa3JVVzJZdllHVGlpbkRES2phcjBtU3lr?= =?utf-8?B?VGhsVktHc3E2NFNva3BSYVFiQllpMG93RVlBbTNHQ05YdHVVTkVyeURNZ3FK?= =?utf-8?B?T3FXQkhBdXdvaGVPcURwblpBVnRGL2tVRFhMSDBJck1jM2IxemN1SjlPZWVW?= =?utf-8?B?Y1BZM1VvdXNiZm9EaEs1OS9XYmxrSWNSZkNWb3dwcTZsRC8wTzBEWWtLSlRU?= =?utf-8?B?NDZGY051TFRPbThNcjY5V2ppNFRzaUxFSGdYcXRyL3AzMDczUTgrOXEyeTBD?= =?utf-8?B?VnY4cS8zZE9yelBKVENYUnBlRFU3Y2F1NUtRZndpOVF0TXFQaE1iT0ErTHUw?= =?utf-8?B?SGxBS3g2NCtaMnNPYjNTSHNjMnZMbkx1eHAyR3gvZDRyVUxYem5rd1BBd24z?= =?utf-8?B?WENqY1cwZlBhM1ZzKzIyMEFXRUQyMTM1OTIzWUdrTlFtQlc5UEtibUk4cVB5?= =?utf-8?Q?fmPnV4uZm+izRh+XW3lrwgU2U?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: e34de1d7-1f15-46c0-b72c-08dde715f3e4 X-MS-Exchange-CrossTenant-AuthSource: YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2025 16:06:03.0360 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OYwqUOfEQKEqP2yEEhidsRjfFGkYN+9PN86atB3OpIe4dORo1olm+Wx6NNmPWI/7taGpu56gwGxOCwMFMIwh9A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT1PR01MB8236 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2025-08-29 09:42, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> objfile::section_iterator looks like a good candidate to be implemented > Simon> with filtered_iterator. Following the enhancements to filtered_iterator > Simon> in the previous patch, it's pretty straighforward. > > Simon> I removed the non-const version of objfile::sections, because it didn't > Simon> seem useful to have the two methods returning the exact same type and > Simon> value. Having just the const version achieves the same thing. > > I would have thought the const one would return a const iterator and not > allow modifications to the underlying objects. I don't think it did that, because section_iterator specifically used a non-const `obj_section *` as the value type. I can see it easily with clangd in VSCode. With this function: void test () { decltype(auto) nc = *static_cast (nullptr)->sections ().begin (); decltype(auto) c = *static_cast (nullptr)->sections ().begin (); } ... when I hover `decltype(auto)` in both cases, it says the deduced type is `obj_section &` (non-const). It was `obj_section *` in both cases before my patch that make the iterator yield references. > Anyway if it didn't then that's just some pre-existing bug, probably not > too important. I'll see if I can make it right, while at it, but otherwise I don't think it's a big deal. Not that it's good, but it's not like we are anywhere near to have const-correctness in GDB (yet). Simon