From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68698 invoked by alias); 20 Oct 2015 16:48:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 68683 invoked by uid 89); 20 Oct 2015 16:48:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg20.ericsson.net Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 20 Oct 2015 16:48:19 +0000 Received: from EUSAAHC004.ericsson.se (Unknown_Domain [147.117.188.84]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id EB.4C.32596.3CF06265; Tue, 20 Oct 2015 11:56:19 +0200 (CEST) Received: from elxa4wqvvz1.dyn.mo.ca.am.ericsson.se (147.117.188.8) by smtps-am.internal.ericsson.com (147.117.188.84) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 20 Oct 2015 12:48:16 -0400 From: Antoine Tremblay To: Subject: [PATCH v3 0/5] Software breakpoints support for ARM linux in GDBServer. Date: Tue, 20 Oct 2015 16:48:00 -0000 Message-ID: <1445359685-2589-1-git-send-email-antoine.tremblay@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg00366.txt.bz2 In this v3 : The main change is that the functions breakpoint_from_pc and breakpoint_from_kind are now called : breakpoint_kind_from_pc and sw_breakpoint_from_kind. As suggested in : https://sourceware.org/ml/gdb-patches/2015-10/msg00287.html Thank you Pedro the patch set is really more clear now. Thus the patchset is restructured for that, patches have been renamed and reordered. Patches that have changed have their own v3 comment. Original comment is updated : ----- This patch series adds software breakpoint support for ARM on linux in GDBServer. This is a subset of a previous patchset : https://sourceware.org/ml/gdb-patches/2015-09/msg00221.html Other patches in that previous patchset will be sent after. The problematic with ARM software breakpoints is that it can have 3 different breakpoints one for each instruction set : arm, thumb, thumb2. So we need to be able to set different kinds of breakpoints when GDBServer sets its own breakpoints or when a breakpoint is set using GDB's Z0 packet. In order to allow that the patches : [PATCH v3 1/5] Add the target_ops needed for software breakpoints in GDBServer. Adds new target operations to replace the static breakpoint and breakpoint_len operation so that the target can return the proper GDBServer breakpoint. [PATCH v3 2/5] Support breakpoint kinds for software breakpoints in GDBServer. This is the main patch of the set, it handles GDBServer's software breakpoints by calling the breakpoint_kind_from_pc operation and sw_breakpoint_from_kind. [PATCH v3 3/5] Implement breakpoint_kind_from_pc and sw_breakpoint_from_kind for ARM in GDBServer. This patch adds the ARM implementation of these target operation, selecting the thumb, thumb2, or arm breakpoint based on the PC address and the flags encoded in it. [PATCH v3 4/5] Refactor the breakpoint definitions in linux-arm-low.c. This patch refactors the breakpoint definitions a bit to be more clear . [PATCH v3 5/5] Support software breakpoints for ARM linux in GDBServer. And finally software breakpoints via Z0 packets are enabled for ARM. This patchset has no regressions observed, tested on ubuntu 14.04 ARMv7 and x86. With gdbserver-{native,extended} / { -marm -mthumb } Note also that while I could not test directly thumbv1 instructions with gcc -marmv4t , manual testing of the software breakpoints was done for thumbv1 instructions.