From: Mike Frysinger <vapier@gentoo.org>
To: Chen Gang <gang.chen.5i5j@gmail.com>, gdb-patches@sourceware.org
Cc: eager@eagercon.com
Subject: Re: [PATCH] sim/microblaze/interp.c: Use long int format instead of int to avoid compiling warnings
Date: Sat, 02 Aug 2014 17:21:00 -0000 [thread overview]
Message-ID: <1444359.20hJbUDvYc@vapier> (raw)
In-Reply-To: <53B1FD76.7030500@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 548 bytes --]
On Tue 01 Jul 2014 08:14:46 Chen Gang wrote:
sim patches only go to gdb-patches, so don't include cgen/binutils in the
future please
> --- a/sim/microblaze/interp.c
> +++ b/sim/microblaze/interp.c
>
> if (len > (int) sizeof (unsigned long))
> printf ("That operation is not available on integers of more than "
> - "%d bytes.", sizeof (unsigned long));
> + "%ld bytes.", sizeof (unsigned long));
unfortunately, i don't believe this is correct. pretty sure the right answer
is %zu as sizeof() is a size_t.
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-08-02 17:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 0:15 Chen Gang
2014-07-01 0:43 ` Michael Eager
2014-07-01 1:08 ` Chen Gang
2014-07-01 1:11 ` Michael Eager
2014-08-02 17:21 ` Mike Frysinger [this message]
2015-03-08 7:24 ` Mike Frysinger
2015-03-08 21:22 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444359.20hJbUDvYc@vapier \
--to=vapier@gentoo.org \
--cc=eager@eagercon.com \
--cc=gang.chen.5i5j@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox