From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 77349 invoked by alias); 15 Sep 2015 19:15:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 77332 invoked by uid 89); 15 Sep 2015 19:15:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=BAYES_05,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mailsec119.isp.belgacom.be Received: from mailsec119.isp.belgacom.be (HELO mailsec119.isp.belgacom.be) (195.238.20.115) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 15 Sep 2015 19:15:46 +0000 X-Cloudmark-SP-Filtered: true X-Cloudmark-SP-Result: v=1.1 cv=wisUSL2q+2X910teRg2xg/30tBFW7lBMAi45pEFXNHU= c=1 sm=2 a=UbVz_fOUYeqNoi_zTzkA:9 a=QEXdDO2ut3YA:10 a=RyqWx-eEqzxFueM0:21 a=anHJJC-nacnRqzBV:21 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2AMCgAibfhV/zGDhm1dgyODBLwWhRyCUAQCAoFBOhMBAQEBAQEBgQpBBYNeAQEEIzMjEAgDDgoCAiYCAjkeBohFAbYXlBsBAQEBAQUCIBmBCYVRhH2BPQGDTweCaYFDAQSVXI0DgU2NK4gig2wjAj6CHiWBQDyFY4R6AQEB Received: from 49.131-134-109.adsl-dyn.isp.belgacom.be (HELO soleil) ([109.134.131.49]) by relay.skynet.be with ESMTP/TLS/AES128-SHA; 15 Sep 2015 21:15:43 +0200 Message-ID: <1442344574.21802.1.camel@skynet.be> Subject: Re: [PATCH V2] PR varobj/18564 regression in showing __thread so extern variable From: Philippe Waroquiers To: Pedro Alves Cc: Yao Qi , gdb-patches@sourceware.org Date: Tue, 15 Sep 2015 19:15:00 -0000 In-Reply-To: <55F194F8.3090805@redhat.com> References: <1440934487.22248.9.camel@skynet.be> <86wpw9x9au.fsf@gmail.com> <1441229015.13071.23.camel@skynet.be> <86h9nbyhb6.fsf@gmail.com> <1441317832.4429.4.camel@skynet.be> <55F194F8.3090805@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00358.txt.bz2 On Thu, 2015-09-10 at 15:34 +0100, Pedro Alves wrote: > On 09/03/2015 11:03 PM, Philippe Waroquiers wrote: > > On Thu, 2015-09-03 at 10:37 +0100, Yao Qi wrote: > >> We don't have to get printf involved in the test, because some targets > >> may don't have printf at all. > > Ok, effectively, without printf, the test will then run on these > > targets. > > > > Find below the new version of the patch. > > All your comments should be handled. > > > > The fix itself still need to be reviewed. > > > > Thanks for your review > > > > Any comment on the fix ? Ok to commit ? > > This is OK. Thanks for fixing this. Thanks, pushed. Philippe