Re: Is ``break main if(1)'' legal?

[Elena Zannoni <ezannoni@cygnus.com>]

Fernando Nasser writes:
 > Andrew Cagney wrote:
 > > 
 > > (vs ``break main if (1)'')
 > > Some parts of the code (decode_line_1()) think it is legal but other
 > > parts (break_command_1()) don't.
 > > 
 > 
 > (1) is a perfectly valid logical expression of "true".  It makes no
 > sense setting a conditional breakpoint to always true, but rejecting the
 > expression as not valid is wrong.
 > 
 > What is break_command_1() complaining about?
 > 

I think Andrew is referring to the space between 'if' and the condition?
Elena

 > -- 
 > Fernando Nasser
 > Cygnus Solutions - Toronto Office       E-Mail:  fnasser@cygnus.com
 > 2323 Yonge Street, Suite #300           Tel:  416-482-2661 ext. 311
 > Toronto, Ontario   M4P 2C9              Fax:  416-482-6299
From law@cygnus.com Wed Dec 15 10:41:00 1999
From: Jeffrey A Law <law@cygnus.com>
To: Jimmy Guo <guo@cup.hp.com>
Cc: gdb-patches@sourceware.cygnus.com, binutils@sourceware.cygnus.com
Subject: Re: (patch) hpjyg07: include/hp-symtab.h 
Date: Wed, 15 Dec 1999 10:41:00 -0000
Message-id: <2374.945282280@upchuck>
References: <Pine.LNX.4.10.9912150840410.29519-100000@hpcll168.cup.hp.com>
X-SW-Source: 1999-q4/msg00391.html
Content-length: 1124

  In message < Pine.LNX.4.10.9912150840410.29519-100000@hpcll168.cup.hp.com >you 
write:
  > >  > 1999-11-03      Jimmy Guo       <guo@cup.hp.com>
  > >  > 
  > >  >         * hp-symtab.h (HP_LANGUAGE_FORTRAN): Declare, replaces
  > >  >         HP_LANGUAGE_F77.
  > >I don't see the point behind making this change.  Also note that it will
  > >break gdb unless you change hp-psymtab-read.c at the same time.
  > 
  > >Why are you making this change?
  > 
  > We've added Fortran 90 support and this change is to cover Fortran90 as
  > well.
Ah yes.  That makes perfect sense.

  > But it could be that hp-psymtab-read.c needs change at the same
  > time ... I thought I tested each patch but one can never be sure.
grep HP_LANGUAGE_F77 will show one use in hp-psymtab-read.c  so it
should be updated to the newer name.  I'll take care of that.

It probably does not matter for this specific patch, but in general if we can
keep compatibility we should.  I went ahead and updated the patch so that it
provides by HP_LANGUAGE_FORTRAN and HP_LANGUAGE_F77.

The changes should appear in the next gdb snapshot.

Thanks,
jeff