Re: [PATCH v2 5/5] Extended-remote exec event docs

Eli Zaretskii
2015-07-31T06:36:53Z

> From: Don Breazeal <donb@codesourcery.com>
> Date: Thu, 30 Jul 2015 16:19:20 -0700
>
> This patch is unchanged from the previous version. It was
> reviewed and approved by Eli here:
> https://sourceware.org/ml/gdb-patches/2015-07/msg00466.html
> -----
>
> This patch adds documentation of support for exec events on
> extended-remote Linux targets.
>
> Thanks,
> --Don
>
> gdb/
> 2015-07-30 Don Breazeal <donb@codesourcery.com>
>
> * NEWS: Announce new remote packets for the exec-events
> feature and the exec-events feature.
>
> gdb/doc/
> 2015-07-30 Don Breazeal <donb@codesourcery.com>
>
> * gdb.texinfo (Remote Configuration): Add exec event
> feature to table of packet settings.
> (Stop Reply Packets): Add exec events to the list of stop
> reasons.
> (General Query Packets): Add exec events to tables of
> 'gdbfeatures' and 'stub features' supported in the qSupported
> packet, as well as to the list containing stub feature
> details.

OK, with a single comment:

> +@cindex exec events, remote reply
> +@item exec
> +The packet indicates that @code{execve} was called, and @var{r}
> +is the absolute pathname of the file that was executed, in hex.

GNU coding standards frown on using "pathname" in this context; please
use "file name" instead.

Thanks.