RE: [pushed][PATCH v3 1/4] Extended-remote follow exec

Breazeal, Don
2015-09-30T16:22:30Z

> -----Original Message-----
> From: Pedro Alves [mailto:palves@redhat.com]
> Sent: Wednesday, September 30, 2015 9:20 AM
> To: Breazeal, Don; gdb-patches@sourceware.org
> Subject: Re: [pushed][PATCH v3 1/4] Extended-remote follow exec
>
> Hi Don,
>
> On 09/11/2015 07:38 PM, Don Breazeal wrote:
> > @@ -5977,6 +6065,7 @@ remote_parse_stop_reply (char *buf, struct
> stop_reply *event)
> > struct remote_arch_state *rsa = get_remote_arch_state ();
> > ULONGEST addr;
> > char *p;
> > + int skipregs = 0;
> >
> > event->ptid = null_ptid;
> > event->rs = get_remote_state ();
> > @@ -6089,11 +6178,42 @@ Packet: '%s'\n"),
> > event->ws.kind = TARGET_WAITKIND_VFORK_DONE;
> > p = skip_to_semicolon (p1 + 1);
> > }
> > + else if (strncmp (p, "exec", p1 - p) == 0)
> > + {
>
> I happened to notice that this is still using strncmp while the rest
> of the magic registers are now using strprefix instead (26d56a939e).
> Looks like a mid-air collision happened.
> This one could be adjusted to use strprefix too, right?

Absolutely, thanks for pointing it out. I will take care of that today.
--Don