From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 49071 invoked by alias); 11 Sep 2015 06:51:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 48991 invoked by uid 89); 11 Sep 2015 06:51:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_05,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mga03.intel.com Received: from mga03.intel.com (HELO mga03.intel.com) (134.134.136.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 11 Sep 2015 06:51:49 +0000 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 10 Sep 2015 23:51:48 -0700 X-ExtLoop1: 1 Received: from irvmail001.ir.intel.com ([163.33.26.43]) by orsmga001.jf.intel.com with ESMTP; 10 Sep 2015 23:51:42 -0700 Received: from ulvlx001.iul.intel.com (ulvlx001.iul.intel.com [172.28.207.17]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id t8B6pdW5021776; Fri, 11 Sep 2015 07:51:39 +0100 Received: from ulvlx001.iul.intel.com (localhost [127.0.0.1]) by ulvlx001.iul.intel.com with ESMTP id t8B6pcPq025576; Fri, 11 Sep 2015 08:51:38 +0200 Received: (from mmetzger@localhost) by ulvlx001.iul.intel.com with œ id t8B6pcAr025572; Fri, 11 Sep 2015 08:51:38 +0200 From: Markus Metzger To: palves@redhat.com Cc: gdb-patches@sourceware.org Subject: [PATCH v2 01/17] btrace: fix non-stop check in to_wait Date: Fri, 11 Sep 2015 06:51:00 -0000 Message-Id: <1441954298-25298-2-git-send-email-markus.t.metzger@intel.com> In-Reply-To: <1441954298-25298-1-git-send-email-markus.t.metzger@intel.com> References: <1441954298-25298-1-git-send-email-markus.t.metzger@intel.com> X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00192.txt.bz2 The record btrace target stops other threads in non-stop mode after stepping the to-be-resumed thread. The check is done on the non_stop variable. It should rather be done on target_is_non_stop_p (). With all-stop on top of non-stop, infrun will take care of stopping other threads. 2015-09-11 Markus Metzger gdb/ * record-btrace.c (record_btrace_wait): Replace non_stop check with target_is_non_stop_p (). --- gdb/record-btrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/record-btrace.c b/gdb/record-btrace.c index 9e16ab4..2d8b20b 100644 --- a/gdb/record-btrace.c +++ b/gdb/record-btrace.c @@ -2104,7 +2104,7 @@ record_btrace_wait (struct target_ops *ops, ptid_t ptid, *status = record_btrace_step_thread (tp); /* Stop all other threads. */ - if (!non_stop) + if (!target_is_non_stop_p ()) ALL_NON_EXITED_THREADS (other) other->btrace.flags &= ~BTHR_MOVE; -- 1.8.3.1