Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Sergio Durigan Junior <sergiodj@redhat.com>
To: GDB Patches <gdb-patches@sourceware.org>
Cc: Sergio Durigan Junior <sergiodj@redhat.com>
Subject: [PATCH] Initialize variable and silence GCC warning from last commit
Date: Wed, 02 Sep 2015 04:38:00 -0000	[thread overview]
Message-ID: <1441168678-15805-1-git-send-email-sergiodj@redhat.com> (raw)
In-Reply-To: <87pp215u3f.fsf@redhat.com>

BuildBot e-mailed me to let me know that my last commit broke GDB on
RHEL-7.1 s390x.  On solib-svr4.c:svr4_handle_solib_event, 'val' now
needs to be initialized as NULL because it is inside a TRY..CATCH
block.  This patch does that.  Pushed as obvious.

gdb/ChangeLog:
2015-09-01  Sergio Durigan Junior  <sergiodj@redhat.com>

	* solib-svr4.c (svr4_handle_solib_event): Initialize 'val' as NULL
---
 gdb/ChangeLog    | 4 ++++
 gdb/solib-svr4.c | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 8ed469f..80fff7e 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
 2015-09-01  Sergio Durigan Junior  <sergiodj@redhat.com>
 
+	* solib-svr4.c (svr4_handle_solib_event): Initialize 'val' as NULL
+
+2015-09-01  Sergio Durigan Junior  <sergiodj@redhat.com>
+
 	* solib-svr4.c (solib_event_probe_action): Call
 	get_probe_argument_count using TRY...CATCH.
 	(svr4_handle_solib_event): Likewise, for evaluate_probe_argument.
diff --git a/gdb/solib-svr4.c b/gdb/solib-svr4.c
index 5d2b9dd..d3411fa 100644
--- a/gdb/solib-svr4.c
+++ b/gdb/solib-svr4.c
@@ -1908,7 +1908,7 @@ svr4_handle_solib_event (void)
   struct probe_and_action *pa;
   enum probe_action action;
   struct cleanup *old_chain, *usm_chain;
-  struct value *val;
+  struct value *val = NULL;
   CORE_ADDR pc, debug_base, lm = 0;
   int is_initial_ns;
   struct frame_info *frame = get_current_frame ();
-- 
2.4.3


  reply	other threads:[~2015-09-02  4:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-21 23:37 [PATCH 0/2] Improve error management on probes-based dynamic linker interface (and workaround RH BZ 1196181) Sergio Durigan Junior
2015-08-21 23:37 ` [PATCH 2/2] Catching errors on probes-based dynamic linker interface Sergio Durigan Junior
2015-08-24  8:43   ` Gary Benson
2015-08-24 16:09     ` Sergio Durigan Junior
2015-08-25 12:47       ` Gary Benson
2015-08-25 18:17         ` Sergio Durigan Junior
2015-09-01  3:27           ` Sergio Durigan Junior
2015-09-01  9:24             ` Gary Benson
2015-09-01 16:26               ` Sergio Durigan Junior
2015-09-02  4:18                 ` Sergio Durigan Junior
2015-09-02  4:22                   ` Sergio Durigan Junior
2015-09-02  4:38                     ` Sergio Durigan Junior [this message]
2015-09-02  4:50                     ` [PATCH] Initialize yet another variable to silence GCC warning from last-but-one commit Sergio Durigan Junior
2015-08-21 23:37 ` [PATCH 1/2] Improve error reporting when handling SystemTap SDT probes Sergio Durigan Junior
2015-09-02  4:20   ` Sergio Durigan Junior
2015-09-02  4:20 ` [PATCH 0/2] Improve error management on probes-based dynamic linker interface (and workaround RH BZ 1196181) Sergio Durigan Junior
2015-09-02 16:38   ` Gary Benson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441168678-15805-1-git-send-email-sergiodj@redhat.com \
    --to=sergiodj@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox