Re: [PATCH 1/2] [gdbserver] Rename supports_conditional_breakpoints to supports_hardware_single_step

Antoine Tremblay
2015-09-09T15:37:58Z

> - /* Although lynx has hardware single step, still disable this
> - feature for lynx, because it is implemented in linux-low.c instead
> - of in generic code. */
> - NULL, /* supports_conditional_breakpoints */
> + target_can_do_hardware_single_step,
> NULL, /* stopped_by_watchpoint */
> NULL, /* stopped_data_address */
> NULL, /* read_offsets */
...
> +
> +/* Target can do hardware single step. */
> +
> +int
> +target_can_do_hardware_single_step (void)
> +{
> + return 1;
> +}

Why would we enable conditional breakpoints on lynx,win32 etc.. since I
think it's still valid that it's implemented in linux-low ?

Should we not default to return 0 in target_can_do_hardware_single_step ?