From: Luis Machado <lgustavo@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: [PATCH] Guard compile tests from running when unsupported + harden feature support check
Date: Wed, 19 Aug 2015 12:54:00 -0000 [thread overview]
Message-ID: <1439988825-19754-1-git-send-email-lgustavo@codesourcery.com> (raw)
In our test environment i noticed a few compile tests, though unsupported,
were still being executed and causing spurious FAIL's.
The following change adds a missing feature support check to compile-ifunc.exp
and also adds one more pattern to the feature support check function.
With this change, none of the compile tests run when they're not supposed to.
OK?
gdb/testsuite/ChangeLog:
2015-08-19 Luis Machado <lgustavo@codesourcery.com>
* lib/gdb.exp (skip_compile_feature_tests): Check for unsupported
compiler language.
* gdb.compile/compile-ifunc.exp (with_test_prefix): Check feature
support before running tests.
---
gdb/testsuite/gdb.compile/compile-ifunc.exp | 5 +++++
gdb/testsuite/lib/gdb.exp | 3 +++
2 files changed, 8 insertions(+)
diff --git a/gdb/testsuite/gdb.compile/compile-ifunc.exp b/gdb/testsuite/gdb.compile/compile-ifunc.exp
index 026c62f..80d7bb4 100644
--- a/gdb/testsuite/gdb.compile/compile-ifunc.exp
+++ b/gdb/testsuite/gdb.compile/compile-ifunc.exp
@@ -46,6 +46,11 @@ with_test_prefix "debug" {
return -1
}
+ if {[skip_compile_feature_tests]} {
+ untested "compile command not supported (could not find libcc1 shared library?)"
+ return -1
+ }
+
# gnu_ifunc (10): error: too many arguments to function 'gnu_ifunc'
gdb_test_no_output "compile code resultvar = gnu_ifunc_alias (10);"
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 56cde7a..fcf9cac 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -3005,6 +3005,9 @@ proc skip_compile_feature_tests {} {
-re "Command not supported on this host\\..*\r\n$gdb_prompt $" {
set result 1
}
+ -re "No compiler support for this language\\.\r\n$gdb_prompt $" {
+ set result 1
+ }
-re "\r\n$gdb_prompt $" {
}
}
--
1.9.1
next reply other threads:[~2015-08-19 12:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 12:54 Luis Machado [this message]
2015-08-19 13:15 ` Pedro Alves
2015-08-19 13:34 ` Luis Machado
2015-08-19 13:46 ` Pedro Alves
2015-08-19 18:01 ` Luis Machado
2015-08-19 19:57 ` [PATCH] Fix language of compilation unit with unknown file extension (Re: [PATCH] Guard compile tests from running when unsupported + harden feature support check) Pedro Alves
2015-08-19 20:02 ` Pedro Alves
2015-08-19 20:43 ` Doug Evans
2015-08-20 11:37 ` Pedro Alves
2015-08-27 4:57 ` [PATCH] Guard compile tests from running when unsupported + harden feature support check Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439988825-19754-1-git-send-email-lgustavo@codesourcery.com \
--to=lgustavo@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox