Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Gary Benson <gbenson@redhat.com>
To: gdb-patches@sourceware.org
Cc: Pedro Alves <palves@redhat.com>,
	       Sandra Loosemore <sandra@codesourcery.com>,
	Paul_Koning@Dell.com,
	       Jan Kratochvil <jan.kratochvil@redhat.com>,
	       Joel Brobecker <brobecker@adacore.com>
Subject: [PATCH 1/5] Revert default system root back to ""
Date: Tue, 28 Jul 2015 15:45:00 -0000	[thread overview]
Message-ID: <1438097772-31480-2-git-send-email-gbenson@redhat.com> (raw)
In-Reply-To: <1438097772-31480-1-git-send-email-gbenson@redhat.com>

This commit reverts the default system root from "target:" to "".

gdb/ChangeLog:

	* main.c (captured_main): Revert default sysroot back to "".
	* NEWS: Remove comment about default sysroot being "target:".
---
 gdb/ChangeLog |    5 +++++
 gdb/NEWS      |    3 +--
 gdb/main.c    |    7 ++-----
 3 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/gdb/NEWS b/gdb/NEWS
index 7ce9758..7ecdf93 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -39,8 +39,7 @@
 * Directory names supplied to the "set sysroot" commands may be
   prefixed with "target:" to tell GDB to access shared libraries from
   the target system, be it local or remote.  This replaces the prefix
-  "remote:".  The default sysroot has been changed from "" to
-  "target:".  "remote:" is automatically converted to "target:" for
+  "remote:", which is automatically converted to "target:" for
   backward compatibility.
 
 * The system root specified by "set sysroot" will be prepended to the
diff --git a/gdb/main.c b/gdb/main.c
index aecd60a..2d642f9 100644
--- a/gdb/main.c
+++ b/gdb/main.c
@@ -545,11 +545,8 @@ captured_main (void *data)
   gdb_sysroot = relocate_gdb_directory (TARGET_SYSTEM_ROOT,
 					TARGET_SYSTEM_ROOT_RELOCATABLE);
 
-  if (gdb_sysroot == NULL || *gdb_sysroot == '\0')
-    {
-      xfree (gdb_sysroot);
-      gdb_sysroot = xstrdup (TARGET_SYSROOT_PREFIX);
-    }
+  if (gdb_sysroot == NULL)
+    gdb_sysroot = xstrdup ("");
 
   debug_file_directory = relocate_gdb_directory (DEBUGDIR,
 						 DEBUGDIR_RELOCATABLE);
-- 
1.7.1


  parent reply	other threads:[~2015-07-28 15:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-28 15:36 [PATCH 0/5] Change how "target:" gets into filenames Gary Benson
2015-07-28 15:36 ` [PATCH 3/5] Rename TARGET_SYSROOT_PREFIX as TARGET_FILENAME_PREFIX Gary Benson
2015-07-28 15:36 ` [PATCH 2/5] Update Valgrind GDB special case Gary Benson
2015-07-28 15:36 ` [PATCH 4/5] Use TARGET_FILENAME_PREFIX as the system root in some cases Gary Benson
2015-07-28 15:40   ` Eli Zaretskii
2015-07-28 15:45 ` [PATCH 5/5] Update exec_file_find callers Gary Benson
2015-07-28 15:45 ` Gary Benson [this message]
2015-07-28 15:58   ` [PATCH 1/5] Revert default system root back to "" Eli Zaretskii
2015-07-29 17:04 ` [PATCH 0/5] Change how "target:" gets into filenames Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438097772-31480-2-git-send-email-gbenson@redhat.com \
    --to=gbenson@redhat.com \
    --cc=Paul_Koning@Dell.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=palves@redhat.com \
    --cc=sandra@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox