Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Eli Zaretskii" <eliz@elta.co.il>
To: Joel Brobecker <brobecker@gnat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC] Word break characters are language dependent
Date: Sun, 21 Sep 2003 12:32:00 -0000	[thread overview]
Message-ID: <1438-Sun21Sep2003152844+0300-eliz@elta.co.il> (raw)
In-Reply-To: <20030918191641.GY15984@gnat.com> (message from Joel Brobecker on Thu, 18 Sep 2003 12:16:41 -0700)

> Date: Thu, 18 Sep 2003 12:16:41 -0700
> From: Joel Brobecker <brobecker@gnat.com>
> 
> I was working on implementing proper completion for Ada in GDB, and
> ended up reading this part of the code (completer.c:localtion_completer()):
> 
>       else if (strchr (gdb_completer_word_break_characters, *p))
>         symbol_start = p + 1;
> 
> Unfortunately, the word-break characters for Ada are not exactly the
> same as the ones used by default.  As a consequence, the current
> completer does not always find the correct starting location of the
> symbol name.  So I think we should make them language-dependent by
> adding a new field to the language vector.

Did you actually try to replace the hard-coded string with a different
one that is good for Ada, and see if that solves your problem?

I'm asking because I have a vague memory of things being
not-quite-that-simple in that part of the code, since readline's
interface with customized completers is--how should I put it?--less
than optimal.

So I think before we discuss the design of a possible solution, we
should be sure that it is in fact a solution ;-)

Other than that, I think your general idea is correct and the proposed
direction is reasonable.


  reply	other threads:[~2003-09-21 12:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-18 19:16 Joel Brobecker
2003-09-21 12:32 ` Eli Zaretskii [this message]
2003-09-21 21:43   ` Joel Brobecker
2003-09-22  5:14     ` Eli Zaretskii
2003-09-23 18:35       ` Joel Brobecker
2003-09-24  5:34         ` Eli Zaretskii
2003-09-24 18:13           ` Joel Brobecker
2003-09-22  7:24     ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438-Sun21Sep2003152844+0300-eliz@elta.co.il \
    --to=eliz@elta.co.il \
    --cc=brobecker@gnat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox